Commit Graph

4372 Commits

Author SHA1 Message Date
Jean-Philippe Lang
36d487fe50 Replaced some #assert_tag with #assert_select.
git-svn-id: http://svn.redmine.org/redmine/trunk@13620 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-20 19:57:06 +00:00
Jean-Philippe Lang
2a43f1adbc Quote values in DOM selectors for Nokogiri compatibility.
git-svn-id: http://svn.redmine.org/redmine/trunk@13619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-20 19:38:40 +00:00
Toshi MARUYAMA
08bae5928a fix English syntax of skipping test comment of Bazaar non ASCII environment
git-svn-id: http://svn.redmine.org/redmine/trunk@13614 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-18 11:23:16 +00:00
Jean-Philippe Lang
043c2c92da Removed deep nested time entries routes.
git-svn-id: http://svn.redmine.org/redmine/trunk@13609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 21:28:03 +00:00
Jean-Philippe Lang
ecda1c7a4f Use should_route in routing tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13608 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 14:23:32 +00:00
Jean-Philippe Lang
d72e1f95ba Renamed #test_watchers to #test_issue_watchers.
git-svn-id: http://svn.redmine.org/redmine/trunk@13607 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 11:02:04 +00:00
Jean-Philippe Lang
dd2a0554c6 Adds API routing tests for time entries.
git-svn-id: http://svn.redmine.org/redmine/trunk@13606 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 11:00:29 +00:00
Jean-Philippe Lang
d550238894 Removed API tests for routes that are not implemented.
git-svn-id: http://svn.redmine.org/redmine/trunk@13605 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 10:58:15 +00:00
Jean-Philippe Lang
eae9c9ab2b Isolates all API routing tests to a specific test case.
git-svn-id: http://svn.redmine.org/redmine/trunk@13604 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 10:54:33 +00:00
Jean-Philippe Lang
cd6b2f2268 Adds tests for new routes.
git-svn-id: http://svn.redmine.org/redmine/trunk@13603 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 09:01:44 +00:00
Jean-Philippe Lang
1508cd7b8b Moved new group user to its own action GroupsController#new_users.
git-svn-id: http://svn.redmine.org/redmine/trunk@13602 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-16 08:53:39 +00:00
Jean-Philippe Lang
36fc7beb2f Moved new project member to its own action MemberController#new.
git-svn-id: http://svn.redmine.org/redmine/trunk@13600 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-15 11:20:47 +00:00
Jean-Philippe Lang
eac3b2b27d Fixed that Redmine links should not be parsed inside links (#18301).
git-svn-id: http://svn.redmine.org/redmine/trunk@13596 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-14 21:31:27 +00:00
Jean-Philippe Lang
46756cbd56 Fixed 500 error when displaying a news with comments in reverse order (#18332).
git-svn-id: http://svn.redmine.org/redmine/trunk@13595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-14 20:53:14 +00:00
Jean-Philippe Lang
9b971925db Ignore bogus issue strings like [some-string#1234] in email subjects (#17705).
git-svn-id: http://svn.redmine.org/redmine/trunk@13593 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-14 20:43:15 +00:00
Jean-Philippe Lang
c12ba8a76c Fixed that URLs separated by line break are not rendered as links (#18349).
git-svn-id: http://svn.redmine.org/redmine/trunk@13592 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-14 20:18:09 +00:00
Toshi MARUYAMA
f2ddfcda9a add missing fixtures to test/functional/wiki_controller_test.rb
Tests fail randomly.

<pre>
  1) Error:
WikiControllerTest#test_show_with_sidebar:
ActionView::Template::Error: undefined method `name' for nil:NilClass
    app/helpers/application_helper.rb:797:in `block in parse_redmine_links'
    app/helpers/application_helper.rb:757:in `gsub!'
    app/helpers/application_helper.rb:757:in `parse_redmine_links'
    app/helpers/application_helper.rb:601:in `block (2 levels) in textilizable'
    app/helpers/application_helper.rb:600:in `each'
    app/helpers/application_helper.rb:600:in `block in textilizable'
    app/helpers/application_helper.rb:621:in `parse_non_pre_blocks'
    app/helpers/application_helper.rb:599:in `textilizable'
    app/views/wiki/_content.html.erb:2:in `_app_views_wiki__content_html_erb___3773333740575742579_33736820'
    app/views/wiki/show.html.erb:44:in `_app_views_wiki_show_html_erb__965327089377623997_33504680'
    app/controllers/wiki_controller.rb:97:in `show'
    test/functional/wiki_controller_test.rb:119:in `test_show_with_sidebar'
</pre>

It can be reproduced by following change.

<pre>
 class WikiControllerTest < ActionController::TestCase
   fixtures :projects, :users, :roles, :members, :member_roles,
            :enabled_modules, :wikis, :wiki_pages, :wiki_contents,
-           :wiki_content_versions, :attachments
+           :wiki_content_versions, :attachments,
+           :issues #, :issue_statuses
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13590 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-12 03:44:47 +00:00
Jean-Philippe Lang
bdd3ccf8e5 Adds a role setting for controlling visibility of users: all or members of visible projects (#11724).
git-svn-id: http://svn.redmine.org/redmine/trunk@13584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-11 13:08:52 +00:00
Jean-Philippe Lang
140ca9532c Adds a test for default issue columns order (#18310).
git-svn-id: http://svn.redmine.org/redmine/trunk@13583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-11 12:33:06 +00:00
Jean-Philippe Lang
700736de5d Fixed duplicate test names (#18306).
git-svn-id: http://svn.redmine.org/redmine/trunk@13575 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 11:02:44 +00:00
Jean-Philippe Lang
13f9ccaed8 Adds configuration settings to limit valid repository path (#1415).
git-svn-id: http://svn.redmine.org/redmine/trunk@13573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 10:52:59 +00:00
Toshi MARUYAMA
34bb545e4f prevent test failures with "trackers is invalid"
See r13571 comment.

git-svn-id: http://svn.redmine.org/redmine/trunk@13572 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 07:22:44 +00:00
Toshi MARUYAMA
3815bb3bdc add missing fixture to test/unit/enabled_module_test.rb
Test fails randomly.

<pre>
  1) Error:
EnabledModuleTest#test_enabling_wiki_should_create_a_wiki:
ActiveRecord::RecordInvalid: Validation failed: trackers is invalid, trackers is invalid, trackers is invalid
    test/unit/enabled_module_test.rb:25:in `test_enabling_wiki_should_create_a_wiki'
</pre>

It can be reproduced on clean db and following change.

<pre>
-  fixtures :projects, :wikis
+  fixtures :projects, :trackers, :wikis
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13571 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 06:40:38 +00:00
Toshi MARUYAMA
2a5bc15344 remove duplicated IssuesControllerTest#test_new_should_select_default_status (#5991, #18305)
git-svn-id: http://svn.redmine.org/redmine/trunk@13570 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-08 04:46:44 +00:00
Toshi MARUYAMA
426780c6b1 add missing fixtures to test/unit/issue_status_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13569 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-07 00:38:21 +00:00
Jean-Philippe Lang
5326eb233e Overrides IssueRelation#to_s.
git-svn-id: http://svn.redmine.org/redmine/trunk@13563 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-05 16:14:20 +00:00
Jean-Philippe Lang
b2ba7db4e1 Time entries CSV export should include the tracker and subject of the issue (#18269).
git-svn-id: http://svn.redmine.org/redmine/trunk@13562 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-05 15:23:22 +00:00
Jean-Philippe Lang
4c9fcb34b6 Typo.
git-svn-id: http://svn.redmine.org/redmine/trunk@13561 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-05 15:17:21 +00:00
Jean-Philippe Lang
5052d48491 Fixed that setting a status as closed should update issue closed_on attribute (#18280).
git-svn-id: http://svn.redmine.org/redmine/trunk@13560 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-05 14:51:04 +00:00
Toshi MARUYAMA
6bb699d65f use English in test (#18276)
git-svn-id: http://svn.redmine.org/redmine/trunk@13559 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-04 23:43:17 +00:00
Jean-Philippe Lang
bc3bd8aff2 Let QueryColumn accept a Proc as caption (#18276).
git-svn-id: http://svn.redmine.org/redmine/trunk@13558 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-04 21:00:59 +00:00
Jean-Philippe Lang
4cd67587ce Fixed that a disabled field which is required by workflow rules blocks issue creation/update (#17744).
git-svn-id: http://svn.redmine.org/redmine/trunk@13557 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-04 20:49:46 +00:00
Jean-Philippe Lang
984e5a36bb Fixed that parent column should not include issue subject (#13673).
git-svn-id: http://svn.redmine.org/redmine/trunk@13556 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-04 20:17:44 +00:00
Jean-Philippe Lang
db63f5a925 Fixed CSV content for parent issue column (#13608).
git-svn-id: http://svn.redmine.org/redmine/trunk@13555 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-04 20:02:27 +00:00
Toshi MARUYAMA
41023cb5ff add missing fixture to test/unit/query_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13551 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-03 08:25:12 +00:00
Toshi MARUYAMA
9357ba1d4b add missing fixtures to test/functional/custom_fields_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13550 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-03 08:13:08 +00:00
Toshi MARUYAMA
fb6955b21c add missing fixture to test/functional/issue_statuses_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13549 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-03 07:37:15 +00:00
Toshi MARUYAMA
ebda9caa87 add missing fixture to test/unit/project_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13548 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-03 07:19:47 +00:00
Jean-Philippe Lang
dfc594c337 Default status per tracker (#5991).
git-svn-id: http://svn.redmine.org/redmine/trunk@13535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-02 19:45:14 +00:00
Jean-Philippe Lang
32b79b6fd4 Fixed that IssueRelation should not be responsible for calling Issue#init_journal (#18237).
git-svn-id: http://svn.redmine.org/redmine/trunk@13534 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-02 15:38:11 +00:00
Jean-Philippe Lang
cb2cd12dad Need to require net/ldap in tests (#18192).
git-svn-id: http://svn.redmine.org/redmine/trunk@13521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-28 18:29:44 +00:00
Jean-Philippe Lang
0b6a159622 Don't rely on users fixtures.
git-svn-id: http://svn.redmine.org/redmine/trunk@13512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-26 14:43:14 +00:00
Jean-Philippe Lang
c0f082ad02 Code cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@13508 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-25 09:35:17 +00:00
Jean-Philippe Lang
67c4936908 Restores commits reverted when rails-4.1 branch was merged (#18174).
Patch by Mischa The Evil.

git-svn-id: http://svn.redmine.org/redmine/trunk@13504 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 18:41:35 +00:00
Toshi MARUYAMA
b63123ac1e add missing fixtures to CalendarsControllerTest
Tests fail randomly.

<pre>
  1) Error:
CalendarsControllerTest#test_cross_project_calendar:
ActionView::Template::Error: undefined method `name' for nil:NilClass
    app/helpers/issues_helper.rb:57:in `render_issue_tooltip'
    app/views/common/_calendar.html.erb:17:in `block in _app_views_common__calendar_html_erb__4084073314711523042_57686480'
    app/views/common/_calendar.html.erb:12:in `each'
    app/views/common/_calendar.html.erb:12:in `_app_views_common__calendar_html_erb__4084073314711523042_57686480'
    app/views/calendars/show.html.erb:30:in `_app_views_calendars_show_html_erb___1639405444546230501_53808060'
    test/functional/calendars_controller_test.rb:44:in `test_cross_project_calendar'
</pre>

git-svn-id: http://svn.redmine.org/redmine/trunk@13503 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 04:13:17 +00:00
Toshi MARUYAMA
6f92548b38 remove unneeded "references" of joins
"references" is needed for includes, but not needed for joins.

git-svn-id: http://svn.redmine.org/redmine/trunk@13501 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-24 02:18:45 +00:00
Jean-Philippe Lang
c2e73160da Adds a single controller for users and groups memberships and support for adding multiple projects at once (#11702).
git-svn-id: http://svn.redmine.org/redmine/trunk@13498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-23 21:46:40 +00:00
Toshi MARUYAMA
44a5eedf8f add missing fixtures to test/unit/helpers/routes_helper_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@13495 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-23 04:55:37 +00:00
Jean-Philippe Lang
360895068e Code cleanup, use array instead of handcrafted update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13485 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 18:51:00 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00