Commit Graph

158 Commits

Author SHA1 Message Date
Go MAEDA
e48ff48820 Evaluate acts_as_activity_provider's scope lazily (#33664).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Go MAEDA
b0739821e8 Locked users in a group receive notifications when the group is added as a watcher (#4511, #33935).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19998 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-01 14:08:45 +00:00
Go MAEDA
ee46c3570e Use scope assignable_watchers (#4511).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-25 08:01:59 +00:00
Go MAEDA
b270a38928 Use principals in acts_as_watchable (#4511).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19725 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-25 08:00:55 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
b9b841b23f Updating custom fields does not trigger update to "updated_on" field in the customized object (#5354).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19541 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 06:42:00 +00:00
Go MAEDA
39c979b341 Reverts r19510 that breaks IssueTest#test_closed_on_should_be_set_when_closing_an_open_issue (#5354).
git-svn-id: http://svn.redmine.org/redmine/trunk@19511 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-11 04:56:03 +00:00
Go MAEDA
89c4e16807 Updating custom fields does not trigger update to "updated_on" field in the customized object (#5354).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19510 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-11 04:06:25 +00:00
Go MAEDA
b995014c49 Allow adding user groups as watchers for issues (#4511).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-06 08:19:13 +00:00
Go MAEDA
ba7d4745e2 Fix ruby 2.7 warning: The last argument is used as the keyword parameter (#32542, #31500).
Patch by Seiei Miyagi.


git-svn-id: http://svn.redmine.org/redmine/trunk@19454 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-23 15:42:50 +00:00
Go MAEDA
b67cb67cce Remove code for unsupported versions of Rails from open_id_authentication (#32297).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18788 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 01:34:21 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
f992df684f Small refactorization of avatar methods (#31391).
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the  size 24
* class 'gravatar' is always added and all custom classes are appended
* added user name as default title for avatar images
* added two new methods: @assignee_avatar@ and @author_avatar@

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-19 22:27:41 +00:00
Go MAEDA
aaf432e5be Remove the :ssl option which is not used anymore (#31022).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-08 21:46:01 +00:00
Go MAEDA
bf0246ce83 Add avatar_server_url configuration option in order to support Libravatar (#9112).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18124 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-04 15:59:50 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
3b55f65407 Remove frozen_string_literal magic comment from files which are not used when running the application or tests (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@17997 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-21 06:06:53 +00:00
Go MAEDA
30e341db69 Support frozen_string_literal in lib/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 16:36:34 +00:00
Go MAEDA
d16369b67c Enable frozen_string_literal for files which don't contain string literals (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17981 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 01:47:12 +00:00
Go MAEDA
e050625a29 Always use HTTPS when accessing gravatar.com (#31022).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17948 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 03:14:26 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
9f4a4be01a Remove trailing whitespaces from lib/plugins/gravatar/lib/gravatar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@17946 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-14 06:28:18 +00:00
Jean-Philippe Lang
53ea8dd979 Deadlock when assigning custom values (#30465).
Patch by Pavel Rosický.

git-svn-id: http://svn.redmine.org/redmine/trunk@17823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-01-19 11:57:19 +00:00
Jean-Philippe Lang
e856c9f879 Fixed that issue details page shows default values for custom fields that aren't actually set (#25726).
git-svn-id: http://svn.redmine.org/redmine/trunk@17499 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 08:25:25 +00:00
Go MAEDA
ed14823d13 Replace Hash#keys.each with faster Hash#each_key (#29305).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-08-01 14:28:39 +00:00
Go MAEDA
bff0fbce8b Remove RDoc tags (#28943).
Patch by Sho HASHIMOTO.


git-svn-id: http://svn.redmine.org/redmine/trunk@17370 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-08 00:55:41 +00:00
Go MAEDA
14e0a6bdba Use reverse_each instead of reverse.each (#27671).
Patch by Timur Tarasenko.


git-svn-id: http://svn.redmine.org/redmine/trunk@17137 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-31 01:34:39 +00:00
Jean-Philippe Lang
71423af0b2 Get rid of acts_as_versioned.
WikiContent::Version becomes WikiContentVersion.

git-svn-id: http://svn.redmine.org/redmine/trunk@16889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-26 16:41:06 +00:00
Toshi MARUYAMA
ee99e5bfcc fix search engine returns 500 error by Go MAEDA (#26526)
git-svn-id: http://svn.redmine.org/redmine/trunk@16879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-25 12:08:02 +00:00
Toshi MARUYAMA
11a1f02cc7 remove trailing white spaces from lib/plugins/acts_as_searchable/lib/acts_as_searchable.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16878 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-25 12:07:52 +00:00
Jean-Philippe Lang
1ab658db59 Removes acts_as_list plugin.
git-svn-id: http://svn.redmine.org/redmine/trunk@16872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 16:19:34 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
6139e0033a spelling fixes (#25495)
git-svn-id: http://svn.redmine.org/redmine/trunk@16445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-02 03:34:44 +00:00
Jean-Philippe Lang
2503731d3c Removes invalid attributes from gravatar img tag.
git-svn-id: http://svn.redmine.org/redmine/trunk@16372 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-03-05 08:55:13 +00:00
Jean-Philippe Lang
dac7903da3 Fixes uploading of empty files (#25115).
- prevents creation of attachment records without existing diskfile and empty
  digest
- adds test case to check file upload API response
- also removes the file size check in ActsAsAttachable which still prevented
  attachment of zero size attachments to containers but only for clients
  without Javascript (where save_attachments is called with the actual file
  upload).
  
Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16341 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-02-28 18:05:17 +00:00
Jean-Philippe Lang
79d5d30705 Hires (2x DPR) image support for Gravatars (#24927).
Patch by Jan Schulz-Hofen.

git-svn-id: http://svn.redmine.org/redmine/trunk@16313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-30 19:40:57 +00:00
Jean-Philippe Lang
2c70d9e988 Set inverse on custom_values association.
git-svn-id: http://svn.redmine.org/redmine/trunk@16220 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-18 12:52:42 +00:00
Jean-Philippe Lang
2b70d97705 acts_as_versioned use old style (Rails 2.x) of method call for #all (#24348).
git-svn-id: http://svn.redmine.org/redmine/trunk@15950 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-18 07:19:13 +00:00
Jean-Philippe Lang
ef45304817 Adds file custom field format (#6719).
git-svn-id: http://svn.redmine.org/redmine/trunk@15917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-23 09:16:14 +00:00
Jean-Philippe Lang
d2f7e31951 Use .distinct instead of .uniq.
git-svn-id: http://svn.redmine.org/redmine/trunk@15654 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:15:13 +00:00
Jean-Philippe Lang
e58e676b7c Removes a call to alias_method_chain.
git-svn-id: http://svn.redmine.org/redmine/trunk@15653 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 06:52:38 +00:00
Jean-Philippe Lang
541241a849 Removes a call to alias_method_chain.
git-svn-id: http://svn.redmine.org/redmine/trunk@15652 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 06:49:44 +00:00
Jean-Philippe Lang
f416657d56 When creating issues by receiving an email, watchers created via CC in the mail don't get an email notification (#23278).
git-svn-id: http://svn.redmine.org/redmine/trunk@15609 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-09 03:15:32 +00:00
Jean-Philippe Lang
40c9c3e922 Notify the user of missing attachments (#22401).
under certain (rare) circumstances it may happen that, when an issue or other
container is saved, added attachments have already been removed (i.e. by the
attachments:prune rake task). This patch adds a validation error to the
container in this case.

Patch by Jens Kraemer.

git-svn-id: http://svn.redmine.org/redmine/trunk@15378 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-05-07 10:31:20 +00:00
Jean-Philippe Lang
db64340419 Deprecates unused stuff (#12909).
git-svn-id: http://svn.redmine.org/redmine/trunk@15338 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-18 18:04:23 +00:00
Jean-Philippe Lang
bb2c6f6076 Fixed that subtasks lose their custom fields when copying an issue to a different project (#22342).
git-svn-id: http://svn.redmine.org/redmine/trunk@15318 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-11 17:11:59 +00:00
Jean-Philippe Lang
3de694f5e5 Use protocol-relative URL for gravatars (#21855).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@15245 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-15 21:52:20 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
e6112a9710 New custom fields of existing issues are not initialized with their default value (#21074).
git-svn-id: http://svn.redmine.org/redmine/trunk@14773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-10-31 09:17:29 +00:00