Commit Graph

881 Commits

Author SHA1 Message Date
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 15:03:47 +00:00
Go MAEDA
e70c283a22 Remove unnecessary encoding magic comment (#31034).
The default script encoding is UTF-8 in Ruby 2.0 or later.

Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 06:26:33 +00:00
Jean-Philippe Lang
5da9cc59ee PluginRequirementError is now raised instead of PluginNotFound (#31030).
git-svn-id: http://svn.redmine.org/redmine/trunk@17966 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 09:49:04 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
019b640d81 Reverts r17891 (#30099).
git-svn-id: http://svn.redmine.org/redmine/trunk@17939 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-10 23:37:57 +00:00
Go MAEDA
bdcadb8ced Allow collapse/expand in gantt chart (#6417).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17929 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-05 14:52:09 +00:00
Go MAEDA
ef9c879718 Multiple blank lines in pre tags are not preserved in Textile (#30099).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17891 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-20 10:31:30 +00:00
Go MAEDA
5509358885 "rake db:fixtures:load" does not work (#30811).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17889 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-19 11:03:10 +00:00
Go MAEDA
bce44769ff Redmine::WikiFormattingTest#test_links_separated_with_line_break_should_link tests nothing (#30347).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17785 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-01-10 09:07:05 +00:00
Go MAEDA
6ece31ff63 Remove trailing whitespaces from test/unit/lib/redmine/wiki_formatting_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@17784 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-01-10 09:03:34 +00:00
Go MAEDA
6765505b2d Add missing fixtures to several tests (#30276).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-01-09 14:26:56 +00:00
Go MAEDA
1ffdaafb3b Test for r17763 (#30171).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17764 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-17 04:52:36 +00:00
Jean-Philippe Lang
2576292959 Set User.current to nil before unit tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@17761 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-16 17:23:31 +00:00
Jean-Philippe Lang
4bbe2fc7e6 Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17759 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-16 17:07:52 +00:00
Jean-Philippe Lang
2fdbcd35dd Adds a permission to log time for another user (#3848).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17755 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-16 16:28:22 +00:00
Jean-Philippe Lang
10eba2878a Test failure.
git-svn-id: http://svn.redmine.org/redmine/trunk@17737 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-15 15:20:17 +00:00
Jean-Philippe Lang
4ce9de94bc Tests failure with SQLite3.
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)

git-svn-id: http://svn.redmine.org/redmine/trunk@17675 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-01 12:38:16 +00:00
Jean-Philippe Lang
4770fa5b6a Tests for #29674.
Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@17646 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-28 18:15:56 +00:00
Jean-Philippe Lang
f130bf9e2b REST API with JSON content missing false values (#20788).
Patch by Yuichi HARADA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17643 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-28 18:03:07 +00:00
Go MAEDA
7fbcb8c908 Tags start with 'pre' are handled as 'pre' tag in Textile (#8395).
Patch by Takenori TAKAKI and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-26 04:40:09 +00:00
Go MAEDA
9c99d50713 Removes request and response accessors from Structure class (#28564).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@17617 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-03 08:11:22 +00:00
Go MAEDA
e8243d213d \f or \v character in Textile markup may cause RegexpError exception (#29756).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17603 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-28 11:01:54 +00:00
Go MAEDA
7be4200651 Fix broken tests due to r17593 (#29739).
git-svn-id: http://svn.redmine.org/redmine/trunk@17594 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-11 16:14:37 +00:00
Jean-Philippe Lang
eb1e6d8c26 Syntax highlighter: replace CodeRay with Rouge (#24681).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-29 06:57:40 +00:00
Jean-Philippe Lang
daa7d2ba18 Support migration context for plugins (#28934).
git-svn-id: http://svn.redmine.org/redmine/trunk@17514 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-23 14:22:29 +00:00
Go MAEDA
2cffbf1d45 Fix typo in test name: s/highligth/highlight/ (#29440).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17477 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-08-26 11:37:13 +00:00
Go MAEDA
bd08684e1d Test that Redmine::MimeType.css_class_of, main_mimetype_of and is_type? are case-insensitive (#29359).
git-svn-id: http://svn.redmine.org/redmine/trunk@17472 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-08-15 13:20:45 +00:00
Go MAEDA
371d84556f Test that Redmine::MimeType.of is case-insensitive (#29359).
git-svn-id: http://svn.redmine.org/redmine/trunk@17471 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-08-15 01:23:56 +00:00
Go MAEDA
26f4b5181f Fix: Textile phrase modifiers break wiki macros (#29247).
Patch by Stephan Wenzel.


git-svn-id: http://svn.redmine.org/redmine/trunk@17450 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-07-21 00:16:27 +00:00
Jean-Philippe Lang
f748296121 Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address (#27968).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17394 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-17 06:00:21 +00:00
Jean-Philippe Lang
794a2a0180 Enable and add underline button to the toolbar for Markdown formatting (#28169).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17385 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-16 10:56:52 +00:00
Go MAEDA
ca2875fab2 Allow switching the encoding to UTF-8 when exporting to CSV (#26279).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17328 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-07 01:13:12 +00:00
Go MAEDA
00b85dc8d9 Fix: Syntax highlighter does not work if language name is single-quoted (#28469).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17322 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-05-02 02:27:10 +00:00
Go MAEDA
b178150761 Show renames in diff preview (#28295).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-27 09:14:36 +00:00
Go MAEDA
8b0bfbbc8b Gantt bars with start date and end date on the same day don't become red by overdue (#13521).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17294 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-09 13:00:41 +00:00
Jean-Philippe Lang
040f31d867 Markdown pre-block could derive incorrect wiki sections (#25299).
Patch by Kiichi Ozaki.

git-svn-id: http://svn.redmine.org/redmine/trunk@17266 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-07 07:34:43 +00:00
Go MAEDA
e9fb90856f Move textile footnotes test to TextileFormatterTest (#28207).
Patch by Mischa The Evil.


git-svn-id: http://svn.redmine.org/redmine/trunk@17222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:58:52 +00:00
Go MAEDA
8d033d08d0 Add footnotes test for markdown formatter (#28207).
Patch by Mischa The Evil.


git-svn-id: http://svn.redmine.org/redmine/trunk@17221 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-03-02 04:55:52 +00:00
Go MAEDA
5ed4031b64 Add minimal fixture for issues_pdf_test (#12510).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17212 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-24 09:26:26 +00:00
Go MAEDA
241e4cbb68 Enable lax_spacing for markdown formatting (#28119).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-02-16 05:01:14 +00:00
Go MAEDA
f496402634 Add tests for "height" and "max-height" (#26552).
git-svn-id: http://svn.redmine.org/redmine/trunk@17175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-13 00:32:53 +00:00
Go MAEDA
e4142a8338 Allow "max-height", "max-width", "min-height" and "min-width" CSS properties in Textile (#26552).
Patch by Michael Gerz and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-11 01:32:18 +00:00
Jean-Philippe Lang
4c0638c5f9 Unable to download file if custom field is not defined as visible to any users (#26705).
git-svn-id: http://svn.redmine.org/redmine/trunk@17158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-08 17:43:31 +00:00
Go MAEDA
c35433ad01 Links for custom field value don't have "external" class (#27024).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17138 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-01-01 06:18:01 +00:00
Toshi MARUYAMA
4e7ae640b9 add copyright header to test/unit/lib/redmine/helpers/url_test.rb (#12510)
git-svn-id: http://svn.redmine.org/redmine/trunk@17077 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 14:28:41 +00:00
Toshi MARUYAMA
93d8204b8a code clean up IssuesPdfHelperTest (#12510)
* remove extra empty lines
* remove trailing white space
* replace tab to two spaces

git-svn-id: http://svn.redmine.org/redmine/trunk@17065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 12:03:08 +00:00
Toshi MARUYAMA
9d797400ea mercurial: work around faulty parsing of early command options (#27516)
Use -sVALUE and --long=VALUE instead of "-s VALUE" and "--long VALUE"
respectively.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17062 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:47 +00:00
Toshi MARUYAMA
ca87bf766c mercurial: reject malicious command argument (#27516)
We've got a security report from the Phabricator team, which basically says
--config and --debugger arguments can be injected anywhere to lead to an
arbitrary command execution.

https://secure.phabricator.com/rPa7921a4448093d00defa8bd18f35b8c8f8bf3314

This is a fundamental issue of the argument parsing rules in Mercurial, which
allows extensions to populate their parsing rules and such extensions can be
loaded by "--config extensions.<name>=". There's a chicken and egg problem.
We're working on hardening the parsing rules, but which won't come in by
default as it would be a behavior change.

This patch adds a verification to reject malicious command arguments as a
last ditch. The subsequent patches will fix the problem in more appropriate
way.

Contributed by Yuya Nishihara.

git-svn-id: http://svn.redmine.org/redmine/trunk@17060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-07 11:38:23 +00:00
Go MAEDA
d6d2d23365 Fix: Round floats to 2 digits when rendering an issue list to PDF (#12510).
Patch by Holger Just and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17059 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-12-06 14:25:35 +00:00
Jean-Philippe Lang
62d6dfe1cc Fixes visibility checks for version.fixed_issues in Gantt (#27676).
Like the version page - the Gantt chart featured a "percent done" info
for each version, which wasn't properly limited to visible issues.

Patch by Gregor Schmidt.

git-svn-id: http://svn.redmine.org/redmine/trunk@17053 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-11-29 19:38:44 +00:00