Commit Graph

61 Commits

Author SHA1 Message Date
Go MAEDA
4fb1e4bea0 Use fixtures :all to ensure consistent test data and improve test reliability (#41961).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 10:17:57 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
21a6fc71d6 Fix RuboCop offense Performance/MapMethodChain (#37247).
git-svn-id: https://svn.redmine.org/redmine/trunk@22280 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-08-23 09:05:20 +00:00
Go MAEDA
1481c721a2 Use require_relative instead of require File.expand_path(..., __FILE__) (#38093).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22016 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 07:13:39 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
ab2b130e3c Ignore statuses if workflow only defines identity transition (#37636).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@21818 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-17 07:58:12 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
f2b17f7794 Clean-up workflows controller (#33337).
Patch by Vincent Robert and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20941 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-13 09:01:44 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
85193e8d10 Fix that WorkflowsControllerTest fails if table cells have more than one CSS class (#34247).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20716 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-17 01:48:13 +00:00
Go MAEDA
e9e0c538da Use more efficient "exists?" instead of "first" in tests when checking the existence of rows (#33367).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-03 00:44:08 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
6b0afdc9ca "Role" dropdown in Workflow page is unexpectedly expanded when selecting "all" (#33059).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19538 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-29 04:59:48 +00:00
Toshi MARUYAMA
989b44ac3b cleanup: rubocop: fix Layout/AlignArguments in test/functional/workflows_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-06 12:04:52 +00:00
Go MAEDA
545a050ba3 Code cleanup: RuboCop: Fix Performance/Count and Performance/Detect.
This change corrects newly detected offenses after updating rubocop-performance to 1.5.0 in r18579.


git-svn-id: http://svn.redmine.org/redmine/trunk@18580 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-02 00:53:11 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 15:03:47 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
58e3e4e441 Test failure with SQLite3.
ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALUES (?, ?)


git-svn-id: http://svn.redmine.org/redmine/trunk@17728 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-12-13 17:38:43 +00:00
Jean-Philippe Lang
04e94bd3dd Disable workflow checkboxes with no status change (#5593).
Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17487 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-09-15 07:09:14 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
0fbfcfafe9 remove trailing white space from test/functional/workflows_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16612 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-06 04:57:39 +00:00
Jean-Philippe Lang
68c7f4ef20 Workflow editing shows statuses of irrelevant roles (#24281).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-16 08:32:35 +00:00
Jean-Philippe Lang
29ddc82a11 Removes calls to #assert_template and #assigns in functional tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@15724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-21 16:58:59 +00:00
Jean-Philippe Lang
6cc6a918b4 Pass parameters with :params in controller tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@15666 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 07:43:16 +00:00
Jean-Philippe Lang
2e4e610930 Adds our own class for controller tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@15661 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 09:35:49 +00:00
Jean-Philippe Lang
05d1df45da Highlighting of required and read-only custom fields broken in Workflow editor (#22305).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@15293 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-03 11:58:23 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
2bc5b60f9d Makes new issue initial status settable in workflow (#5816).
git-svn-id: http://svn.redmine.org/redmine/trunk@14458 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-07-26 08:30:19 +00:00
Jean-Philippe Lang
b474ad67de "Required" and "Read-only" rules on "Fields Permissions" screen are not colored (#19580).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@14160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-04-11 07:54:20 +00:00
Jean-Philippe Lang
d85f73a30d Upgrade to Rails 4.2.0 (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13892 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-17 17:02:55 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
5222650d95 Adds a few tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@13695 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-03 20:21:03 +00:00
Jean-Philippe Lang
f3e573b5f8 Replaced remaining #assert_tag with #assert_select.
git-svn-id: http://svn.redmine.org/redmine/trunk@13624 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-22 09:38:21 +00:00
Jean-Philippe Lang
2a43f1adbc Quote values in DOM selectors for Nokogiri compatibility.
git-svn-id: http://svn.redmine.org/redmine/trunk@13619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-20 19:38:40 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
b6c794d16b Bulk edit workflows for multiple trackers/roles (#16164).
git-svn-id: http://svn.redmine.org/redmine/trunk@12924 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-25 02:54:47 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
c0303bf47c remove unneeded Relation#all from WorkflowsControllerTest#status_transitions
git-svn-id: http://svn.redmine.org/redmine/trunk@12581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-10 03:54:23 +00:00
Jean-Philippe Lang
628d05629b Role-based issue custom field visibility (#5037).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@12012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-07-13 09:20:11 +00:00
Jean-Philippe Lang
f9ddb562d5 Cleanup of finders with :conditions option.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11963 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-06-12 19:13:25 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
24be0551cc Code cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-11 20:38:26 +00:00
Jean-Philippe Lang
4cc4e8bfd3 Functional tests cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10936 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-03 22:23:23 +00:00
Jean-Philippe Lang
31c33f462d Replaces find(:first) calls.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-03 18:21:32 +00:00
Jean-Philippe Lang
536747b747 Replaces find(:all) calls.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10917 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-02 20:23:48 +00:00
Jean-Philippe Lang
7f1fb7ce81 Don't show "Required" option for standard/custom fields that are always required.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10010 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-16 16:33:27 +00:00
Jean-Philippe Lang
e23511076c No blank option for custom fields marked as required on workflow settings.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-15 16:57:04 +00:00
Jean-Philippe Lang
a7bdc5e0af Adds option for displaying all statuses on workflow permissions.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9995 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-15 15:46:14 +00:00