Commit Graph

129 Commits

Author SHA1 Message Date
Go MAEDA
4fb1e4bea0 Use fixtures :all to ensure consistent test data and improve test reliability (#41961).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 10:17:57 +00:00
Go MAEDA
74e2262efb Fix RuboCop offense Layout/EmptyLinesAroundMethodBody, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22950 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 07:46:58 +00:00
Marius Balteanu
42b01c19ca Adds test for bulk unlock users (#40913).
git-svn-id: https://svn.redmine.org/redmine/trunk@22930 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-14 10:35:51 +00:00
Marius Balteanu
193ca9faee Add bulk lock feature to user list context menu (#40913).
Patch by Mizuki ISHIKAWA (@ishikawa999).


git-svn-id: https://svn.redmine.org/redmine/trunk@22898 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-25 19:03:36 +00:00
Go MAEDA
b803bddb1f Fix "ArgumentError: Invalid response name: unprocessable_entity" with Rack 3.1.0+ in assert_response (#39889).
Rack 3.1.0 changed the symbol for HTTP status code 422 from `:unprocessable_entity` to `:unprocessable_content`.
Due to the change, `assert_response(:unprocessable_entity, ...)` raises ArgumentError with Rack 3.1.0+.

This fix is a follow-up to r22837.


git-svn-id: https://svn.redmine.org/redmine/trunk@22876 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-12 16:09:37 +00:00
Marius Balteanu
38a8adb2a2 Adds description field to custom queries (#9309).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22855 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-04 20:04:45 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
4dc56cd943 Exporting UserQuery does not use the query name as file name (#37674, #38182).
Patch by Takenori TAKAKI.


git-svn-id: https://svn.redmine.org/redmine/trunk@22121 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-01 08:47:28 +00:00
Go MAEDA
1481c721a2 Use require_relative instead of require File.expand_path(..., __FILE__) (#38093).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22016 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 07:13:39 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Marius Balteanu
20baf029ba Fix undefined method when auth source name column is added as column (#37674).
git-svn-id: https://svn.redmine.org/redmine/trunk@21861 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-27 19:55:09 +00:00
Go MAEDA
62f7551d57 User bulk destroy (#37674).
includes a confirmation page that also gives the opportunity to lock
users instead of deleting them.

Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-20 03:36:40 +00:00
Go MAEDA
cd70187c2f Introduces a UserQuery model for admin/users (#37674).
Patch by Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-20 03:16:05 +00:00
Go MAEDA
856f104031 Fix RuboCop offense Layout/FirstHashElementIndentation (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@21696 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-30 09:30:03 +00:00
Marius Balteanu
a5cd3f791c Add "Two-factor authentication" filter and column to Users list in administration (#35934).
git-svn-id: http://svn.redmine.org/redmine/trunk@21380 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-22 08:53:41 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
39e212dd8f Password and Confirmation fields are marked as required when editing a user (#35731).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21167 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-13 02:56:04 +00:00
Marius Balteanu
805b36cbfb Remove unused setting 'Blind carbon copy recipients (bcc)' (#30820).
git-svn-id: http://svn.redmine.org/redmine/trunk@21130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-01 17:25:13 +00:00
Go MAEDA
a8a87ef47e Security notification is not sent when an admin changes the password of a user (#32199).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21006 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-24 06:28:23 +00:00
Go MAEDA
f30c91341a Rails 6.1: add header=present to csv tests (#29914, #32921).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:59:31 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
5063d3faf0 Fix that users can delete their own accounts unconditionally via REST API (#11870).
Patch by Mizuki ISHIKAWA and Kevin Fischer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20782 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-13 07:20:57 +00:00
Go MAEDA
086c95569e Require explicit confirmation before deleting a user (#34417).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20600 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-10 00:57:38 +00:00
Go MAEDA
c8227930f9 TypeError when attempting to update a user with a blank email address (#33355).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20562 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-03 15:14:35 +00:00
Toshi MARUYAMA
07935e093d use with_settings at UsersControllerTest#test_update_with_generate_password_should_email_the_password
git-svn-id: http://svn.redmine.org/redmine/trunk@20413 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-17 12:41:48 +00:00
Toshi MARUYAMA
27aad8c10d use with_settings at UsersControllerTest#test_update_with_password_change_should_send_a_notification
git-svn-id: http://svn.redmine.org/redmine/trunk@20400 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-16 12:22:54 +00:00
Toshi MARUYAMA
90405c2021 use with_settings at UsersControllerTest#test_update_with_activation_should_send_a_notification
git-svn-id: http://svn.redmine.org/redmine/trunk@20388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-15 12:37:25 +00:00
Toshi MARUYAMA
99375c1d34 use with_settings at UsersControllerTest#test_create
git-svn-id: http://svn.redmine.org/redmine/trunk@20375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-14 13:19:12 +00:00
Toshi MARUYAMA
923d218884 remove spaces inside {} of UsersControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@20365 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-14 13:17:47 +00:00
Go MAEDA
167637730d Include twofa_scheme (two-factor scheme) column when exporting users to CSV (#34241).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20350 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-13 01:08:15 +00:00
Go MAEDA
50ba4dc51e Add missing fixture to UsersControllerTest (#33786).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19943 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-02 05:38:15 +00:00
Go MAEDA
fc3c4abc12 Additional email addresses are not displayed in user profile page (#33601).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19836 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-27 05:43:42 +00:00
Go MAEDA
835b533889 Include updated_on and passwd_changed_on columns when exporting users to CSV (#33347).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19740 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-05-02 03:03:00 +00:00
Go MAEDA
a14697df68 Unify CSS classes for custom fields in issue#show, issue#edit and issue#bulk_edit (#32471).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19690 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-11 09:00:34 +00:00
Go MAEDA
aa4d0c6bda Support custom fields when exporting users to CSV (#33126).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19642 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-04 01:42:16 +00:00
Go MAEDA
d449409ab9 Unable to edit user or group that has custom fields with text formatting enabled (#33183).
Patch by Go MAEDA and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19613 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-24 12:56:35 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
2de3dfeae5 CSV related tests fail with Rails 5.2.4 (#32526, #32525).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19344 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-12-08 00:10:43 +00:00
Toshi MARUYAMA
b6296adf16 code layout clean up test/functional/users_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19295 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 16:47:09 +00:00
Toshi MARUYAMA
c9c52741e2 code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in test/functional/users_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18660 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-14 14:52:23 +00:00
Jean-Philippe Lang
04b8be1d5b User preference for issue history default tab (#3058).
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@18277 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 07:13:54 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
da78e654f1 Display user's gravatar when editing profile (#5899).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18180 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-20 08:51:04 +00:00
Go MAEDA
f24f0519be Update Rails to 5.2.3 (#31113).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18028 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-31 09:58:08 +00:00
Go MAEDA
32dce42b71 Show projects using a table instead of an unordered list in the user profile page (#31066).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@18012 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-28 23:44:28 +00:00
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 15:03:47 +00:00
Jean-Philippe Lang
ccda34cac6 Display user's groups on profile (#12796).
Only for admins or when viewing its own profile.

git-svn-id: http://svn.redmine.org/redmine/trunk@17973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 11:49:51 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
12968c0843 Add CSS class to user custom fields (#30985).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17935 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-09 15:07:36 +00:00