Commit Graph

66 Commits

Author SHA1 Message Date
Go MAEDA
4fb1e4bea0 Use fixtures :all to ensure consistent test data and improve test reliability (#41961).
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23391 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-12-11 10:17:57 +00:00
Go MAEDA
a9518e28b8 Fix RuboCop offense Rails/HttpStatus (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-18 05:56:55 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
21a6fc71d6 Fix RuboCop offense Performance/MapMethodChain (#37247).
git-svn-id: https://svn.redmine.org/redmine/trunk@22280 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-08-23 09:05:20 +00:00
Go MAEDA
bf239fae8a Add breadcrumbs to news pages (#2631).
Patch by Brad Beattie.


git-svn-id: https://svn.redmine.org/redmine/trunk@22236 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-05-09 00:26:17 +00:00
Go MAEDA
9d65eee424 Avoid double-render error with ApplicationController#find_optional_project (#38063).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22066 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-20 03:31:41 +00:00
Go MAEDA
1481c721a2 Use require_relative instead of require File.expand_path(..., __FILE__) (#38093).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22016 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 07:13:39 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
1918943020 "Add news" button on global news index is displayed for users without permission (#35308).
Patch by Alexander Meindl and Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21014 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-29 06:44:54 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
4c2e42e1c3 "Add news" button in cross-project News tab (#33167).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20845 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 05:16:54 +00:00
Go MAEDA
6e781f6479 Fix that "Successful deletion" notice is not displayed after deleting some types of content (#33116).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-04 00:43:28 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
6095186e97 Include attachments in news post notifications (#33002).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19528 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-24 03:19:00 +00:00
Toshi MARUYAMA
15e8297d81 cleanup: rubocop: fix Layout/IndentFirstHashElement in test/functional/news_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19222 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-24 05:25:12 +00:00
Go MAEDA
adebf4da1d Remove trailing whitespaces from test (#31506).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18233 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-06 14:53:23 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
4f5a3a156c Enable frozen_string_literal for some files under test directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 15:03:47 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
6765505b2d Add missing fixtures to several tests (#30276).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-01-09 14:26:56 +00:00
Jean-Philippe Lang
015ca36634 Send individual emails for each mail recipient (#26791).
We are creating multipe mails per class notification event, one per
recipient, wrapped in a Mailer::MultiMessage object to send them all at
once.

We keep the existing interface of all class methods intended to be used
by external code the same as they were before, with one exception:

We provide additional recipient addresses in options[:recipients] for
Mailer.security_notification. Since the first-class recipients have to
be users to render individual mails for them, additional recipient
addresses have to be provided with some other channel.

By providing additional recipients in options[:recipients], we can solve
the use-case for address change notifications for users, which probably
is the only real use-case for having to use a plain email address
instead of a User as a notification recipient.

Patch by Holger Just and Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@17583 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:08:52 +00:00
Jean-Philippe Lang
b03e03b770 Global News view should not be allowed without permission (#7068).
git-svn-id: http://svn.redmine.org/redmine/trunk@16721 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-26 19:49:02 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
b834e81d7f Use Rails 5 syntax for functional tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@16585 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-31 17:32:34 +00:00
Jean-Philippe Lang
bb5ccb870c Removes calls to #assert_template and #assigns in functional tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@15715 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-19 20:06:01 +00:00
Jean-Philippe Lang
2e4e610930 Adds our own class for controller tests.
git-svn-id: http://svn.redmine.org/redmine/trunk@15661 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 09:35:49 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
e3618bdbec Add support for multiple email addresses per user (#4244).
git-svn-id: http://svn.redmine.org/redmine/trunk@13886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-17 14:14:12 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2a6692248b Replaced "can't" with "cannot" in error messages.
git-svn-id: http://svn.redmine.org/redmine/trunk@13781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 12:39:48 +00:00
Jean-Philippe Lang
f3e573b5f8 Replaced remaining #assert_tag with #assert_select.
git-svn-id: http://svn.redmine.org/redmine/trunk@13624 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-22 09:38:21 +00:00
Jean-Philippe Lang
46756cbd56 Fixed 500 error when displaying a news with comments in reverse order (#18332).
git-svn-id: http://svn.redmine.org/redmine/trunk@13595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-14 20:53:14 +00:00
Toshi MARUYAMA
0636015826 add missing fixtures to NewsControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@13375 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-09-11 17:19:42 +00:00
Toshi MARUYAMA
98249335d5 use escaped "can't" constant at NewsControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@12803 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-02-04 23:52:12 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00
Toshi MARUYAMA
184ea832d6 Rails4: replace deprecated Relation#first with finder options at NewsControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@12522 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-08 06:26:25 +00:00
Toshi MARUYAMA
4f28ed2fb4 Rails4: replace deprecated Relation#first with finder options at NewsControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@12521 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-08 06:23:43 +00:00
Jean-Philippe Lang
e396a0eebe Copyright for 2013 (#12788).
Patch by Daniel Felix.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2013-01-12 09:29:31 +00:00
Jean-Philippe Lang
4cc4e8bfd3 Functional tests cleanup.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10936 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-12-03 22:23:23 +00:00
Jean-Philippe Lang
265baa1b2c Upgrade to Rails 3.2.8 (#11758).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10275 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-09-02 10:08:51 +00:00
Jean-Philippe Lang
7acd04fb87 Tests should not change settings.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9949 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-07-08 12:23:47 +00:00
Jean-Philippe Lang
ba5a052c8c Copyright update.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9636 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-05-05 12:56:53 +00:00
Jean-Philippe Lang
33cb9c87a9 More functional tests for NewsController.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9173 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-10 13:47:28 +00:00
Jean-Philippe Lang
9634fe054a Adds a test for when updating a news fails.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9054 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-03-02 11:43:33 +00:00
Jean-Philippe Lang
21607751c9 Clean up assertion.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8999 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-02-25 12:35:22 +00:00
Jean-Philippe Lang
24138187eb Allows attachments on news (#1972).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8728 e93f8b46-1217-0410-a6f0-8f06a7374b81
2012-01-29 22:39:06 +00:00
Toshi MARUYAMA
4f6286b86a remove trailing white-spaces from test/functional/news_controller_test.rb.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@6830 e93f8b46-1217-0410-a6f0-8f06a7374b81
2011-08-30 16:03:18 +00:00
Jean-Baptiste Barth
17f86d964f Use absolute paths in test/**/* requires for Ruby 1.9.2 compatibility. #4050
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4509 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-12-12 23:24:34 +00:00
Jean-Philippe Lang
2fab7bd9b1 Adds leading slash to all assert_redirected_to arguments (#6887).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4407 e93f8b46-1217-0410-a6f0-8f06a7374b81
2010-11-14 16:45:32 +00:00