Commit Graph

628 Commits

Author SHA1 Message Date
Go MAEDA
68fce8e97d Fix RuboCop offense Naming/MethodName due to r21269 (#29076).
git-svn-id: http://svn.redmine.org/redmine/trunk@21272 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-08 14:12:05 +00:00
Marius Balteanu
e9b94a19de Adds button to "Create and follow" when adding a subtask from the parent issue. Now the user have the following options:
* Create: redirects the user to the parent task (existing behaviour)
* Create and follow: redirects the user to the newly created subtask (new behaviour)
* Create and add another: redirects the user to new subtask (existing behaviour).

(#29076).

git-svn-id: http://svn.redmine.org/redmine/trunk@21269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-06 09:11:58 +00:00
Marius Balteanu
fe4d0d93da Fixed "Layout/IndentationWidth: Use 2 (not 4) spaces for indentation." introduced by r21141 (#35634).
git-svn-id: http://svn.redmine.org/redmine/trunk@21152 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-10 20:26:23 +00:00
Marius Balteanu
f31a1e2bbb Fixed attachments deletable by user without edit issue permission on tracker (#35634).
git-svn-id: http://svn.redmine.org/redmine/trunk@21142 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:50:11 +00:00
Marius Balteanu
1146831b3d Adds tests for issue attachment edit by user without edit issue permission on tracker (#35634).
git-svn-id: http://svn.redmine.org/redmine/trunk@21141 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:48:47 +00:00
Marius Balteanu
7e2f3352db Fix that updating an issue from context menu to a none value do not set the field to blank (#33521).
Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-05 23:41:01 +00:00
Marius Balteanu
805b36cbfb Remove unused setting 'Blind carbon copy recipients (bcc)' (#30820).
git-svn-id: http://svn.redmine.org/redmine/trunk@21130 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-08-01 17:25:13 +00:00
Marius Balteanu
3ebe6a8b0a When updating an issue, allow adding time entry on an issue that was visible for the previous assignee (#34856).
git-svn-id: http://svn.redmine.org/redmine/trunk@21081 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-26 20:20:41 +00:00
Go MAEDA
a6e09913b7 Link from assignee to group page (#12795).
git-svn-id: http://svn.redmine.org/redmine/trunk@21075 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-20 21:39:17 +00:00
Go MAEDA
7f965286ed Default issue query (#7360).
Patch by Katsuya HIDAKA (the author of https://github.com/hidakatsuya/redmine_default_custom_query), Takenori TAKAKI, Olivier Chabert, and Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21061 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-06 06:01:50 +00:00
Go MAEDA
f30c91341a Rails 6.1: add header=present to csv tests (#29914, #32921).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20887 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:59:31 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
8e3a857802 Restore Copy button to its original location (#34714).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20842 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 04:21:14 +00:00
Go MAEDA
319e8a2620 Show project tree instead of subprojects in the project selector when you create a new issue (#34798).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 01:42:00 +00:00
Go MAEDA
44ea826a21 "Copy link" feature for issue and issue journal (#34703).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-18 03:58:29 +00:00
Go MAEDA
c54349cc0b Do not display in issue edit page spent time custom fields not visible by the user (#33550).
Patch by  Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20801 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-15 23:32:52 +00:00
Go MAEDA
6e93adbec3 Move some action links for issues and journals to the dropdown menu (#34714).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20765 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-07 06:46:41 +00:00
Go MAEDA
097e75987b Fix project selector on global new issue page not showing all visible projects (#33419).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20733 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-02-01 04:22:22 +00:00
Go MAEDA
091dd36acc Show a warning message for watchers who cannot view the object (#33329).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20725 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-24 05:38:22 +00:00
Go MAEDA
6bca099013 Some fixes for r20321:
* Include only visible issues in subtasks stats
* Get subtasks using only one query
* Show all subtasks count as badge
* Add tests

Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20718 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-18 07:11:47 +00:00
Go MAEDA
354d30df31 Add class 'error' to custom fields with validation errors (#32764, #34580).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20710 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-11 12:26:44 +00:00
Go MAEDA
3f3514d8b1 Show only valid projects on issue form when the issue is a subtask (#33419).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20701 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-01-01 00:59:07 +00:00
Go MAEDA
93d98bfff8 Make sure that "is not" operator for Subproject filter does not exclude closed subprojects (#34375).
The issue has been fixed in r20693 along with #34297.


git-svn-id: http://svn.redmine.org/redmine/trunk@20694 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-28 00:52:11 +00:00
Go MAEDA
36b5c32048 Subprojects issues are not displayed on main project when all subprojects are closed (#34297).
Patch by Yuichi HARADA and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20693 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-27 06:46:37 +00:00
Go MAEDA
843f13f7e2 Revert r19810 (#10535).
git-svn-id: http://svn.redmine.org/redmine/trunk@20685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-22 11:52:16 +00:00
Toshi MARUYAMA
7955452b6a use 'assert_not' instead of 'assert !' at IssuesControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@20680 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-19 17:33:19 +00:00
Toshi MARUYAMA
4148f9c743 shorten long line of IssuesControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@20674 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-19 17:32:34 +00:00
Go MAEDA
afed0f3748 Move the "Private" badge next to the "Open/Closed" badge (#33832).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20334 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-11 07:39:59 +00:00
Toshi MARUYAMA
ffaa46fea1 use with_settings at IssuesControllerTest#test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
git-svn-id: http://svn.redmine.org/redmine/trunk@20216 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-27 15:19:28 +00:00
Toshi MARUYAMA
9bb9287970 use with_settings at IssuesControllerTest#test_index_with_project_and_subprojects
git-svn-id: http://svn.redmine.org/redmine/trunk@20204 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-26 13:36:20 +00:00
Toshi MARUYAMA
4fc83183e1 use with_settings at IssuesControllerTest#test_index_with_project
git-svn-id: http://svn.redmine.org/redmine/trunk@20188 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-24 14:40:41 +00:00
Toshi MARUYAMA
5280861cf3 use with_settings at IssuesControllerTest#test_show_should_not_disclose_relations_to_invisible_issues
git-svn-id: http://svn.redmine.org/redmine/trunk@20167 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-22 14:18:44 +00:00
Toshi MARUYAMA
2c9f822be9 add functional test "bulk copy should show follow button when project is selected"
git-svn-id: http://svn.redmine.org/redmine/trunk@20078 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-24 16:07:28 +00:00
Toshi MARUYAMA
4fdac0655a add functional test "bulk_edit should hide follow button when project is not changed"
git-svn-id: http://svn.redmine.org/redmine/trunk@20065 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-21 13:04:33 +00:00
Toshi MARUYAMA
e5d7ece6f2 fix source indent of IssuesControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@20052 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-21 13:02:51 +00:00
Toshi MARUYAMA
8555cfbcb0 add functional test "bulk_edit should show follow button when project is selected"
git-svn-id: http://svn.redmine.org/redmine/trunk@20049 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-17 15:49:30 +00:00
Toshi MARUYAMA
da22acd8b7 assert explicitly to hide 'follow' button at IssuesControllerTest#test_get_bulk_edit
git-svn-id: http://svn.redmine.org/redmine/trunk@20028 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-12 12:58:37 +00:00
Go MAEDA
a7b9fa9996 Fix that Issues API bypasses add_issue_notes permission (#33689).
Patch by Junya Tomono and Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19975 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-12 02:28:46 +00:00
Toshi MARUYAMA
3e0c726a7d add assert_select of button at IssuesControllerTest#test_get_bulk_edit
git-svn-id: http://svn.redmine.org/redmine/trunk@19974 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:58:01 +00:00
Toshi MARUYAMA
4cc150bcfa add assert_select of form to IssuesControllerTest#test_get_bulk_copy_without_add_issues_permission_should_not_propose_current_project_as_target
git-svn-id: http://svn.redmine.org/redmine/trunk@19958 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-07 12:44:07 +00:00
Toshi MARUYAMA
8d469912fa add assert_select of form to IssuesControllerTest#test_get_bulk_copy
git-svn-id: http://svn.redmine.org/redmine/trunk@19934 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-21 13:41:34 +00:00
Toshi MARUYAMA
fbbfde9dc7 fix source indent of IssuesControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@19929 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-21 13:40:52 +00:00
Toshi MARUYAMA
2982737466 add attachments existence assertion to IssuesControllerTest#test_get_bulk_copy
git-svn-id: http://svn.redmine.org/redmine/trunk@19920 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-19 14:06:25 +00:00
Toshi MARUYAMA
66bdcd08d9 shorten long line of IssuesControllerTest
git-svn-id: http://svn.redmine.org/redmine/trunk@19918 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-19 14:06:09 +00:00
Toshi MARUYAMA
1de92538c5 add surrounding '+' operator spaces to IssuesControllerTest#"bulk copy should allow copying the subtasks"
git-svn-id: http://svn.redmine.org/redmine/trunk@19883 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 01:21:50 +00:00
Toshi MARUYAMA
ff5b3485ba add surrounding '+' operator spaces to IssuesControllerTest#test_bulk_copy_should_not_copy_selected_subtasks_twice
git-svn-id: http://svn.redmine.org/redmine/trunk@19882 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 01:21:42 +00:00
Go MAEDA
58938dd823 URLs in atom feeds don't take into account Setting.protocol and Setting.hostname (#10535).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19810 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-06-04 14:23:03 +00:00
Go MAEDA
6e232ad13e Show open/closed badge on issue page (#33254).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19719 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-23 10:13:10 +00:00
Go MAEDA
a9a3d71e63 Test for r19702 (#33273).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19703 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-15 14:15:24 +00:00
Go MAEDA
6e781f6479 Fix that "Successful deletion" notice is not displayed after deleting some types of content (#33116).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-04 00:43:28 +00:00