Commit Graph

289 Commits

Author SHA1 Message Date
Go MAEDA
a253cd1636 Fix: updated_by_id in Journal points to a deleted user instead of an anonymous user (#41572).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23169 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-10-29 01:02:04 +00:00
Go MAEDA
b7120cfe3a Remove unnecessary rubocop:disable directive for Style/EmptyLiteral (#39887).
RuboCop’s Style/EmptyLiteral false positive for `Hash.new([])` was resolved in RuboCop 1.66.1. This commit updates the RuboCop version to 1.66.1 and removes the now-unnecessary `rubocop:disable` directives.


git-svn-id: https://svn.redmine.org/redmine/trunk@23013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-05 00:49:54 +00:00
Go MAEDA
d24d11a682 Fix RuboCop offense Style/StringChars (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@23009 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 06:05:39 +00:00
Go MAEDA
eee5d73ee1 Revert r23002 (#39887).
The change caused a test failure:

```
Failure:
UserTest#test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array [test/unit/user_test.rb:1048]:
Expected: []
  Actual: nil
```


git-svn-id: https://svn.redmine.org/redmine/trunk@23006 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 01:33:00 +00:00
Go MAEDA
2190a4b417 Disable RuboCop Lint/InterpolationCheck for USER_FORMATS in app/models/user.rb (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@23005 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 01:02:38 +00:00
Go MAEDA
987a36281a Fix RuboCop offense Style/EmptyLiteral (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@23002 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 00:42:33 +00:00
Go MAEDA
9cc3542fa1 Introduce active? method to Group via Principal model (#27510).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-21 08:05:59 +00:00
Go MAEDA
93645a279e Use anonymous block forwarding introduced in Ruby 3.1 (#38585).
git-svn-id: https://svn.redmine.org/redmine/trunk@22973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-21 00:46:15 +00:00
Go MAEDA
0247ebb394 Set default age parameter for User.prune method to 30 days (#41023).
git-svn-id: https://svn.redmine.org/redmine/trunk@22938 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-19 08:26:13 +00:00
Go MAEDA
719b0ce615 Reject passwords that are the same as login, first name, last name, or email (#37279).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22888 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-21 05:32:46 +00:00
Go MAEDA
ddde0ff47d Fix RuboCop offense Rails/ActiveRecordCallbacksOrder (#39889).
git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-06-17 03:11:08 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
c517664985 Reverts r22438 (#35189).
git-svn-id: https://svn.redmine.org/redmine/trunk@22616 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 01:05:38 +00:00
Marius Balteanu
fd3843d821 Replace request_store with ActiveSupport::CurrentAttributes (#39110).
Patch by Takashi Kato.

git-svn-id: https://svn.redmine.org/redmine/trunk@22473 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-21 06:45:54 +00:00
Go MAEDA
384cde0a46 New email notification option "For any event on my bookmarked projects" (#35189).
Patch by Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22438 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-16 08:32:41 +00:00
Marius Balteanu
f0f1d49b56 Remove @rss_*@ deprecated methods (#36806).
git-svn-id: https://svn.redmine.org/redmine/trunk@22416 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-06 20:36:48 +00:00
Go MAEDA
937124443c Raise the maximum length of the last name to 255 characters (#37679).
Patch by Anthony Mallet.


git-svn-id: https://svn.redmine.org/redmine/trunk@22284 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-08-27 08:59:33 +00:00
Go MAEDA
59775bde9f Fix RuboCop offense Lint/UselessRescue (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22035 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 14:03:28 +00:00
Go MAEDA
3942177f49 Fix RuboCop offense Performance/BlockGivenWithExplicitBlock (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22027 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-11 13:20:52 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Marius Balteanu
883fcb89ee Include roles of built-in "Non member users" and "Anonymous users" members when user is not a member of the project. This fixes #34029.
git-svn-id: https://svn.redmine.org/redmine/trunk@21502 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-27 21:29:05 +00:00
Go MAEDA
750c5e89fb Increase email address length limit from 60 to 254 (#36825).
Contributed by Brice Beaumesnil.


git-svn-id: https://svn.redmine.org/redmine/trunk@21497 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-23 15:26:59 +00:00
Go MAEDA
2e86acfa87 Add tasks to prune registered users after a certain number of days (#30998).
Patch by Yuichi HARADA and Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@21490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-22 04:02:39 +00:00
Marius Balteanu
f286a6044b Deprecate and rename rss_* methods to atom_* methods (#15118).
Patch by Mischa The Evil and Marius BĂLTEANU


git-svn-id: http://svn.redmine.org/redmine/trunk@21467 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-19 09:56:46 +00:00
Marius Balteanu
eb868ad932 Add "required for administrators" option to Two-factor authentication settings that behaves like optional, but will require all users with administration rights to set up two-factor authentication at their next login (#35439).
git-svn-id: http://svn.redmine.org/redmine/trunk@21395 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-01 20:17:27 +00:00
Marius Balteanu
972edf78cc Improve readability of @must_activate_twofa?@ function (#31920).
git-svn-id: http://svn.redmine.org/redmine/trunk@21389 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-29 09:43:46 +00:00
Go MAEDA
8bb06c04ba Update session token only once per minute (#29041).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@21376 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-22 04:04:05 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
9955844da1 Drop OpenID support (#35755).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@21312 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-14 00:09:53 +00:00
Marius Balteanu
7125fd70ce Split multiple classes and modules that existed in the same file (#29914, #32938).
Patch by Mizuki ISHIKAWA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21252 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-20 22:18:49 +00:00
Marius Balteanu
55ce8de0ae Use ids instead of pluck(:id) (#32977).
git-svn-id: http://svn.redmine.org/redmine/trunk@21208 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-09-06 18:33:14 +00:00
Marius Balteanu
4378b7e1b4 Remove references to deleted user from "user"-Format CustomFields when destroying an user (#32977).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21207 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-09-06 18:30:04 +00:00
Go MAEDA
8f0d358533 User sessions not reset after 2FA activation (#35417).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@21069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-15 01:44:05 +00:00
Marius Balteanu
1b0bf28803 When 2FA is set to optional, allow to require 2FA only for certain user groups (#31920).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21060 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-07-04 13:06:47 +00:00
Go MAEDA
ec3527102d Remove deprecated WikiContent::Version (#35031).
git-svn-id: http://svn.redmine.org/redmine/trunk@21002 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-05-15 05:51:14 +00:00
Go MAEDA
74a6ff0230 Replace pluck().first with pick() (#32909).
Patch by Pavel Rosický and Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20907 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-03 01:34:45 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
1dcebf8ce0 Changes User.try_to_login to catch and log AuthSourceExceptions, and introduces User.try_to_login! replicating the original behavior (#34071).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@20547 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-12-02 13:56:15 +00:00
Toshi MARUYAMA
b2e81eecf2 use "do end" instead of {} at ActiveRecord scope lambda of app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20318 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-09 13:25:19 +00:00
Toshi MARUYAMA
691964695f fix source indent of app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20037 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-17 15:47:52 +00:00
Go MAEDA
be7f5e21fa Adds a setting to disable/enable/require 2fa auth (#1237).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19989 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-29 06:37:09 +00:00
Go MAEDA
560bca344a Adds two factor authentication support (#1237).
Patch by Felix Schäfer.


git-svn-id: http://svn.redmine.org/redmine/trunk@19988 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-29 06:21:50 +00:00
Toshi MARUYAMA
de3fcfe63e use "do end" instead of {} at app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19973 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-08-09 15:57:53 +00:00
Toshi MARUYAMA
3d6d4c5a12 remove spaces inside {} of app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19922 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-21 13:39:55 +00:00
Toshi MARUYAMA
4ef5949574 fix source indent of app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19903 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-15 16:36:39 +00:00
Toshi MARUYAMA
8402e08034 remove spaces inside {} of app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 01:21:19 +00:00
Toshi MARUYAMA
dcf3a07892 add empty lines after guard clause to app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19871 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-09 15:18:16 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
01f523f165 Rails 6: Fix deprecation warning "Class level methods will no longer inherit scoping" (#32911).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@19490 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-02-03 15:12:21 +00:00
Go MAEDA
d48769f152 Enable users to receive email notifications about high issues (only) (#32628).
Patch by Jan Schulz-Hofen.


git-svn-id: http://svn.redmine.org/redmine/trunk@19449 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-21 04:23:26 +00:00