Commit Graph

90 Commits

Author SHA1 Message Date
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975).
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Go MAEDA
c8640d7ffc Fix RuboCop offense Style/HashEachMethods (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 08:13:48 +00:00
Marius Balteanu
7b911245d3 Updates Rails to 7.1.2 (#36320).
Patch by Takashi Kato.

git-svn-id: https://svn.redmine.org/redmine/trunk@22488 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-11-27 20:58:55 +00:00
Go MAEDA
945a82b5c0 <=> operator should return nil when invoked with an incomparable object (#38772).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 14:42:54 +00:00
Go MAEDA
21eef7e65c Ensure that the base permission is set for Role#permissions_tracker? and related (#38070).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22063 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-19 11:54:03 +00:00
Go MAEDA
0b6f4c6811 Ruby 2.7: Fix RuboCop offense Performance/MapCompact (#38134).
git-svn-id: https://svn.redmine.org/redmine/trunk@22055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-17 01:38:27 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
38f7a06405 Add default spent time activity per role (#29286).
Patch by Marius BALTEANU and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21763 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-08-09 02:50:11 +00:00
Marius Balteanu
4cb518049f Add habtm relation between roles and queries_roles (#36416).
git-svn-id: http://svn.redmine.org/redmine/trunk@21444 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-28 21:16:08 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
2a564a1376 DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. (#29914, #32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20880 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-01 14:32:23 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
e8785b7ac2 use "do end" instead of {} at ActiveRecord scope lambda of app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20345 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-12 12:31:43 +00:00
Toshi MARUYAMA
3a0b7d6a2f remove spaces inside {} of app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20324 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-10 11:09:54 +00:00
Toshi MARUYAMA
3c10f4bece use "do end" instead of {} at app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20298 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-08 13:01:55 +00:00
Toshi MARUYAMA
3758b91e54 add empty line after guard clause to app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20260 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-05 13:42:00 +00:00
Toshi MARUYAMA
fb251df344 fix source indent of app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20089 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-26 15:02:50 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Go MAEDA
47a71c8011 Reverts r19478 (#32897).
git-svn-id: http://svn.redmine.org/redmine/trunk@19479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-30 05:27:52 +00:00
Go MAEDA
10bb12e09f Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19478 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-01-28 09:49:14 +00:00
Toshi MARUYAMA
ea859aedca cleanup: rubocop: fix Layout/AlignArguments in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 06:26:33 +00:00
Toshi MARUYAMA
40f1b0f3f3 code layout clean up app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18830 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:53:48 +00:00
Toshi MARUYAMA
e079d49dd7 code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:53:37 +00:00
Toshi MARUYAMA
9cf1621083 code cleanup: rubocop: fix Style/WhenThen in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18724 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 16:40:43 +00:00
Toshi MARUYAMA
c32277a42b fix Role#find_or_create_system_role is not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18693 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-16 14:36:20 +00:00
Jean-Philippe Lang
3ddab944d5 Increase maximum size for role name (#27625).
Patch by Aleksandar Pavic.

git-svn-id: http://svn.redmine.org/redmine/trunk@18296 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-20 13:59:16 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
e159928e6b Use find_by instead of where.first to remove unnecessary sorting (#26747).
Patch by  Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 16:03:26 +00:00
Jean-Philippe Lang
c1e7146498 Removes deprecated methods.
git-svn-id: http://svn.redmine.org/redmine/trunk@16871 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 16:18:27 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
44c748f968 Use regular instance methods instead of association extensions.
Rails 5.1 seems to mess things up in this particular case (role.workflow_rules.copy calls the extension declare in Tracker model).

git-svn-id: http://svn.redmine.org/redmine/trunk@16597 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-03 08:04:13 +00:00
Toshi MARUYAMA
74b09be185 remove trailing white space from app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@16074 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-14 10:53:15 +00:00
Jean-Philippe Lang
3e86a2ab52 Use .unscoped when querying and creating builtin objects (#24156).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@16049 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-12-03 08:57:01 +00:00
Jean-Philippe Lang
d8df8c8bcb Role#copy_from should copy managed roles.
git-svn-id: http://svn.redmine.org/redmine/trunk@15913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-20 17:00:04 +00:00
Jean-Philippe Lang
a2b17dae6e Fixed that r15668 prevents from setting managed roles.
git-svn-id: http://svn.redmine.org/redmine/trunk@15912 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-20 16:57:15 +00:00
Jean-Philippe Lang
adde498b33 Use safe_attributes.
git-svn-id: http://svn.redmine.org/redmine/trunk@15668 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-16 09:30:09 +00:00
Jean-Philippe Lang
83777f727a Assignable users should not include users that cannot view the tracker (#23172).
git-svn-id: http://svn.redmine.org/redmine/trunk@15586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-28 20:31:08 +00:00
Jean-Philippe Lang
79df68e17f Limit trackers for new issue to certain roles (#7839).
git-svn-id: http://svn.redmine.org/redmine/trunk@15464 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-06-05 10:06:17 +00:00
Jean-Philippe Lang
64afa24a7f Replaces acts_as_list with an implementation that handles #position= (#12909).
Objects are reordered using the regular attribute writer #position= and AR callbacks.

git-svn-id: http://svn.redmine.org/redmine/trunk@15335 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-17 06:57:20 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
ed9f00178c Ability to limit member management to certain roles (#19707).
git-svn-id: http://svn.redmine.org/redmine/trunk@14293 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-31 07:16:23 +00:00
Jean-Philippe Lang
6659aad3ef Adds a role setting that viewing all or own time entries (#8929).
git-svn-id: http://svn.redmine.org/redmine/trunk@14275 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-05-30 07:40:57 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
0eda7765fa Skip validation if attribute did not change.
git-svn-id: http://svn.redmine.org/redmine/trunk@13851 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-07 22:51:45 +00:00
Jean-Philippe Lang
2a6692248b Replaced "can't" with "cannot" in error messages.
git-svn-id: http://svn.redmine.org/redmine/trunk@13781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-21 12:39:48 +00:00
Jean-Philippe Lang
453803c68f Don't consider roles without issue add/edit permissions for determining fields permissions (#15988).
git-svn-id: http://svn.redmine.org/redmine/trunk@13747 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-13 14:31:58 +00:00