Commit Graph

248 Commits

Author SHA1 Message Date
Go MAEDA
fdd90bab2b Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770).
git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-25 08:44:33 +00:00
Go MAEDA
b3d1deeece Fix RuboCop offense Layout/SpaceInsideParens, one of the offenses enabled in rubocop-rails-omakase (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22954 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-12 08:45:54 +00:00
Marius Balteanu
c1eff66f68 Truncate git authors to 255 characters (#40948).
The committer column in the database allows max 255 characters. With longer authors, this would result in a schema violation. By manually truncating the author field, we can avoid this.

Patch by Holger Just (@hjust). 



git-svn-id: https://svn.redmine.org/redmine/trunk@22910 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-07-08 20:35:16 +00:00
Go MAEDA
b42d7984b1 Fix RuboCop offense Style/SuperArguments (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22842 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-05-23 11:25:16 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
fa9b911f0a Fix RuboCop offense Lint/RedundantSafeNavigation (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@22253 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-07 13:04:35 +00:00
Go MAEDA
0b6f4c6811 Ruby 2.7: Fix RuboCop offense Performance/MapCompact (#38134).
git-svn-id: https://svn.redmine.org/redmine/trunk@22055 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-17 01:38:27 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
5817752289 Remove unnecessary disabling of RuboCop Rails/Pluck (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@21930 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-29 07:42:03 +00:00
Go MAEDA
ee1476f802 Fix RuboCop offense Rails/Pluck (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@21928 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-28 07:50:11 +00:00
Go MAEDA
47b17044d2 Fix RuboCop offense Style/RedundantStringEscape (#36919).
git-svn-id: https://svn.redmine.org/redmine/trunk@21920 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-26 13:14:08 +00:00
Go MAEDA
f92477a423 Cleanup Repository::Git#clear_extra_info_of_changesets (#37614).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21845 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 05:08:32 +00:00
Go MAEDA
a1126aebd4 Use the safe navigation operator instead of checking if an object is nil (#37614).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21844 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 05:07:09 +00:00
Go MAEDA
fa3a42d1de Fix RuboCop offense Style/GuardClause (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21843 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 05:00:29 +00:00
Go MAEDA
f17e8507c5 Fix RuboCop offense Style/IfUnlessModifier (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21842 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 04:58:53 +00:00
Go MAEDA
b7e477ea7f Fix RuboCop offense Style/SymbolProc (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21841 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 04:57:21 +00:00
Go MAEDA
02f17b6d2b Fix RuboCop offense Rails/Blank (#37614).
git-svn-id: https://svn.redmine.org/redmine/trunk@21840 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-25 04:56:16 +00:00
Go MAEDA
12c7061416 Rename Repository#supports_all_revisions? to Repository#supports_history? (#37657).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21816 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-15 13:14:05 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
79fa07b93a fix source indent of app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20493 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-26 14:45:41 +00:00
Toshi MARUYAMA
e96a74b6e1 add empty line after guard clause to app/models/repository/bazaar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20215 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-27 15:19:20 +00:00
Toshi MARUYAMA
8b49aeeb32 add empty line after guard clause to app/models/repository/mercurial.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20043 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-17 15:48:41 +00:00
Toshi MARUYAMA
0e6e6a3169 remove spaces inside {} of app/models/repository/mercurial.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20024 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-12 12:58:06 +00:00
Toshi MARUYAMA
2ba01fba7d fix source indent of app/models/repository/git.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20019 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-09-12 12:57:26 +00:00
Toshi MARUYAMA
b7673a7a37 remove spaces inside {} of app/models/repository/git.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19923 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-21 13:40:03 +00:00
Toshi MARUYAMA
c7213ab4d6 use a normal unless-statement over a modifier clause in a multiline statement at app/models/repository/bazaar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19875 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-09 15:18:47 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
5600c3cf5a cleanup: rubocop: fix Style/MultilineIfModifier in app/models/repository/subversion.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19215 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-23 15:11:40 +00:00
Toshi MARUYAMA
cff0fb1855 cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/models/repository/subversion.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19214 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-23 15:11:28 +00:00
Toshi MARUYAMA
0b487967da cleanup: rubocop: fix Layout/SpaceAfterComma in app/models/repository/git.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19208 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-23 15:10:25 +00:00
Toshi MARUYAMA
34aa758c1d cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/models/repository/git.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19174 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 14:55:26 +00:00
Toshi MARUYAMA
7d03976e6a cleanup: rubocop: fix Layout/SpaceInsideParens in app/models/repository/mercurial.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18955 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 12:34:09 +00:00
Toshi MARUYAMA
08918ce867 cleanup: rubocop: fix Style/MethodCallWithoutArgsParentheses in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18954 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 12:04:03 +00:00
Toshi MARUYAMA
89ba5ae630 cleanup: rubocop: fix Layout/AlignArguments in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18943 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 02:09:17 +00:00
Toshi MARUYAMA
4c9bef2ace code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/repository/bazaar.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18512 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 05:13:46 +00:00
Toshi MARUYAMA
fb221e8069 code cleanup: rubocop: fix Layout/SpaceInsideRangeLiteral in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18507 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-24 02:34:43 +00:00
Toshi MARUYAMA
fd51a4fe58 code cleanup: rubocop: fix Style/CommentedKeyword in app/models/repository/cvs.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18492 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-20 17:54:54 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
b0e17e8199 Don't rescue Exception class (#31387).
Patch by Go MAEDA and Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 06:50:25 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
bd5977d97e Support frozen_string_literal in app/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 13:36:03 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
e159928e6b Use find_by instead of where.first to remove unnecessary sorting (#26747).
Patch by  Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 16:03:26 +00:00
Jean-Philippe Lang
0910b2bdbe Drop Darcs support (#26391).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-25 17:32:53 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Toshi MARUYAMA
6139e0033a spelling fixes (#25495)
git-svn-id: http://svn.redmine.org/redmine/trunk@16445 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-02 03:34:44 +00:00
Jean-Philippe Lang
c7f03c00a9 Use exists? instead of count (#24839).
Patch by Vincent Robert and Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@16211 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-16 18:12:49 +00:00
Jean-Philippe Lang
46044b48a3 Adds accessors for report_last_commit.
git-svn-id: http://svn.redmine.org/redmine/trunk@15885 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-10-04 16:40:24 +00:00