Commit Graph

81 Commits

Author SHA1 Message Date
Go MAEDA
2fe36c4128 Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887).
Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant.


git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-09-01 00:38:01 +00:00
Go MAEDA
c2eb20e434 Fix RuboCop offense Style/ClassEqualityComparison (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22978 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-21 13:45:13 +00:00
Go MAEDA
9cc3542fa1 Introduce active? method to Group via Principal model (#27510).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22976 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-21 08:05:59 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
b61ee85e4d Principal.not_member_of scope does not accept ActiveRecord::Relation (#28243).
git-svn-id: https://svn.redmine.org/redmine/trunk@22697 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-08 00:57:07 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975).
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Go MAEDA
fa85583c96 Optimize users visibility check (#39857).
Patch by Pavel Rosický.


git-svn-id: https://svn.redmine.org/redmine/trunk@22567 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-27 08:07:22 +00:00
Go MAEDA
945a82b5c0 <=> operator should return nil when invoked with an incomparable object (#38772).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-06-29 14:42:54 +00:00
Go MAEDA
57e702a69b Fix RuboCop offense Performance/StringInclude (#37247).
git-svn-id: https://svn.redmine.org/redmine/trunk@22097 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-06 13:50:33 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
a914cf4c40 Switch to zeitwerk autoloader (#29914, #32938).
Patch by Takashi Kato.

git-svn-id: http://svn.redmine.org/redmine/trunk@21287 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-17 20:55:08 +00:00
Marius Balteanu
6cbf1f2015 Explicitly specify escape character using an ESCAPE on SQLite (#35073).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@21240 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-09 06:35:47 +00:00
Marius Balteanu
05e9d7883b Use sanitize_sql_like in like scopes (#35073).
Patch Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21231 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:44:39 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
046c0c4729 remove spaces inside {} of app/models/principal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20423 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-18 16:16:15 +00:00
Toshi MARUYAMA
3e6622cd43 use "do end" instead of {} at ActiveRecord scope lambda of app/models/principal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20328 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-10 11:10:24 +00:00
Toshi MARUYAMA
06b53fd60f use "do end" instead of {} at app/models/principal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20288 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-07 12:31:10 +00:00
Go MAEDA
b46953247d Replace Hash#merge! with Hash#[]= (#34160).
git-svn-id: http://svn.redmine.org/redmine/trunk@20175 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-24 05:33:23 +00:00
Go MAEDA
ee46c3570e Use scope assignable_watchers (#4511).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@19726 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-04-25 08:01:59 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
bc0d654802 cleanup: rubocop: fix Layout/BlockAlignment in app/models/principal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19003 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-09 09:18:51 +00:00
Toshi MARUYAMA
f554624614 cleanup: rubocop: fix Layout/AlignArguments in app/models/principal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18927 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-06 12:04:10 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
bd5977d97e Support frozen_string_literal in app/**/*.rb (#26561).
Contributed by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17987 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 13:36:03 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
e159928e6b Use find_by instead of where.first to remove unnecessary sorting (#26747).
Patch by  Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17586 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 16:03:26 +00:00
Go MAEDA
b4d3715dc0 Include locked members in filters (#15201).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@17371 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-06-09 08:07:08 +00:00
Go MAEDA
b4a703ce4e Support for lastnames with spaces in user autocompleters (#28154).
Patch by Gregor Schmidt.


git-svn-id: http://svn.redmine.org/redmine/trunk@17259 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-04-07 06:39:57 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
2f77bfde91 Option to set a default assignee on each project (#482).
Patch by Felix Schäfer.

git-svn-id: http://svn.redmine.org/redmine/trunk@16525 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-08 08:02:06 +00:00
Jean-Philippe Lang
f604fe9460 SQL Cleanup.
git-svn-id: http://svn.redmine.org/redmine/trunk@16479 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-04-04 17:52:24 +00:00
Jean-Philippe Lang
3deb70d4aa Don't preload projects and roles on Principal#memberships association (#23519).
Patch by Ondřej Ezr.

git-svn-id: http://svn.redmine.org/redmine/trunk@16153 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-07 11:40:09 +00:00
Jean-Philippe Lang
f8df935dca Speeds up rendering of the project list for users who belong to hundreds of projects.
git-svn-id: http://svn.redmine.org/redmine/trunk@16123 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-03 18:28:45 +00:00
Jean-Philippe Lang
97a647c1e5 Validate status of users and groups.
git-svn-id: http://svn.redmine.org/redmine/trunk@15320 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-04-11 17:51:16 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
151892c313 Fixed that Project.uniq.visible errors under certain conditions (#21182).
Patch by Redmine CRM.

git-svn-id: http://svn.redmine.org/redmine/trunk@14857 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-11-09 18:01:04 +00:00
Jean-Philippe Lang
139808b58d Find user by login then by email.
git-svn-id: http://svn.redmine.org/redmine/trunk@14506 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-08-15 09:28:34 +00:00
Jean-Philippe Lang
eac2974e71 Moved implementation to Principal.
git-svn-id: http://svn.redmine.org/redmine/trunk@14500 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-08-15 06:57:55 +00:00
Toshi MARUYAMA
918a412fd4 use String#casecmp for case insensitive comparison (#20369)
Contributed by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@14484 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-08-12 12:54:06 +00:00
Toshi MARUYAMA
f8971eb567 remove trailing white spaces from app/models/principal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@14322 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-06-17 11:38:48 +00:00
Jean-Philippe Lang
e3618bdbec Add support for multiple email addresses per user (#4244).
git-svn-id: http://svn.redmine.org/redmine/trunk@13886 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-17 14:14:12 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
bdd3ccf8e5 Adds a role setting for controlling visibility of users: all or members of visible projects (#11724).
git-svn-id: http://svn.redmine.org/redmine/trunk@13584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-11-11 13:08:52 +00:00
Jean-Philippe Lang
c2e73160da Adds a single controller for users and groups memberships and support for adding multiple projects at once (#11702).
git-svn-id: http://svn.redmine.org/redmine/trunk@13498 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-23 21:46:40 +00:00
Jean-Philippe Lang
2d1866d966 Merged rails-4.1 branch (#14534).
git-svn-id: http://svn.redmine.org/redmine/trunk@13482 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-10-22 17:37:16 +00:00
Jean-Philippe Lang
7e7ac5340a Adds buit-in groups to give specific permissions to anonymous and non members users per project (#17976).
git-svn-id: http://svn.redmine.org/redmine/trunk@13417 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-09-28 14:51:08 +00:00
Jean-Baptiste Barth
1914d1a159 Improve performance of Principal.member_of scope
The 'join' turns to be slow for large numbers of members (>20k). Using a
sub-query like in Principal.not_member_of is more efficient and performance
is the same for smaller values.


git-svn-id: http://svn.redmine.org/redmine/trunk@13139 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-05-19 21:17:55 +00:00
Toshi MARUYAMA
35cc911192 update copyright year (#15977)
Contributed by Daniel Felix.

git-svn-id: http://svn.redmine.org/redmine/trunk@12736 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-01-29 22:45:39 +00:00