Commit Graph

205 Commits

Author SHA1 Message Date
Go MAEDA
c069ea3a24 Use Array#intersect? introduced in Ruby 3.1 (#38585).
git-svn-id: https://svn.redmine.org/redmine/trunk@22972 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-08-20 23:40:58 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Go MAEDA
380444f085 Fix RuboCop offense Performance/StringIdentifierArgument (#39888).
git-svn-id: https://svn.redmine.org/redmine/trunk@22535 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 09:23:05 +00:00
Go MAEDA
d9ef2d191c Fix RuboCop offense Lint/SymbolConversion (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22531 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 07:16:35 +00:00
Go MAEDA
cb617673b3 Cleanup debug code in app/models/mail_handler.rb (#39184).
Patch by Holger Just.


git-svn-id: https://svn.redmine.org/redmine/trunk@22339 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-10-12 22:42:55 +00:00
Go MAEDA
421dc8320f Receive e-mail replies to news and news comments (#38274).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22160 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-26 05:35:50 +00:00
Go MAEDA
260ba2e04a Add LockedTopic exception to MailHandler (#38273).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22159 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-26 05:20:29 +00:00
Go MAEDA
79f0c64e29 Add MissingContainer exception to MailHandler (#38273).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22158 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-26 05:11:26 +00:00
Go MAEDA
32d2b1c42f Fix RuboCop offense Style/InverseMethods: Use present? instead of inverting blank? (#37248).
git-svn-id: https://svn.redmine.org/redmine/trunk@22152 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-03-25 01:32:23 +00:00
Go MAEDA
96a718547d Try importing journal replies as issue reply where applicable (#38263).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22119 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-27 09:43:37 +00:00
Go MAEDA
0f32df11d5 Update Mail gem to 2.8 (#37993).
Patch by Pavel Rosický.


git-svn-id: https://svn.redmine.org/redmine/trunk@22094 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-05 05:35:56 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Marius Balteanu
9c4df39c7d Setting @--no-permission-check@ in the mail receiver should not allow creating issues in closed and archived projects (#37187).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21641 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-06-16 21:32:02 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Marius Balteanu
715ffcda43 Append two spaces to lines when importing an email on CommonMark with hardbreaks disabled (#32424).
Patch by Jens Krämer.

git-svn-id: http://svn.redmine.org/redmine/trunk@21228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-10-03 19:20:04 +00:00
Go MAEDA
cbd5f2ce8c Mail handler bypasses add_issue_notes permission (#35045).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@20970 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-25 13:02:13 +00:00
Go MAEDA
ccd00df71c MailHandler raises NameError exception when generating error message (#35100).
Patch by Dmitry Makurin and Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@20959 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-22 03:07:42 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Go MAEDA
2cbf5bb29e Allow newlines and quote characters within mail body delimiters (#34794).
Patch by Holger Just.


git-svn-id: http://svn.redmine.org/redmine/trunk@20767 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-09 08:28:01 +00:00
Toshi MARUYAMA
40be0ae5e0 add empty line after guard clause to app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20266 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-05 13:42:47 +00:00
Toshi MARUYAMA
c4a95d5aeb add space after comma to app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20115 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-03 15:36:51 +00:00
Toshi MARUYAMA
c308a7766e remove spaces inside {} of app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20112 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-03 15:36:28 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
7bcb299a3c cleanup: rubocop: fix Style/MultilineTernaryOperator in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18960 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 14:53:11 +00:00
Toshi MARUYAMA
f2b274476a code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18782 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:34:05 +00:00
Toshi MARUYAMA
69fb5a6a80 fix MailHandler#assign_string_attribute_with_limit is not private
git-svn-id: http://svn.redmine.org/redmine/trunk@18697 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-17 04:15:16 +00:00
Toshi MARUYAMA
70965412a6 code cleanup: rubocop: fix Layout/SpaceAfterSemicolon in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18657 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-14 14:51:48 +00:00
Toshi MARUYAMA
612221d36a svn propdel svn:executable app/models/mail_handler.rb
It was added by r16609 accidentally.



git-svn-id: http://svn.redmine.org/redmine/trunk@18539 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-26 02:38:50 +00:00
Go MAEDA
75df6ead3b Log info messages when MailHandler ignored a reply to a nonexistent issue, journal, or message (#31946).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18480 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-09-19 09:38:39 +00:00
Go MAEDA
fe0a89d7d1 CodeCleanup: RuboCop: Fix Style/RaiseArgs in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18405 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 16:08:44 +00:00
Go MAEDA
e9d74c01d0 Improve MailHandler logging for unauthorized attempts (#31899).
Patch by Gustavo Regal.


git-svn-id: http://svn.redmine.org/redmine/trunk@18404 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-27 15:42:05 +00:00
Go MAEDA
959b55779f Fix hard-coded string "no subject" in app/models/mail_handler.rb (#5820).
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18388 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-08-25 00:09:10 +00:00
Go MAEDA
7bb8ab5e24 Fix "Undefined local variable sender_email" error in MailHandler#receive_message_reply when receiving a reply to a locked topic (#31503).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18239 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-10 00:54:28 +00:00
Go MAEDA
2e0ec5b0e6 Remove trailing whitespaces from app (#31506).
Patch by Marius BALTEANU.


git-svn-id: http://svn.redmine.org/redmine/trunk@18230 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-06-06 14:47:34 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
b0e17e8199 Don't rescue Exception class (#31387).
Patch by Go MAEDA and Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18197 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 06:50:25 +00:00
Go MAEDA
143c359d90 Allows setting the private flag via mail keyword (#31324).
Patch by Jens Krämer.


git-svn-id: http://svn.redmine.org/redmine/trunk@18150 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-09 22:30:29 +00:00
Go MAEDA
303576e22d Use safe navigation operator (#30457).
git-svn-id: http://svn.redmine.org/redmine/trunk@18069 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-20 04:56:09 +00:00
Go MAEDA
2a154205ed MailHandler.safe_receive does not output any error log (#30457).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18066 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-04-20 04:11:55 +00:00
Go MAEDA
72e1451159 Use Regexp#match? to reduce allocations of MatchData object (#28940).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@18011 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-27 02:15:24 +00:00
Go MAEDA
606e75d12d Use #b shortcut instead of #force_encoding (#31059).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17992 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-20 01:36:44 +00:00
Go MAEDA
07b3087fda Enable frozen_string_literal for some files under app and lib directory (#26561).
git-svn-id: http://svn.redmine.org/redmine/trunk@17977 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-16 09:37:35 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Go MAEDA
3ce803e82b Parse author's name enclosed in parentheses in the From field when creating a user account from an email (#17699).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17914 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 11:55:15 +00:00
Go MAEDA
77f35cb818 Option to parse HTML part of multipart (HTML) emails first (#30838).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17913 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-03 08:17:59 +00:00
Go MAEDA
b41c5c89d4 Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name (#30785).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17879 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-18 13:21:18 +00:00
Go MAEDA
5329ef3b82 Reverts r17862.
git-svn-id: http://svn.redmine.org/redmine/trunk@17878 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-18 13:03:03 +00:00
Go MAEDA
b0b8978ff8 Fix: Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name (#30785).
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@17862 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-02-12 23:35:05 +00:00
Jean-Philippe Lang
e82e018938 Adding an issue note via email fails due to NoMethodError (#30455).
Patch by Go MAEDA.

git-svn-id: http://svn.redmine.org/redmine/trunk@17817 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-01-19 10:59:45 +00:00
Go MAEDA
f743d2356f Fix: Attachments are added even if validation fails when updating an issue via email (#28576).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@17630 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-11-23 06:07:32 +00:00