Commit Graph

98 Commits

Author SHA1 Message Date
Go MAEDA
0dcc20eed3 Preload tracker when retrieving journal events to improve Activity view performance (#42077).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23447 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-18 05:37:55 +00:00
Go MAEDA
cf4a72d3f5 Optimize journalized method to use preloaded Issue association for better Activity view performance (#42077).
Patch by Go MAEDA (user:maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@23446 e93f8b46-1217-0410-a6f0-8f06a7374b81
2025-01-18 05:36:19 +00:00
Go MAEDA
09451a1df0 Fix RuboCop offense Lint/SafeNavigationConsistency (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@23134 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-10-16 23:46:53 +00:00
Marius Balteanu
b5c48c1d97 Adds an option to send email notification when an attachment is added (#40569).
Patch by  Mizuki ISHIKAWA (#ishikawa999).

git-svn-id: https://svn.redmine.org/redmine/trunk@22790 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-04-28 06:40:12 +00:00
Marius Balteanu
38d950df55 Remove current year from source file copyright headers and update year in footer to 2024 (#40043).
git-svn-id: https://svn.redmine.org/redmine/trunk@22746 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-02-26 22:55:54 +00:00
Marius Balteanu
13aeb797cf Use ApplicationRecord instead of ActiveRecord::Base (#38975).
Patch by Minoru Maeda (@maeda-m).

git-svn-id: https://svn.redmine.org/redmine/trunk@22619 e93f8b46-1217-0410-a6f0-8f06a7374b81
2024-01-23 11:52:38 +00:00
Go MAEDA
ccee193f38 Cache the result of Journal#attachments (#39847).
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22581 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-31 02:02:31 +00:00
Go MAEDA
c8640d7ffc Fix RuboCop offense Style/HashEachMethods (#39887).
git-svn-id: https://svn.redmine.org/redmine/trunk@22532 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-12-20 08:13:48 +00:00
Go MAEDA
41b4bc54a5 Disable auto watch for the anonymous user (#38238).
Patch by Felix Schäfer.


git-svn-id: https://svn.redmine.org/redmine/trunk@22116 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-02-26 07:48:19 +00:00
Go MAEDA
92bd67c279 Update copyright year to 2023 (#38141).
git-svn-id: https://svn.redmine.org/redmine/trunk@22013 e93f8b46-1217-0410-a6f0-8f06a7374b81
2023-01-01 06:19:35 +00:00
Go MAEDA
d726df660f Adds visible? method to journal (#37772).
Patch by  Jens Krämer.


git-svn-id: https://svn.redmine.org/redmine/trunk@21905 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-10-20 04:11:58 +00:00
Go MAEDA
d7df1a740e Unify duplicate codes (#37687).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-23 04:47:49 +00:00
Go MAEDA
43c7cc03a5 Retrieve attachments with a single query when rendering a journal (#37687).
Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@21831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-09-23 04:46:39 +00:00
Go MAEDA
f52b3f90eb Mark edited journal notes as "Edited" (#31505).
Patch by Marius BALTEANU.


git-svn-id: https://svn.redmine.org/redmine/trunk@21713 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-07-17 04:40:01 +00:00
Marius Balteanu
e50190a82a Automatically add the user to the watchers list after contributing to an issue (#4347). User can enable/disable this feature from My Account.
Patch by Takenori TAKAKI and Jens Krämer. 


git-svn-id: http://svn.redmine.org/redmine/trunk@21469 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-03-19 10:14:29 +00:00
Marius Balteanu
ba74ba1c70 Allow users to be mentioned using @ in issues and wiki pages (#13919):
* the user must have add watchers permission on that object in order to mention other users
* mentioned user will receive a notification email
* only visible users who can view the object can be mentioned



git-svn-id: http://svn.redmine.org/redmine/trunk@21435 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-02-23 21:16:18 +00:00
Go MAEDA
3686b77eb6 Update copyright year in source files to 2022 (#36379).
git-svn-id: http://svn.redmine.org/redmine/trunk@21342 e93f8b46-1217-0410-a6f0-8f06a7374b81
2022-01-02 05:29:10 +00:00
Go MAEDA
b6a26a60f3 Fixes for Performance/StringIdentifierArgument introduced in RuboCop Performance 1.13.0 (#35142).
git-svn-id: http://svn.redmine.org/redmine/trunk@21330 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-12-29 06:12:27 +00:00
Go MAEDA
0a5ef25e87 Download all attachments in a journal (#35462).
Patch by Takenori TAKAKI.


git-svn-id: http://svn.redmine.org/redmine/trunk@21292 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-11-22 08:42:44 +00:00
Go MAEDA
83e22515b9 Ruby 3.0: Fix super calls (#34992, #34986).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20912 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-04-03 09:01:53 +00:00
Go MAEDA
3e36b5c452 Update copyright year in source files to 2021 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@20846 e93f8b46-1217-0410-a6f0-8f06a7374b81
2021-03-25 06:58:56 +00:00
Toshi MARUYAMA
bad4654b78 use "do end" instead of {} at ActiveRecord scope lambda of app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20319 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-11-09 13:25:27 +00:00
Toshi MARUYAMA
f4aa4b0f87 shorten long line of app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@20159 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-22 14:17:43 +00:00
Go MAEDA
e48ff48820 Evaluate acts_as_activity_provider's scope lazily (#33664).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@20148 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-10-17 02:02:50 +00:00
Toshi MARUYAMA
04206e70d4 remove spaces inside {} of app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19881 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-07-11 01:21:35 +00:00
Go MAEDA
907e0173e4 Update copyright year in source files to 2020 (#33069).
git-svn-id: http://svn.redmine.org/redmine/trunk@19553 e93f8b46-1217-0410-a6f0-8f06a7374b81
2020-03-03 00:24:10 +00:00
Toshi MARUYAMA
1cca05ecf3 cleanup: rubocop: fix Layout/ClosingParenthesisIndentation in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19313 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-26 06:30:01 +00:00
Toshi MARUYAMA
3ccbfd9ec1 cleanup: rubocop: fix Layout/IndentFirstArgument in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19307 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-25 18:58:05 +00:00
Toshi MARUYAMA
466a5bd3a8 cleanup: rubocop: fix Layout/EmptyLineAfterGuardClause in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19171 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-22 14:54:54 +00:00
Toshi MARUYAMA
12fbc3a817 cleanup: rubocop: fix Layout/AlignArguments in app/models/journal.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18936 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-11-08 00:46:13 +00:00
Go MAEDA
16c580a2f8 Option to send email notification on "Target version updated" (#17840).
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18595 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-05 09:46:05 +00:00
Go MAEDA
4082069c75 Update copyright year.
git-svn-id: http://svn.redmine.org/redmine/trunk@18198 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-05-25 07:36:06 +00:00
Go MAEDA
d4daf4e23b Support frozen_string_literal in issue, journal, and query (#26561).
Patch by Pavel Rosický.


git-svn-id: http://svn.redmine.org/redmine/trunk@17980 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-17 00:29:58 +00:00
Go MAEDA
5861160ffc Add "frozen_string_literal: false" for all files (#26561).
This will be changed to true in the future.


git-svn-id: http://svn.redmine.org/redmine/trunk@17947 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-03-15 01:32:57 +00:00
Jean-Philippe Lang
0c78056a69 Send emails asynchronously (#26791).
Custom async_* delivery methods are removed in favor of ActiveJob (Async by default).

git-svn-id: http://svn.redmine.org/redmine/trunk@17588 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-10 17:13:09 +00:00
Jean-Philippe Lang
5416ed1022 Cleanup: Remove Issue#each_notification and Journal#each_notification (#26791).
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@17584 e93f8b46-1217-0410-a6f0-8f06a7374b81
2018-10-06 13:09:38 +00:00
Jean-Philippe Lang
d74f0bfd5c Merged rails-5.1 branch (#23630).
git-svn-id: http://svn.redmine.org/redmine/trunk@16859 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-07-23 11:26:04 +00:00
Jean-Philippe Lang
7fd04e1f8d Update copyright.
git-svn-id: http://svn.redmine.org/redmine/trunk@16685 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-06-25 08:40:31 +00:00
Jean-Philippe Lang
9439cae70f Send journal notification after commit (#25794).
git-svn-id: http://svn.redmine.org/redmine/trunk@16573 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-05-27 08:44:24 +00:00
Jean-Philippe Lang
151a215ea4 Adds updated_by and last_updated_by filters on issues (#17720).
git-svn-id: http://svn.redmine.org/redmine/trunk@16228 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-19 20:16:49 +00:00
Jean-Philippe Lang
7b32a0371d Let user always see his private notes (#17632).
git-svn-id: http://svn.redmine.org/redmine/trunk@16181 e93f8b46-1217-0410-a6f0-8f06a7374b81
2017-01-14 09:50:28 +00:00
Jean-Philippe Lang
fcbd06e090 Allow Journal to return empty Array instead nil in Journal#attachments (#24308).
Patch by Roman Shipiev.

git-svn-id: http://svn.redmine.org/redmine/trunk@15957 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-11-18 08:41:56 +00:00
Jean-Philippe Lang
55be3ef172 Journalize values that are cleared after project or tracker change (#21623).
git-svn-id: http://svn.redmine.org/redmine/trunk@15811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-09-03 07:26:49 +00:00
Jean-Philippe Lang
d2f7e31951 Use .distinct instead of .uniq.
git-svn-id: http://svn.redmine.org/redmine/trunk@15654 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-14 07:15:13 +00:00
Jean-Philippe Lang
1f9bbd6b42 Wrap journal attributes with a journal parameter and use safe_attributes (#22575).
git-svn-id: http://svn.redmine.org/redmine/trunk@15621 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-07-10 10:58:00 +00:00
Jean-Philippe Lang
cda9c63d9c Updates copyright for 2016.
git-svn-id: http://svn.redmine.org/redmine/trunk@15238 e93f8b46-1217-0410-a6f0-8f06a7374b81
2016-03-13 10:30:10 +00:00
Jean-Philippe Lang
cb9d405db3 Fixed that journals are shown multiple times in activity (#19168).
git-svn-id: http://svn.redmine.org/redmine/trunk@14163 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-04-12 07:55:30 +00:00
Jean-Philippe Lang
726a9aa809 Set :inverse_of on details association.
git-svn-id: http://svn.redmine.org/redmine/trunk@13936 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-24 10:23:53 +00:00
Jean-Philippe Lang
000124f44f Copyright update.
git-svn-id: http://svn.redmine.org/redmine/trunk@13872 e93f8b46-1217-0410-a6f0-8f06a7374b81
2015-01-11 09:09:50 +00:00
Jean-Philippe Lang
2462a8581d Don't create a journal when creating an issue.
git-svn-id: http://svn.redmine.org/redmine/trunk@13732 e93f8b46-1217-0410-a6f0-8f06a7374b81
2014-12-08 17:18:28 +00:00