Commit Graph

266 Commits

Author SHA1 Message Date
Toshi MARUYAMA
136130d3f0 rubocop: set Layout/SpaceBeforeBlockBraces parameters used more than others
git-svn-id: http://svn.redmine.org/redmine/trunk@18852 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-23 06:44:43 +00:00
Toshi MARUYAMA
b94294f6b5 rubocop: set Layout/SpaceInsideBlockBraces parameters used more than others
git-svn-id: http://svn.redmine.org/redmine/trunk@18851 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-23 06:44:31 +00:00
Toshi MARUYAMA
082f1eed51 rubocop: move Layout/AlignArguments temporarily from .rubocop_todo.yml to .rubocop.yml
git-svn-id: http://svn.redmine.org/redmine/trunk@18850 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-23 06:44:20 +00:00
Toshi MARUYAMA
6a6d5e4560 code cleanup: rubocop: fix Layout/ClosingHeredocIndentation and Layout/IndentHeredoc in test/integration/lib/redmine/hook_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18849 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-23 05:37:55 +00:00
Toshi MARUYAMA
5ac6c987b3 rubocop: disable Bundler/OrderedGems
git-svn-id: http://svn.redmine.org/redmine/trunk@18845 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-23 04:57:44 +00:00
Toshi MARUYAMA
5d4f94142b code cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/export/pdf.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18839 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 16:06:34 +00:00
Toshi MARUYAMA
accab3c755 code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/helpers/application_helper_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18838 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 16:06:20 +00:00
Toshi MARUYAMA
05ef773897 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18837 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:55:11 +00:00
Toshi MARUYAMA
5ac2471a7a code cleanup: rubocop: fix Style/ParenthesesAroundCondition in lib/diff.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18836 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:59 +00:00
Toshi MARUYAMA
f077a0a480 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/wiki_page.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18835 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:48 +00:00
Toshi MARUYAMA
b6604ec751 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/time_entry.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18834 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:37 +00:00
Toshi MARUYAMA
48b2c8bc36 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/query.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18833 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:24 +00:00
Toshi MARUYAMA
790d2bae70 code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/models/project.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18832 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:12 +00:00
Toshi MARUYAMA
f4522aeba7 code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/controllers/wiki_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18831 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:54:00 +00:00
Toshi MARUYAMA
e079d49dd7 code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/role.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18829 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:53:37 +00:00
Toshi MARUYAMA
c54761c690 code cleanup: rubocop: fix Lint/NestedMethodDefinition in test/unit/lib/redmine/menu_manager/menu_helper_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18828 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 15:35:38 +00:00
Toshi MARUYAMA
a8b6e805a7 code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/timelog_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18825 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:44:15 +00:00
Toshi MARUYAMA
26db7fa6bf code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/messages_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18824 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:44:04 +00:00
Toshi MARUYAMA
facc6e9bff code cleanup: rubocop: fix Layout/AccessModifierIndentation and Layout/EmptyLinesAroundAccessModifier in app/controllers/boards_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18823 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:43:52 +00:00
Toshi MARUYAMA
8d429120ec code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/helpers/application_helper.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18822 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 13:43:40 +00:00
Toshi MARUYAMA
252450b44c code cleanup: rubocop: fix Performance/RedundantBlockCall in app/controllers/application_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18821 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:41:21 +00:00
Toshi MARUYAMA
319eeae14d code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18820 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:41:09 +00:00
Toshi MARUYAMA
00820109e9 code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18819 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:40:57 +00:00
Toshi MARUYAMA
d845f8ad22 rubocop: add new detected files to Performance/RedundantBlockCall (#32308)
git-svn-id: http://svn.redmine.org/redmine/trunk@18818 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:40:46 +00:00
Toshi MARUYAMA
71b8608421 code cleanup: rubocop: fix Performance/RedundantBlockCall in test/functional/repositories_git_controller_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18814 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:16:56 +00:00
Toshi MARUYAMA
030dbc7218 code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/views/builders/structure.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18813 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:10:14 +00:00
Toshi MARUYAMA
1ae761d169 code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/json_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18812 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:10:03 +00:00
Toshi MARUYAMA
3d342396a0 code cleanup: rubocop: fix Performance/RedundantBlockCall in test/unit/lib/redmine/views/builders/xml_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18811 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 12:09:52 +00:00
Toshi MARUYAMA
b7b42e9d76 code cleanup: rubocop: fix Layout/CommentIndentation and Layout/MultilineArrayBraceLayout in test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18810 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:41:21 +00:00
Toshi MARUYAMA
65328a5d53 rubocop: remove test/helpers/application_helper_test.rb from Layout/CaseIndentation and Layout/IndentHeredoc fixed by previous revisions
git-svn-id: http://svn.redmine.org/redmine/trunk@18809 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:41:10 +00:00
Toshi MARUYAMA
fb77bc49ae code cleanup: rubocop: fix Style/MultipleComparison in lib/redmine/scm/adapters/git_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18798 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:31:17 +00:00
Toshi MARUYAMA
abe627bb9c code cleanup: rubocop: fix Style/UnneededSort in test/unit/repository_git_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18797 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:31:05 +00:00
Toshi MARUYAMA
27dbbee75e code cleanup: rubocop: fix Style/UnneededInterpolation in lib/redmine/scm/adapters/git_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18796 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:54 +00:00
Toshi MARUYAMA
e57b7fd4c0 code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18795 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:41 +00:00
Toshi MARUYAMA
991230f37a code cleanup: rubocop: fix Layout/AccessModifierIndentation in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18794 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:29 +00:00
Toshi MARUYAMA
8318e9ad11 code cleanup: rubocop: fix Layout/AlignArray in lib/redmine/default_data/loader.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18793 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:17 +00:00
Toshi MARUYAMA
cd922bb237 code cleanup: rubocop: fix Layout/AlignArray in app/models/setting.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18792 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-22 11:30:05 +00:00
Toshi MARUYAMA
c95bead933 code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/attachment.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18783 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:34:16 +00:00
Toshi MARUYAMA
f2b274476a code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mail_handler.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18782 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:34:05 +00:00
Toshi MARUYAMA
d836d9cc69 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/attachment.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18781 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:54 +00:00
Toshi MARUYAMA
75d3e4037b code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18780 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:43 +00:00
Toshi MARUYAMA
fd7675adf2 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/user.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18779 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:32 +00:00
Toshi MARUYAMA
b0e28db7c7 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mailer.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18778 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:21 +00:00
Toshi MARUYAMA
7738078717 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/scm/adapters/abstract_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18777 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:33:10 +00:00
Toshi MARUYAMA
cb2d4068e8 code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/helpers/gantt.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18776 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:32:59 +00:00
Toshi MARUYAMA
b0b03c97c5 rubocop: enable Lint/IneffectiveAccessModifier
git-svn-id: http://svn.redmine.org/redmine/trunk@18775 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:32:48 +00:00
Toshi MARUYAMA
0365bd552e code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/controllers/context_menus_controller.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18774 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 13:32:37 +00:00
Toshi MARUYAMA
adff3bcb7e code cleanup: rubocop: fix Layout/CommentIndentation in lib/redmine/wiki_formatting/textile/redcloth3.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18773 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 12:25:46 +00:00
Toshi MARUYAMA
5e5712f82d code cleanup: rubocop: fix Layout/CommentIndentation in app/models/mailer.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18772 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 12:25:34 +00:00
Toshi MARUYAMA
7c796b96cc code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/unit/lib/redmine/helpers/calendar_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18771 e93f8b46-1217-0410-a6f0-8f06a7374b81
2019-10-19 12:25:22 +00:00