From e34eb2d89c0624739e4bdff00d2ae202550b62c4 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Thu, 17 Oct 2019 16:40:20 +0000 Subject: [PATCH] code cleanup: rubocop: fix Style/WhenThen in lib/redmine/views/builders.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18722 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - lib/redmine/views/builders.rb | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ba061adfb..1ccc0caa0 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1466,7 +1466,6 @@ Style/WhenThen: Exclude: - 'app/models/issue_query.rb' - 'app/models/role.rb' - - 'lib/redmine/views/builders.rb' # Cop supports --auto-correct. Style/WhileUntilModifier: diff --git a/lib/redmine/views/builders.rb b/lib/redmine/views/builders.rb index 907a56a69..4efdfbd48 100644 --- a/lib/redmine/views/builders.rb +++ b/lib/redmine/views/builders.rb @@ -25,9 +25,10 @@ module Redmine module Builders def self.for(format, request, response, &block) builder = case format - when 'xml', :xml; Builders::Xml.new(request, response) - when 'json', :json; Builders::Json.new(request, response) - else; raise "No builder for format #{format}" + when 'xml', :xml then Builders::Xml.new(request, response) + when 'json', :json then Builders::Json.new(request, response) + else + raise "No builder for format #{format}" end if block block.call(builder)