Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-10 07:16:03 +01:00
Code Issues Packages Projects Releases Activity

Show long text custom field changes as a diff (#15236).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@13954 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2015-01-31 10:42:41 +00:00
parent defd3f439f
commit e11f77a4b0
5 changed files with 65 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
test/functional/journals_controller_test.rb
View File

@@ -51,7 +51,7 @@ class JournalsControllerTest < ActionController::TestCase
assert_not_include journal, assigns(:journals)
end
def test_diff
def test_diff_for_description_change
get :diff, :id => 3, :detail_id => 4
assert_response :success
assert_template 'diff'
@@ -60,6 +60,30 @@ class JournalsControllerTest < ActionController::TestCase
assert_select 'span.diff_in', :text => /added/
end
def test_diff_for_custom_field
field = IssueCustomField.create!(:name => "Long field", :field_format => 'text')
journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Notes', :user_id => 1)
detail = JournalDetail.create!(:journal => journal, :property => 'cf', :prop_key => field.id,
:old_value => 'Foo', :value => 'Bar')
get :diff, :id => journal.id, :detail_id => detail.id
assert_response :success
assert_template 'diff'
assert_select 'span.diff_out', :text => /Foo/
assert_select 'span.diff_in', :text => /Bar/
end
def test_diff_for_custom_field_should_be_denied_if_custom_field_is_not_visible
field = IssueCustomField.create!(:name => "Long field", :field_format => 'text', :visible => false, :role_ids => [1])
journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Notes', :user_id => 1)
detail = JournalDetail.create!(:journal => journal, :property => 'cf', :prop_key => field.id,
:old_value => 'Foo', :value => 'Bar')
get :diff, :id => journal.id, :detail_id => detail.id
assert_response 302
end
def test_diff_should_default_to_description_diff
get :diff, :id => 3
assert_response :success