Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-10 15:26:03 +01:00
Code Issues Packages Projects Releases Activity

Improve method and variable naming for clarity and consistency (#42630).

Browse Source 
Patch by Katsuya HIDAKA (user:hidakatsuya).


git-svn-id: https://svn.redmine.org/redmine/trunk@23769 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2025-05-15 05:09:17 +00:00
parent e7703a0170
commit d2a9223c4a
4 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/unit/lib/redmine/reaction_test.rb
View File

@@ -149,7 +149,7 @@ class Redmine::ReactionTest < ActiveSupport::TestCase
assert_not Redmine::Reaction.visible?(object, user)
end
test 'writable? returns true for various reactable objects when user is logged in, object is visible, and project is active' do
test 'editable? returns true for various reactable objects when user is logged in, object is visible, and project is active' do
reactable_objects = {
issue: issues(:issues_007),
message: messages(:messages_001),
@@ -160,30 +160,30 @@ class Redmine::ReactionTest < ActiveSupport::TestCase
user = users(:users_002)
reactable_objects.each do |type, object|
assert Redmine::Reaction.writable?(object, user), "Expected writable? to return true for #{type}"
assert Redmine::Reaction.editable?(object, user), "Expected editable? to return true for #{type}"
end
end
test 'writable? returns false when user is not logged in' do
test 'editable? returns false when user is not logged in' do
object = issues(:issues_007)
user = User.anonymous
assert_not Redmine::Reaction.writable?(object, user)
assert_not Redmine::Reaction.editable?(object, user)
end
test 'writable? returns false when project is inactive' do
test 'editable? returns false when project is inactive' do
object = issues(:issues_007)
user = users(:users_002)
object.project.update!(status: Project::STATUS_ARCHIVED)
assert_not Redmine::Reaction.writable?(object, user)
assert_not Redmine::Reaction.editable?(object, user)
end
test 'writable? returns false when project is closed' do
test 'editable? returns false when project is closed' do
object = issues(:issues_007)
user = users(:users_002)
object.project.update!(status: Project::STATUS_CLOSED)
assert_not Redmine::Reaction.writable?(object, user)
assert_not Redmine::Reaction.editable?(object, user)
end
end