Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-06 05:16:12 +01:00
Code Issues Packages Projects Releases Activity

Use safe_attributes for issue statuses.

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@15691 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2016-07-17 08:09:50 +00:00
parent cf22053dd5
commit cc30a0423e
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/controllers/issue_statuses_controller.rb
View File

@@ -35,7 +35,8 @@ class IssueStatusesController < ApplicationController
end end
def create def create
@issue_status = IssueStatus.new(params[:issue_status]) @issue_status = IssueStatus.new
@issue_status.safe_attributes = params[:issue_status]
if @issue_status.save if @issue_status.save
flash[:notice] = l(:notice_successful_create) flash[:notice] = l(:notice_successful_create)
redirect_to issue_statuses_path redirect_to issue_statuses_path
@@ -50,7 +51,8 @@ class IssueStatusesController < ApplicationController
def update def update
@issue_status = IssueStatus.find(params[:id]) @issue_status = IssueStatus.find(params[:id])
if @issue_status.update_attributes(params[:issue_status]) @issue_status.safe_attributes = params[:issue_status]
if @issue_status.save
respond_to do |format| respond_to do |format|
format.html { format.html {
flash[:notice] = l(:notice_successful_update) flash[:notice] = l(:notice_successful_update)

7
app/models/issue_status.rb
View File

@@ -16,6 +16,8 @@
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
class IssueStatus < ActiveRecord::Base class IssueStatus < ActiveRecord::Base
include Redmine::SafeAttributes
before_destroy :check_integrity before_destroy :check_integrity
has_many :workflows, :class_name => 'WorkflowTransition', :foreign_key => "old_status_id" has_many :workflows, :class_name => 'WorkflowTransition', :foreign_key => "old_status_id"
has_many :workflow_transitions_as_new_status, :class_name => 'WorkflowTransition', :foreign_key => "new_status_id" has_many :workflow_transitions_as_new_status, :class_name => 'WorkflowTransition', :foreign_key => "new_status_id"
@@ -33,6 +35,11 @@ class IssueStatus < ActiveRecord::Base
scope :sorted, lambda { order(:position) } scope :sorted, lambda { order(:position) }
scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)} scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
safe_attributes 'name',
'is_closed',
'position',
'default_done_ratio'
# Update all the +Issues+ setting their done_ratio to the value of their +IssueStatus+ # Update all the +Issues+ setting their done_ratio to the value of their +IssueStatus+
def self.update_issue_done_ratios def self.update_issue_done_ratios
if Issue.use_status_for_done_ratio? if Issue.use_status_for_done_ratio?