Code cleanup: RuboCop: Style/DefWithParentheses

git-svn-id: http://svn.redmine.org/redmine/trunk@18290 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop_todo.yml

@@ -1444,14 +1444,6 @@ Style/CommentedKeyword:
 Style/ConditionalAssignment:
   Enabled: false
 
-# Offense count: 3
-# Cop supports --auto-correct.
-Style/DefWithParentheses:
-  Exclude:
-    - 'app/helpers/sort_helper.rb'
-    - 'lib/redmine/scm/adapters/cvs_adapter.rb'
-    - 'lib/redmine/unified_diff.rb'
-
 # Offense count: 626
 Style/Documentation:
   Enabled: false

app/helpers/issues_helper.rb

@@ -551,7 +551,7 @@ module IssuesHelper
   end
 
   # Issue history tabs
-  def issue_history_tabs()
+  def issue_history_tabs
     tabs = []
     if @journals.present?
       journals_without_notes = @journals.select{|value| value.notes.blank?}

app/helpers/sort_helper.rb

@@ -96,7 +96,7 @@ module SortHelper
   # Returns an SQL sort clause corresponding to the current sort state.
   # Use this to sort the controller's table items collection.
   #
-  def sort_clause()
+  def sort_clause
     @sort_criteria.sort_clause(@sortable_columns)
   end
 

lib/redmine/scm/adapters/cvs_adapter.rb

@@ -445,7 +445,7 @@ module Redmine
         end
 
         # Interpretiert die cvs revisionsnummern wie z.b. 1.14 oder 1.3.0.15
-        def parseRevision()
+        def parseRevision
           pieces = @complete_rev.split(".")
           @revision = pieces.last.to_i
           baseSize = 1

lib/redmine/unified_diff.rb

@@ -227,7 +227,7 @@ module Redmine
     attr_accessor :type_diff_left
     attr_accessor :offsets
 
-    def initialize()
+    def initialize
       self.nb_line_left = ''
       self.nb_line_right = ''
       self.line_left = ''