Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-12 08:16:03 +01:00
Code Issues Packages Projects Releases Activity

Fixed unsafe call to #casecmp (#20369, #21000).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@14676 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2015-10-15 18:31:34 +00:00
parent bf4e5da59b
commit bae4b1985d
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/helpers/application_helper.rb
View File

@@ -609,7 +609,7 @@ module ApplicationHelper
parsed << text parsed << text
if tag if tag
if closing if closing
if tags.last.casecmp(tag) == 0 if tags.last && tags.last.casecmp(tag) == 0
tags.pop tags.pop
end end
else else

6
test/unit/helpers/application_helper_test.rb
View File

@@ -994,6 +994,12 @@ EXPECTED
assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '') assert_equal expected.gsub(%r{[\r\n\t]}, ''), textilizable(raw).gsub(%r{[\r\n\t]}, '')
end end
def test_unbalanced_closing_pre_tag_should_not_error
assert_nothing_raised do
textilizable("unbalanced</pre>")
end
end
def test_syntax_highlight def test_syntax_highlight
raw = <<-RAW raw = <<-RAW
<pre><code class="ruby"> <pre><code class="ruby">