Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-08 22:36:02 +01:00
Code Issues Packages Projects Releases Activity

Set default assignee before validation (#26072).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@16619 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2017-06-06 21:11:37 +00:00
parent ee0e821cc4
commit b997f03211
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/issue.rb
View File

@@ -105,8 +105,8 @@ class Issue < ActiveRecord::Base
end end
} }
before_validation :default_assign, on: :create
before_validation :clear_disabled_fields before_validation :clear_disabled_fields
before_create :default_assign
before_save :close_duplicates, :update_done_ratio_from_issue_status, before_save :close_duplicates, :update_done_ratio_from_issue_status,
:force_updated_on_change, :update_closed_on, :set_assigned_to_was :force_updated_on_change, :update_closed_on, :set_assigned_to_was
after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?} after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}

12
test/unit/issue_test.rb
View File

@@ -625,6 +625,18 @@ class IssueTest < ActiveSupport::TestCase
assert_equal user, issue.assigned_to assert_equal user, issue.assigned_to
end end
def test_default_assigned_to_with_required_assignee_should_validate
category = IssueCategory.create!(:project_id => 1, :name => 'With default assignee', :assigned_to_id => 3)
Issue.any_instance.stubs(:required_attribute_names).returns(['assigned_to_id'])
issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default')
assert !issue.save
assert issue.errors['assigned_to_id'].present?
issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'Default', :category_id => category.id)
assert_save issue
end
def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
:status_id => 1, :subject => 'Test', :status_id => 1, :subject => 'Test',