Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-13 08:46:01 +01:00
Code Issues Packages Projects Releases Activity

##123 syntax for linking to issues: Title cannot be distinguished from following text (#32765).

Browse Source 
Patch by Marius BALTEANU.

git-svn-id: http://svn.redmine.org/redmine/trunk@19663 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2020-04-05 10:51:46 +00:00
parent ace151c14c
commit 9b5cccff39
2 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/helpers/application_helper.rb
View File

@@ -1059,10 +1059,10 @@ module ApplicationHelper
url = issue_url(issue, :only_path => only_path, :anchor => anchor) url = issue_url(issue, :only_path => only_path, :anchor => anchor)
link = link =
if sep == '##' if sep == '##'
link_to("#{issue.tracker.name} ##{oid}#{comment_suffix}", link_to("#{issue.tracker.name} ##{oid}#{comment_suffix}: #{issue.subject}",
url, url,
:class => issue.css_classes, :class => issue.css_classes,
:title => "#{issue.tracker.name}: #{issue.subject.truncate(100)} (#{issue.status.name})") + ": #{issue.subject}" :title => "#{l(:field_status)}: #{issue.status.name}")
else else
link_to("##{oid}#{comment_suffix}", link_to("##{oid}#{comment_suffix}",
url, url,

15
test/helpers/application_helper_test.rb
View File

@@ -310,11 +310,10 @@ class ApplicationHelperTest < Redmine::HelperTest
:class => Issue.find(3).css_classes, :class => Issue.find(3).css_classes,
:title => 'Bug: Error 281 when updating a recipe (New)') :title => 'Bug: Error 281 when updating a recipe (New)')
ext_issue_link = link_to( ext_issue_link = link_to(
'Bug #3', 'Bug #3: Error 281 when updating a recipe',
{:controller => 'issues', :action => 'show', :id => 3}, {:controller => 'issues', :action => 'show', :id => 3},
:class => Issue.find(3).css_classes, :class => Issue.find(3).css_classes,
:title => 'Bug: Error 281 when updating a recipe (New)') + :title => 'Status: New')
": Error 281 when updating a recipe"
note_link = link_to( note_link = link_to(
'#3-14', '#3-14',
{:controller => 'issues', :action => 'show', {:controller => 'issues', :action => 'show',
@@ -322,12 +321,11 @@ class ApplicationHelperTest < Redmine::HelperTest
:class => Issue.find(3).css_classes, :class => Issue.find(3).css_classes,
:title => 'Bug: Error 281 when updating a recipe (New)') :title => 'Bug: Error 281 when updating a recipe (New)')
ext_note_link = link_to( ext_note_link = link_to(
'Bug #3-14', 'Bug #3-14: Error 281 when updating a recipe',
{:controller => 'issues', :action => 'show', {:controller => 'issues', :action => 'show',
:id => 3, :anchor => 'note-14'}, :id => 3, :anchor => 'note-14'},
:class => Issue.find(3).css_classes, :class => Issue.find(3).css_classes,
:title => 'Bug: Error 281 when updating a recipe (New)') + :title => 'Status: New')
": Error 281 when updating a recipe"
note_link2 = link_to( note_link2 = link_to(
'#3#note-14', '#3#note-14',
{:controller => 'issues', :action => 'show', {:controller => 'issues', :action => 'show',
@@ -335,12 +333,11 @@ class ApplicationHelperTest < Redmine::HelperTest
:class => Issue.find(3).css_classes, :class => Issue.find(3).css_classes,
:title => 'Bug: Error 281 when updating a recipe (New)') :title => 'Bug: Error 281 when updating a recipe (New)')
ext_note_link2 = link_to( ext_note_link2 = link_to(
'Bug #3#note-14', 'Bug #3#note-14: Error 281 when updating a recipe',
{:controller => 'issues', :action => 'show', {:controller => 'issues', :action => 'show',
:id => 3, :anchor => 'note-14'}, :id => 3, :anchor => 'note-14'},
:class => Issue.find(3).css_classes, :class => Issue.find(3).css_classes,
:title => 'Bug: Error 281 when updating a recipe (New)') + :title => 'Status: New')
": Error 281 when updating a recipe"
revision_link = link_to( revision_link = link_to(
'r1', 'r1',