Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-14 01:06:00 +01:00
Code Issues Packages Projects Releases Activity

Users API should return twofa_scheme only for administrators (#34242).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@20687 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2020-12-23 03:47:45 +00:00
parent 5eb4b6af79
commit 988a36babc
2 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/integration/api_test/users_test.rb
View File

@@ -84,7 +84,6 @@ class Redmine::ApiTest::UsersTest < Redmine::ApiTest::Base
assert_select 'user id', :text => '2'
assert_select 'user updated_on', :text => Time.zone.parse('2006-07-19T20:42:15Z').iso8601
assert_select 'user passwd_changed_on', :text => ''
assert_select 'user twofa_scheme', :text => ''
end
test "GET /users/:id.json should return the user" do
@@ -174,6 +173,20 @@ class Redmine::ApiTest::UsersTest < Redmine::ApiTest::Base
assert_select 'user admin', 0
end
test "GET /users/:id should not return twofa_scheme for standard user" do
User.find(2).update(twofa_scheme: 'totp')
get '/users/3.xml', :headers => credentials('jsmith')
assert_response :success
assert_select 'twofa_scheme', 0
end
test "GET /users/:id should return twofa_scheme for administrators" do
User.find(2).update(twofa_scheme: 'totp')
get '/users/2.xml', :headers => credentials('admin')
assert_response :success
assert_select 'twofa_scheme', :text => 'totp'
end
test "POST /users.xml with valid parameters should create the user" do
assert_difference('User.count') do
post(