Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-07 22:05:56 +01:00
Code Issues Packages Projects Releases Activity

Psych::DisallowedClass exception when loading default plugin settings (#37450, #37476).

Browse Source 
Contributed by Dmitry Makurin.


git-svn-id: https://svn.redmine.org/redmine/trunk@21725 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2022-07-21 00:41:29 +00:00
parent b6c218deed
commit 7752e9a19a
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/setting.rb
View File

@@ -108,7 +108,7 @@ class Setting < ActiveRecord::Base
v = read_attribute(:value) v = read_attribute(:value)
# Unserialize serialized settings # Unserialize serialized settings
if available_settings[name]['serialized'] && v.is_a?(String) if available_settings[name]['serialized'] && v.is_a?(String)
v = YAML.safe_load(v, permitted_classes: [ActiveSupport::HashWithIndifferentAccess]) v = YAML.safe_load(v, permitted_classes: [Symbol, ActiveSupport::HashWithIndifferentAccess])
v = force_utf8_strings(v) v = force_utf8_strings(v)
end end
v = v.to_sym if available_settings[name]['format'] == 'symbol' && !v.blank? v = v.to_sym if available_settings[name]['format'] == 'symbol' && !v.blank?

7
test/unit/lib/redmine/plugin_test.rb
View File

@@ -196,6 +196,13 @@ class Redmine::PluginTest < ActiveSupport::TestCase
end end
end end
def test_default_settings
@klass.register(:foo_plugin) {settings :default => {'key1' => 'abc', :key2 => 123}}
h = Setting.plugin_foo_plugin
assert_equal 'abc', h['key1']
assert_equal 123, h[:key2]
end
def test_settings_warns_about_possible_partial_collision def test_settings_warns_about_possible_partial_collision
@klass.register(:foo_plugin) {settings :partial => 'foo/settings'} @klass.register(:foo_plugin) {settings :partial => 'foo/settings'}
Rails.logger.expects(:warn) Rails.logger.expects(:warn)