code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@18780 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop_todo.yml

@@ -391,7 +391,6 @@ Lint/HandleExceptions:
 Lint/IneffectiveAccessModifier:
   Exclude:
     - 'app/models/attachment.rb'
-    - 'app/models/issue.rb'
     - 'app/models/mail_handler.rb'
 
 Lint/InterpolationCheck:

app/models/issue.rb

@@ -1724,9 +1724,11 @@ class Issue < ActiveRecord::Base
     end
   end
 
+  # Singleton class method is public
+  class << self
     # Update issues so their versions are not pointing to a
     # fixed_version that is not shared with the issue's project
-  def self.update_versions(conditions=nil)
+    def update_versions(conditions=nil)
       # Only need to update issues with a fixed_version from
       # a different project and that is not systemwide shared
       Issue.joins(:project, :fixed_version).
@@ -1742,6 +1744,7 @@ class Issue < ActiveRecord::Base
         end
       end
     end
+  end
 
   def delete_selected_attachments
     if deleted_attachment_ids.present?