Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-15 09:46:02 +01:00
Code Issues Packages Projects Releases Activity

Fix that "Successful deletion" notice is not displayed after deleting some types of content (#33116).

Browse Source 
Patch by Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19641 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2020-04-04 00:43:28 +00:00
parent a24834fa77
commit 6e781f6479
8 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/functional/issues_controller_test.rb
View File

@@ -7509,6 +7509,7 @@ class IssuesControllerTest < Redmine::ControllerTest
delete(:destroy, :params => {:id => 2})
end
assert_redirected_to :action => 'index', :project_id => 'ecookbook'
assert_equal 'Successful deletion.', flash[:notice]
assert_nil Issue.find_by_id(2)
end
@@ -7588,6 +7589,7 @@ class IssuesControllerTest < Redmine::ControllerTest
end
end
assert_redirected_to :action => 'index', :project_id => 'ecookbook'
assert_equal 'Successful deletion.', flash[:notice]
assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
assert_nil TimeEntry.find_by_id([1, 2])
end
@@ -7609,6 +7611,7 @@ class IssuesControllerTest < Redmine::ControllerTest
end
end
assert_redirected_to :action => 'index', :project_id => 'ecookbook'
assert_equal 'Successful deletion.', flash[:notice]
assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
assert_nil TimeEntry.find(1).issue_id
assert_nil TimeEntry.find(2).issue_id
@@ -7630,6 +7633,7 @@ class IssuesControllerTest < Redmine::ControllerTest
end
end
assert_redirected_to :action => 'index', :project_id => 'ecookbook'
assert_equal 'Successful deletion.', flash[:notice]
assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
assert_equal 2, TimeEntry.find(1).issue_id
assert_equal 2, TimeEntry.find(2).issue_id
@@ -7654,6 +7658,7 @@ class IssuesControllerTest < Redmine::ControllerTest
}
)
assert_response 302
assert_equal 'Successful deletion.', flash[:notice]
end
end
assert_equal 3, target.time_entries.count
@@ -7730,6 +7735,7 @@ class IssuesControllerTest < Redmine::ControllerTest
)
end
assert_redirected_to :controller => 'issues', :action => 'index'
assert_equal 'Successful deletion.', flash[:notice]
assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
end
@@ -7750,6 +7756,7 @@ class IssuesControllerTest < Redmine::ControllerTest
)
end
assert_response 302
assert_equal 'Successful deletion.', flash[:notice]
end
def test_destroy_invalid_should_respond_with_404
@@ -7770,6 +7777,7 @@ class IssuesControllerTest < Redmine::ControllerTest
delete(:destroy, :params => {:id => issue.id})
end
assert_response 302
assert_equal 'Successful deletion.', flash[:notice]
end
def test_destroy_without_permission_on_tracker_should_be_denied