Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-12-16 13:30:28 +01:00
Code Issues Packages Projects Releases Activity

Done ratio of a parent issue may be shown as 99% even though all subtasks are completed (#33576).

Browse Source 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19818 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2020-06-14 06:56:05 +00:00
parent 6bad47168d
commit 6416bb5f51
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/models/issue.rb
View File

@@ -1731,12 +1731,12 @@ class Issue < ActiveRecord::Base
if children.any? if children.any?
child_with_total_estimated_hours = children.select {|c| c.total_estimated_hours.to_f > 0.0} child_with_total_estimated_hours = children.select {|c| c.total_estimated_hours.to_f > 0.0}
if child_with_total_estimated_hours.any? if child_with_total_estimated_hours.any?
average = child_with_total_estimated_hours.map(&:total_estimated_hours).sum.to_f / child_with_total_estimated_hours.count average = child_with_total_estimated_hours.map(&:total_estimated_hours).sum.to_d / child_with_total_estimated_hours.count
else else
average = 1.0 average = 1.0.to_d
end end
done = children.map {|c| done = children.map {|c|
estimated = c.total_estimated_hours.to_f estimated = (c.total_estimated_hours || 0.0).to_d
estimated = average unless estimated > 0.0 estimated = average unless estimated > 0.0
ratio = c.closed? ? 100 : (c.done_ratio || 0) ratio = c.closed? ? 100 : (c.done_ratio || 0)
estimated * ratio estimated * ratio

10
test/unit/issue_subtasking_test.rb
View File

@@ -241,6 +241,16 @@ class IssueSubtaskingTest < ActiveSupport::TestCase
end end
end end
def test_done_ratio_of_parent_with_completed_children_should_not_be_99
with_settings :parent_issue_done_ratio => 'derived' do
parent = Issue.generate!
parent.generate_child!(:estimated_hours => 8.0, :done_ratio => 100)
parent.generate_child!(:estimated_hours => 8.1, :done_ratio => 100)
# (8.0 * 100 + 8.1 * 100) / (8.0 + 8.1) => 99.99999999999999
assert_equal 100, parent.reload.done_ratio
end
end
def test_changing_parent_should_update_previous_parent_done_ratio def test_changing_parent_should_update_previous_parent_done_ratio
with_settings :parent_issue_done_ratio => 'derived' do with_settings :parent_issue_done_ratio => 'derived' do
first_parent = Issue.generate! first_parent = Issue.generate!