Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-10-26 07:46:17 +01:00
Code Issues Packages Projects Releases Activity

Don't pass conditions to #delete_all.

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@15675 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2016-07-16 10:30:45 +00:00
parent d3d62f4ded
commit 57afa5345e
14 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
db/migrate/20101104182107_add_unique_index_on_members.rb
View File

@@ -1,7 +1,7 @@
class AddUniqueIndexOnMembers < ActiveRecord::Migration
def self.up
# Clean and reassign MemberRole rows if needed
MemberRole.delete_all("member_id NOT IN (SELECT id FROM #{Member.table_name})")
MemberRole.where("member_id NOT IN (SELECT id FROM #{Member.table_name})").delete_all
MemberRole.update_all("member_id =" +
" (SELECT min(m2.id) FROM #{Member.table_name} m1, #{Member.table_name} m2" +
" WHERE m1.user_id = m2.user_id AND m1.project_id = m2.project_id" +
@@ -9,7 +9,7 @@ class AddUniqueIndexOnMembers < ActiveRecord::Migration
# Remove duplicates
Member.connection.select_values("SELECT m.id FROM #{Member.table_name} m" +
" WHERE m.id > (SELECT min(m1.id) FROM #{Member.table_name} m1 WHERE m1.user_id = m.user_id AND m1.project_id = m.project_id)").each do |i|
Member.delete_all(["id = ?", i])
Member.where(["id = ?", i]).delete_all
end
# Then add a unique index