Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-06 13:25:44 +01:00
Code Issues Packages Projects Releases Activity

Reject setting RFC non-compliant emission email addresses (#31154).

Browse Source 
Patch by Mizuki ISHIKAWA.


git-svn-id: http://svn.redmine.org/redmine/trunk@18396 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA
2019-08-26 04:18:18 +00:00
parent e03617881e
commit 47dd2083f7
3 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/unit/setting_test.rb
View File

@@ -132,4 +132,18 @@ YAML
Setting.where(:name => 'commit_update_keywords').delete_all
Setting.clear_cache
end
def test_mail_from_format_should_be_validated
with_settings :default_language => 'en' do
['[Redmine app] <redmine@example.net>', 'redmine'].each do |invalid_mail_from|
errors = Setting.set_all_from_params({:mail_from => invalid_mail_from})
assert_includes errors, [:mail_from, 'is invalid']
end
['Redmine app <redmine@example.net>', 'redmine@example.net', '<redmine@example.net>'].each do |valid_mail_from|
errors = Setting.set_all_from_params({:mail_from => valid_mail_from})
assert_nil errors
end
end
end
end