Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-09 14:56:01 +01:00
Code Issues Packages Projects Releases Activity

Be more conservative when fetching constants in Repository.factory (#23758).

Browse Source 
Patch by Holger Just.

git-svn-id: http://svn.redmine.org/redmine/trunk@15816 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2016-09-04 17:10:12 +00:00
parent dcf2e15b06
commit 45a0daa16a
2 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/models/repository.rb
View File

@@ -363,10 +363,14 @@ class Repository < ActiveRecord::Base
end
def self.factory(klass_name, *args)
klass = "Repository::#{klass_name}".constantize
klass.new(*args)
rescue
nil
repository_class(klass_name).new(*args) rescue nil
end
def self.repository_class(class_name)
class_name = class_name.to_s.classify
if Redmine::Scm::Base.all.include?(class_name)
"Repository::#{class_name}".constantize
end
end
def self.scm_adapter_class

14
test/unit/repository_test.rb
View File

@@ -496,4 +496,18 @@ class RepositoryTest < ActiveSupport::TestCase
Repository::Subversion.any_instance.expects(:fetch_changesets).twice.returns(true)
Repository.fetch_changesets
end
def test_repository_class
assert_equal Repository::Subversion, Repository.repository_class('Subversion')
assert_equal Repository::Git, Repository.repository_class('Git')
assert_nil Repository.factory('Serializer')
assert_nil Repository.factory('Query')
end
def test_factory
assert_instance_of Repository::Subversion, Repository.factory('Subversion')
assert_instance_of Repository::Git, Repository.factory('Git')
assert_nil Repository.factory('Serializer')
assert_nil Repository.factory('Query')
end
end