Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-07 22:05:56 +01:00
Code Issues Packages Projects Releases Activity

Fixed that timestamps may not be formatted as expected in XML responses (#19065).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@14015 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2015-02-16 17:57:52 +00:00
parent 3ef00ddb58
commit 177dd7bff1
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/redmine/views/builders/xml.rb
View File

@@ -30,9 +30,10 @@ module Redmine
target! target!
end end
def method_missing(sym, *args, &block) # Overrides Builder::XmlBase#tag! to format timestamps in ISO 8601
def tag!(sym, *args, &block)
if args.size == 1 && args.first.is_a?(::Time) if args.size == 1 && args.first.is_a?(::Time)
__send__ sym, args.first.xmlschema, &block tag! sym, args.first.xmlschema, &block
else else
super super
end end

9
test/integration/api_test/issues_test.rb
View File

@@ -183,6 +183,15 @@ class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
end end
end end
test "GET /issues/:id.xml with journals should format timestamps in ISO 8601" do
get '/issues/1.xml?include=journals'
iso_date = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/
assert_select 'issue>created_on', :text => iso_date
assert_select 'issue>updated_on', :text => iso_date
assert_select 'issue journal>created_on', :text => iso_date
end
test "GET /issues/:id.xml with custom fields" do test "GET /issues/:id.xml with custom fields" do
get '/issues/3.xml' get '/issues/3.xml'