Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-12-17 22:10:27 +01:00
Code Issues Packages Projects Releases Activity

code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@18759 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA
2019-10-19 11:15:54 +00:00
parent 0fdaa963aa
commit 163e6eb6f7
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.rubocop_todo.yml
View File

@@ -1446,7 +1446,6 @@ Style/VariableInterpolation:
Style/WhileUntilModifier: Style/WhileUntilModifier:
Exclude: Exclude:
- 'app/models/attachment.rb' - 'app/models/attachment.rb'
- 'lib/redmine/unified_diff.rb'
- 'lib/redmine/utils.rb' - 'lib/redmine/utils.rb'
# Cop supports --auto-correct. # Cop supports --auto-correct.

6
lib/redmine/unified_diff.rb
View File

@@ -203,11 +203,13 @@ module Redmine
if line_left.present? && line_right.present? && line_left != line_right if line_left.present? && line_right.present? && line_left != line_right
max = [line_left.size, line_right.size].min max = [line_left.size, line_right.size].min
starting = 0 starting = 0
while starting < max && line_left[starting] == line_right[starting] while starting < max &&
line_left[starting] == line_right[starting]
starting += 1 starting += 1
end end
ending = -1 ending = -1
while ending >= -(max - starting) && (line_left[ending] == line_right[ending]) while ending >= -(max - starting) &&
(line_left[ending] == line_right[ending])
ending -= 1 ending -= 1
end end
unless starting == 0 && ending == -1 unless starting == 0 && ending == -1