Nemcio/Redmine
1
0
Fork 0
mirror of https://github.com/redmine/redmine.git synced 2025-11-12 08:16:03 +01:00
Code Issues Packages Projects Releases Activity

Display the bulk edit form with error messages when some issues can not be saved (#13943).

Browse Source 
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11786 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang
2013-05-04 08:52:51 +00:00
parent ed18b3359b
commit 1269e6c7d3
5 changed files with 73 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
test/functional/issues_controller_test.rb
View File

@@ -3588,13 +3588,32 @@ class IssuesControllerTest < ActionController::TestCase
assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
end
def test_bulk_update_with_failure_should_set_flash
def test_bulk_update_with_all_failures_should_show_errors
@request.session[:user_id] = 2
Issue.update_all("subject = ''", "id = 2") # Make it invalid
post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
post :bulk_update, :ids => [1, 2], :issue => {:start_date => 'foo'}
assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
assert_equal 'Failed to save 1 issue(s) on 2 selected: #2.', flash[:error]
assert_response :success
assert_template 'bulk_edit'
assert_select '#errorExplanation span', :text => 'Failed to save 2 issue(s) on 2 selected: #1, #2.'
assert_select '#errorExplanation ul li', :text => 'Start date is not a valid date: #1, #2'
assert_equal [1, 2], assigns[:issues].map(&:id)
end
def test_bulk_update_with_some_failures_should_show_errors
issue1 = Issue.generate!(:start_date => '2013-05-12')
issue2 = Issue.generate!(:start_date => '2013-05-15')
issue3 = Issue.generate!
@request.session[:user_id] = 2
post :bulk_update, :ids => [issue1.id, issue2.id, issue3.id], :issue => {:due_date => '2013-05-01'}
assert_response :success
assert_template 'bulk_edit'
assert_select '#errorExplanation span', :text => "Failed to save 2 issue(s) on 3 selected: ##{issue1.id}, ##{issue2.id}."
assert_select '#errorExplanation ul li', :text => "Due date must be greater than start date: ##{issue1.id}, ##{issue2.id}"
assert_equal [issue1.id, issue2.id], assigns[:issues].map(&:id)
end
def test_get_bulk_copy