2019-03-16 15:03:47 +00:00
|
|
|
# frozen_string_literal: true
|
2019-03-15 01:32:57 +00:00
|
|
|
|
2011-08-30 05:50:24 +00:00
|
|
|
# Redmine - project management software
|
2021-03-25 06:58:56 +00:00
|
|
|
# Copyright (C) 2006-2021 Jean-Philippe Lang
|
2009-05-30 23:30:36 +00:00
|
|
|
#
|
|
|
|
|
# This program is free software; you can redistribute it and/or
|
|
|
|
|
# modify it under the terms of the GNU General Public License
|
|
|
|
|
# as published by the Free Software Foundation; either version 2
|
|
|
|
|
# of the License, or (at your option) any later version.
|
2011-08-30 05:50:24 +00:00
|
|
|
#
|
2009-05-30 23:30:36 +00:00
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
# GNU General Public License for more details.
|
2011-08-30 05:50:24 +00:00
|
|
|
#
|
2009-05-30 23:30:36 +00:00
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
|
# along with this program; if not, write to the Free Software
|
|
|
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
|
|
|
|
2010-12-12 23:24:34 +00:00
|
|
|
require File.expand_path('../../test_helper', __FILE__)
|
2009-05-30 23:30:36 +00:00
|
|
|
|
2009-09-13 17:14:35 +00:00
|
|
|
class TimeEntryActivityTest < ActiveSupport::TestCase
|
2018-12-16 06:21:02 +00:00
|
|
|
fixtures :enumerations, :time_entries,
|
|
|
|
|
:custom_fields, :custom_values,
|
2014-09-12 13:40:07 +00:00
|
|
|
:issues, :projects, :users,
|
|
|
|
|
:members, :roles, :member_roles,
|
|
|
|
|
:trackers, :issue_statuses,
|
|
|
|
|
:projects_trackers,
|
|
|
|
|
:issue_categories,
|
|
|
|
|
:groups_users,
|
|
|
|
|
:enabled_modules
|
2009-05-30 23:30:36 +00:00
|
|
|
|
2012-01-28 11:16:58 +00:00
|
|
|
include Redmine::I18n
|
|
|
|
|
|
2018-12-16 17:23:31 +00:00
|
|
|
def setup
|
|
|
|
|
User.current = nil
|
|
|
|
|
end
|
|
|
|
|
|
2009-05-30 23:30:36 +00:00
|
|
|
def test_should_be_an_enumeration
|
|
|
|
|
assert TimeEntryActivity.ancestors.include?(Enumeration)
|
|
|
|
|
end
|
2011-04-04 11:54:22 +00:00
|
|
|
|
2009-05-30 23:30:36 +00:00
|
|
|
def test_objects_count
|
|
|
|
|
assert_equal 3, TimeEntryActivity.find_by_name("Design").objects_count
|
2011-04-04 11:54:22 +00:00
|
|
|
assert_equal 2, TimeEntryActivity.find_by_name("Development").objects_count
|
2009-05-30 23:30:36 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def test_option_name
|
|
|
|
|
assert_equal :enumeration_activities, TimeEntryActivity.new.option_name
|
|
|
|
|
end
|
2009-10-21 22:34:22 +00:00
|
|
|
|
|
|
|
|
def test_create_with_custom_field
|
|
|
|
|
field = TimeEntryActivityCustomField.find_by_name('Billable')
|
|
|
|
|
e = TimeEntryActivity.new(:name => 'Custom Data')
|
|
|
|
|
e.custom_field_values = {field.id => "1"}
|
|
|
|
|
assert e.save
|
|
|
|
|
|
|
|
|
|
e.reload
|
|
|
|
|
assert_equal "1", e.custom_value_for(field).value
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def test_create_without_required_custom_field_should_fail
|
2012-01-28 11:16:58 +00:00
|
|
|
set_language_if_valid 'en'
|
2009-10-21 22:34:22 +00:00
|
|
|
field = TimeEntryActivityCustomField.find_by_name('Billable')
|
|
|
|
|
field.update_attribute(:is_required, true)
|
|
|
|
|
|
|
|
|
|
e = TimeEntryActivity.new(:name => 'Custom Data')
|
|
|
|
|
assert !e.save
|
2014-12-21 12:39:48 +00:00
|
|
|
assert_equal ["Billable cannot be blank"], e.errors.full_messages
|
2009-10-21 22:34:22 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def test_create_with_required_custom_field_should_succeed
|
|
|
|
|
field = TimeEntryActivityCustomField.find_by_name('Billable')
|
|
|
|
|
field.update_attribute(:is_required, true)
|
|
|
|
|
|
|
|
|
|
e = TimeEntryActivity.new(:name => 'Custom Data')
|
|
|
|
|
e.custom_field_values = {field.id => "1"}
|
|
|
|
|
assert e.save
|
|
|
|
|
end
|
|
|
|
|
|
2012-01-28 11:16:58 +00:00
|
|
|
def test_update_with_required_custom_field_change
|
|
|
|
|
set_language_if_valid 'en'
|
2009-10-21 22:34:22 +00:00
|
|
|
field = TimeEntryActivityCustomField.find_by_name('Billable')
|
|
|
|
|
field.update_attribute(:is_required, true)
|
|
|
|
|
|
|
|
|
|
e = TimeEntryActivity.find(10)
|
|
|
|
|
assert e.available_custom_fields.include?(field)
|
|
|
|
|
# No change to custom field, record can be saved
|
|
|
|
|
assert e.save
|
|
|
|
|
# Blanking custom field, save should fail
|
|
|
|
|
e.custom_field_values = {field.id => ""}
|
|
|
|
|
assert !e.save
|
2014-12-21 12:39:48 +00:00
|
|
|
assert_equal ["Billable cannot be blank"], e.errors.full_messages
|
2011-08-30 05:50:24 +00:00
|
|
|
|
2009-10-21 22:34:22 +00:00
|
|
|
# Update custom field to valid value, save should succeed
|
|
|
|
|
e.custom_field_values = {field.id => "0"}
|
|
|
|
|
assert e.save
|
|
|
|
|
e.reload
|
|
|
|
|
assert_equal "0", e.custom_value_for(field).value
|
|
|
|
|
end
|
2009-05-30 23:30:36 +00:00
|
|
|
|
2013-05-01 17:10:15 +00:00
|
|
|
def test_system_activity_with_child_in_use_should_be_in_use
|
|
|
|
|
project = Project.generate!
|
|
|
|
|
system_activity = TimeEntryActivity.create!(:name => 'Activity')
|
2020-12-10 13:34:46 +00:00
|
|
|
project_activity =
|
|
|
|
|
TimeEntryActivity.create!(:name => 'Activity', :project => project,
|
|
|
|
|
:parent_id => system_activity.id)
|
2013-05-01 17:10:15 +00:00
|
|
|
TimeEntry.generate!(:project => project, :activity => project_activity)
|
|
|
|
|
|
|
|
|
|
assert project_activity.in_use?
|
|
|
|
|
assert system_activity.in_use?
|
|
|
|
|
end
|
|
|
|
|
|
|
|
|
|
def test_destroying_a_system_activity_should_reassign_children_activities
|
|
|
|
|
project = Project.generate!
|
2015-05-30 09:41:58 +00:00
|
|
|
entries = []
|
2013-05-01 17:10:15 +00:00
|
|
|
system_activity = TimeEntryActivity.create!(:name => 'Activity')
|
2015-05-30 09:41:58 +00:00
|
|
|
entries << TimeEntry.generate!(:project => project, :activity => system_activity)
|
2020-12-10 13:34:46 +00:00
|
|
|
project_activity =
|
|
|
|
|
TimeEntryActivity.create!(:name => 'Activity', :project => project,
|
|
|
|
|
:parent_id => system_activity.id)
|
2015-05-30 09:41:58 +00:00
|
|
|
entries << TimeEntry.generate!(:project => project.reload, :activity => project_activity)
|
2013-05-01 17:10:15 +00:00
|
|
|
assert_difference 'TimeEntryActivity.count', -2 do
|
|
|
|
|
assert_nothing_raised do
|
|
|
|
|
assert system_activity.destroy(TimeEntryActivity.find_by_name('Development'))
|
|
|
|
|
end
|
|
|
|
|
end
|
|
|
|
|
assert entries.all? {|entry| entry.reload.activity.name == 'Development'}
|
|
|
|
|
end
|
2015-05-30 10:05:43 +00:00
|
|
|
|
|
|
|
|
def test_project_activity_without_parent_should_not_disable_system_activities
|
|
|
|
|
project = Project.find(1)
|
|
|
|
|
activity = TimeEntryActivity.create!(:name => 'Csutom', :project => project)
|
|
|
|
|
assert_include activity, project.activities
|
|
|
|
|
assert_include TimeEntryActivity.find(9), project.activities
|
|
|
|
|
end
|
2020-09-22 07:50:46 +00:00
|
|
|
|
|
|
|
|
def test_project_activity_should_have_the_same_position_as_parent_activity
|
|
|
|
|
project = Project.find(1)
|
|
|
|
|
|
|
|
|
|
parent_activity = TimeEntryActivity.find_by(position: 3, parent_id: nil)
|
2020-12-10 13:34:46 +00:00
|
|
|
project.update_or_create_time_entry_activities(
|
|
|
|
|
{
|
|
|
|
|
parent_activity.id.to_s => {
|
|
|
|
|
'parent_id' => parent_activity.id.to_s,
|
|
|
|
|
'active' => '0',
|
|
|
|
|
'custom_field_values' => {'7' => ''}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
)
|
2020-09-22 07:50:46 +00:00
|
|
|
project_activity = TimeEntryActivity.find_by(position: 3, parent_id: parent_activity.id, project_id: 1)
|
|
|
|
|
assert_equal parent_activity.position, project_activity.position
|
|
|
|
|
|
|
|
|
|
# Changing the position of the parent activity also changes the position of the activity in each project.
|
|
|
|
|
other_parent_activity = TimeEntryActivity.find_by(position: 4, parent_id: nil)
|
2020-12-10 13:34:46 +00:00
|
|
|
project.update_or_create_time_entry_activities(
|
|
|
|
|
{
|
|
|
|
|
other_parent_activity.id.to_s => {
|
|
|
|
|
'parent_id' => other_parent_activity.id.to_s,
|
|
|
|
|
'active' => '0',
|
|
|
|
|
'custom_field_values' => {'7' => ''}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
)
|
2020-09-22 07:50:46 +00:00
|
|
|
other_project_activity = TimeEntryActivity.find_by(position: 4, parent_id: other_parent_activity.id, project_id: 1)
|
|
|
|
|
|
|
|
|
|
parent_activity.update(position: 4)
|
|
|
|
|
assert_equal 4, parent_activity.reload.position
|
|
|
|
|
assert_equal parent_activity.position, project_activity.reload.position
|
|
|
|
|
assert_equal 3, other_parent_activity.reload.position
|
|
|
|
|
assert_equal other_parent_activity.position, other_project_activity.reload.position
|
|
|
|
|
end
|
2021-06-30 02:39:18 +00:00
|
|
|
|
|
|
|
|
def test_project_activity_should_have_the_same_name_as_parent_activity
|
|
|
|
|
parent_activity = TimeEntryActivity.find_by(name: 'Design', parent_id: nil)
|
|
|
|
|
project = Project.find(1)
|
|
|
|
|
project.update_or_create_time_entry_activities(
|
|
|
|
|
{
|
|
|
|
|
parent_activity.id.to_s => {
|
|
|
|
|
'parent_id' => parent_activity.id.to_s,
|
|
|
|
|
'active' => '0',
|
|
|
|
|
'custom_field_values' => {'7' => ''}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
)
|
|
|
|
|
project_activity = TimeEntryActivity.find_by(name: 'Design', parent_id: parent_activity.id, project_id: project.id)
|
|
|
|
|
assert_equal parent_activity.name, project_activity.name
|
|
|
|
|
|
|
|
|
|
parent_activity.update(name: 'Design1')
|
|
|
|
|
assert_equal parent_activity.reload.name, project_activity.reload.name
|
|
|
|
|
|
|
|
|
|
# When changing the name of parent_activity,
|
|
|
|
|
# if the name of parent_activity before the change and the name of project_activity do not match, the name of project_activity is not changed.
|
|
|
|
|
project_activity.update(name: 'Design2')
|
|
|
|
|
parent_activity.update(name: 'Design3')
|
|
|
|
|
assert_equal 'Design2', project_activity.reload.name
|
|
|
|
|
assert_equal 'Design3', parent_activity.reload.name
|
|
|
|
|
end
|
2013-05-01 17:10:15 +00:00
|
|
|
end
|