mirror of
https://github.com/NodeBB/NodeBB.git
synced 2025-11-17 03:01:08 +01:00
* feat: webpack 5 part 1 * fix: gruntfile fixes * fix: fix taskbar warning add app.importScript copy public/src/modules to build folder * refactor: remove commented old code * feat: reenable admin * fix: acp settings pages, fix sortable on manage categories embedded require in html not allowed * fix: bundle serialize/deserizeli so plugins dont break * test: fixe util tests * test: fix require path * test: more test fixes * test: require correct utils module * test: require correct utils * test: log stack * test: fix db require blowing up tests * test: move and disable bundle test * refactor: add aliases * test: disable testing route * fix: move webpack modules necessary for build, into `dependencies` * test: fix one more test remove 500-embed.tpl * fix: restore use of assets/nodebb.min.js, at least for now * fix: remove unnecessary line break * fix: point to proper ACP bundle * test: maybe fix build test * test: composer * refactor: dont need dist * refactor: more cleanup use everything from build/public folder * get rid of conditional import in app.js * fix: ace * refactor: cropper alias * test: lint and test fixes * lint: fix * refactor: rename function to app.require * refactor: go back to using app.require * chore: use github branch * chore: use webpack branch * feat: webpack webinstaller * feat: add chunkFile name with contenthash * refactor: move hooks to top * refactor: get rid of template500Function * fix(deps): use webpack5 branch of 2factor plugin * chore: tagging v2.0.0-beta.0 pre-release version 💥 :shipit: 🎉 🚀 * refactor: disable cache on templates loadTemplate is called once by benchpress and the result is cache internally * refactor: add server side helpers.js * feat: deprecate /plugins shorthand route, closes #10343 * refactor: use build/public for webpack * test: fix filename * fix: more specific selector * lint: ignore * refactor: fix comments * test: add debug for random failing test * refactor: cleanup remove test page, remove dupe functions in utils.common * lint: use relative path for now * chore: bump prerelease version * feat: add translateKeys * fix: optional params * fix: get rid of extra timeago files * refactor: cleanup, require timeago locale earlier remove translator.prepareDOM, it is in header.tpl html tag * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378) * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels - Existing hooks are preserved (to be deprecated at a later date, possibly) - New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks * docs: fix typo in comment * test: spec changes * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378) * refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels - Existing hooks are preserved (to be deprecated at a later date, possibly) - New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks * docs: fix typo in comment * test: spec changes * feat: allow app.require('bootbox'/'benchpressjs') * refactor: require server side utils * test: jquery ready * change istaller to use build/public * test: use document.addEventListener * refactor: closes #10301 * refactor: generateTopicClass * fix: column counts for other privileges * fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking] * fix: typo in hook name * refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags) * fix: crash if `delay` not passed in (as it cannot be destructured) * refactor: replace substr * feat: set --panel-offset style in html element based on stored value in localStorage * refactor: addDropupHandler() logic to be less naive - Take into account height of the menu - Don't apply dropUp logic if there's nothing in the dropdown - Remove 'hidden' class (added by default in Persona for post tools) when menu items are added closes #10423 * refactor: simplify utils.params [breaking] Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do. * feat: add support for returning full URLSearchParams for utils.params * fix: utils.params() fallback handling * fix: default empty obj for params() * fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end * fix: utils.params() not allowing relative paths to be passed in * refactor(DRY): new assertPasswordValidity utils method * fix: incorrect error message returned on insufficient privilege on flag edit * fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate - added failing tests and patched up middleware.assert.flags to fix * refactor: flag api v3 tests to create new post and flags on every round * fix: missing error:no-flag language key * refactor: flags.canView to check flag existence, simplify middleware.assert.flag * feat: flag deletion API endpoint, #10426 * feat: UI for flag deletion, closes #10426 * chore: update plugin versions * chore: up emoji * chore: update markdown * chore: up emoji-android * fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check Co-authored-by: Julian Lam <julian@nodebb.org>
240 lines
7.3 KiB
JavaScript
240 lines
7.3 KiB
JavaScript
'use strict';
|
|
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
const mkdirp = require('mkdirp');
|
|
const rimraf = require('rimraf');
|
|
const async = require('async');
|
|
|
|
const db = require('./mocks/databasemock');
|
|
const file = require('../src/file');
|
|
const helpers = require('./helpers');
|
|
|
|
describe('minifier', () => {
|
|
before(async () => {
|
|
await mkdirp(path.join(__dirname, '../build/test'));
|
|
});
|
|
|
|
const minifier = require('../src/meta/minifier');
|
|
const scripts = [
|
|
path.resolve(__dirname, './files/1.js'),
|
|
path.resolve(__dirname, './files/2.js'),
|
|
].map(script => ({
|
|
srcPath: script,
|
|
destPath: path.resolve(__dirname, '../build/test', path.basename(script)),
|
|
filename: path.basename(script),
|
|
}));
|
|
|
|
it('.js.bundle() should concat scripts', (done) => {
|
|
const destPath = path.resolve(__dirname, '../build/test/concatenated.js');
|
|
|
|
minifier.js.bundle({
|
|
files: scripts,
|
|
destPath: destPath,
|
|
filename: 'concatenated.js',
|
|
}, false, false, (err) => {
|
|
assert.ifError(err);
|
|
|
|
assert(file.existsSync(destPath));
|
|
|
|
assert.strictEqual(
|
|
fs.readFileSync(destPath).toString().replace(/\r\n/g, '\n'),
|
|
'(function (window, document) {' +
|
|
'\n\twindow.doStuff = function () {' +
|
|
'\n\t\tdocument.body.innerHTML = \'Stuff has been done\';' +
|
|
'\n\t};' +
|
|
'\n})(window, document);' +
|
|
'\n' +
|
|
'\n;function foo(name, age) {' +
|
|
'\n\treturn \'The person known as "\' + name + \'" is \' + age + \' years old\';' +
|
|
'\n}' +
|
|
'\n'
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
it('.js.bundle() should minify scripts', (done) => {
|
|
const destPath = path.resolve(__dirname, '../build/test/minified.js');
|
|
|
|
minifier.js.bundle({
|
|
files: scripts,
|
|
destPath: destPath,
|
|
filename: 'minified.js',
|
|
}, true, false, (err) => {
|
|
assert.ifError(err);
|
|
|
|
assert(file.existsSync(destPath));
|
|
|
|
assert.strictEqual(
|
|
fs.readFileSync(destPath).toString(),
|
|
'(function(n,o){n.doStuff=function(){o.body.innerHTML="Stuff has been done"}})(window,document);function foo(n,o){return\'The person known as "\'+n+\'" is \'+o+" years old"}' +
|
|
'\n//# sourceMappingURL=minified.js.map'
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('.js.minifyBatch() should minify each script', (done) => {
|
|
minifier.js.minifyBatch(scripts, false, (err) => {
|
|
assert.ifError(err);
|
|
|
|
assert(file.existsSync(scripts[0].destPath));
|
|
assert(file.existsSync(scripts[1].destPath));
|
|
|
|
fs.readFile(scripts[0].destPath, (err, buffer) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(
|
|
buffer.toString(),
|
|
'(function(n,o){n.doStuff=function(){o.body.innerHTML="Stuff has been done"}})(window,document);' +
|
|
'\n//# sourceMappingURL=1.js.map'
|
|
);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
const styles = [
|
|
'@import (inline) "./1.css";',
|
|
'@import "./2.less";',
|
|
].join('\n');
|
|
const paths = [
|
|
path.resolve(__dirname, './files'),
|
|
];
|
|
it('.css.bundle() should concat styles', (done) => {
|
|
minifier.css.bundle(styles, paths, false, false, (err, bundle) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(bundle.code, '.help { margin: 10px; } .yellow { background: yellow; }\n.help {\n display: block;\n}\n.help .blue {\n background: blue;\n}\n');
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('.css.bundle() should minify styles', (done) => {
|
|
minifier.css.bundle(styles, paths, true, false, (err, bundle) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(bundle.code, '.help{margin:10px}.yellow{background:#ff0}.help{display:block}.help .blue{background:#00f}');
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('Build', () => {
|
|
const build = require('../src/meta/build');
|
|
|
|
before((done) => {
|
|
async.parallel([
|
|
async.apply(rimraf, path.join(__dirname, '../build/public')),
|
|
async.apply(db.sortedSetAdd, 'plugins:active', Date.now(), 'nodebb-plugin-markdown'),
|
|
], done);
|
|
});
|
|
|
|
it('should build plugin static dirs', (done) => {
|
|
build.build(['plugin static dirs'], (err) => {
|
|
assert.ifError(err);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should build requirejs modules', (done) => {
|
|
build.build(['requirejs modules'], (err) => {
|
|
assert.ifError(err);
|
|
const filename = path.join(__dirname, '../build/public/src/modules/alerts.js');
|
|
assert(file.existsSync(filename));
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should build client js bundle', (done) => {
|
|
build.build(['client js bundle'], (err) => {
|
|
assert.ifError(err);
|
|
const filename = path.join(__dirname, '../build/public/scripts-client.js');
|
|
assert(file.existsSync(filename));
|
|
assert(fs.readFileSync(filename).length > 1000);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should build admin js bundle', (done) => {
|
|
build.build(['admin js bundle'], (err) => {
|
|
assert.ifError(err);
|
|
const filename = path.join(__dirname, '../build/public/scripts-admin.js');
|
|
assert(file.existsSync(filename));
|
|
assert(fs.readFileSync(filename).length > 1000);
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should build client side styles', (done) => {
|
|
build.build(['client side styles'], (err) => {
|
|
assert.ifError(err);
|
|
const filename = path.join(__dirname, '../build/public/client.css');
|
|
assert(file.existsSync(filename));
|
|
assert(fs.readFileSync(filename).toString().startsWith('/*! normalize.css'));
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should build admin control panel styles', (done) => {
|
|
build.build(['admin control panel styles'], (err) => {
|
|
assert.ifError(err);
|
|
const filename = path.join(__dirname, '../build/public/admin.css');
|
|
assert(file.existsSync(filename));
|
|
const adminCSS = fs.readFileSync(filename).toString();
|
|
if (global.env === 'production') {
|
|
assert(adminCSS.startsWith('@charset "UTF-8";') || adminCSS.startsWith('@import url'));
|
|
} else {
|
|
assert(adminCSS.startsWith('.recent-replies'));
|
|
}
|
|
done();
|
|
});
|
|
});
|
|
|
|
|
|
/* disabled, doesn't work on gh actions in prod mode
|
|
it('should build bundle files', function (done) {
|
|
this.timeout(0);
|
|
build.buildAll(async (err) => {
|
|
assert.ifError(err);
|
|
assert(file.existsSync(path.join(__dirname, '../build/webpack/nodebb.min.js')));
|
|
assert(file.existsSync(path.join(__dirname, '../build/webpack/admin.min.js')));
|
|
let { res, body } = await helpers.request('GET', `/assets/nodebb.min.js`, {});
|
|
assert(res.statusCode, 200);
|
|
assert(body);
|
|
({ res, body } = await helpers.request('GET', `/assets/admin.min.js`, {}));
|
|
assert(res.statusCode, 200);
|
|
assert(body);
|
|
done();
|
|
});
|
|
});
|
|
*/
|
|
|
|
it('should build templates', function (done) {
|
|
this.timeout(0);
|
|
build.build(['templates'], (err) => {
|
|
assert.ifError(err);
|
|
const filename = path.join(__dirname, '../build/public/templates/admin/header.tpl');
|
|
assert(file.existsSync(filename));
|
|
assert(fs.readFileSync(filename).toString().startsWith('<!DOCTYPE html>'));
|
|
done();
|
|
});
|
|
});
|
|
|
|
it('should build languages', (done) => {
|
|
build.build(['languages'], (err) => {
|
|
assert.ifError(err);
|
|
|
|
const globalFile = path.join(__dirname, '../build/public/language/en-GB/global.json');
|
|
assert(file.existsSync(globalFile), 'global.json exists');
|
|
const global = fs.readFileSync(globalFile).toString();
|
|
assert.strictEqual(JSON.parse(global).home, 'Home', 'global.json contains correct translations');
|
|
|
|
const mdFile = path.join(__dirname, '../build/public/language/en-GB/markdown.json');
|
|
assert(file.existsSync(mdFile), 'markdown.json exists');
|
|
const md = fs.readFileSync(mdFile).toString();
|
|
assert.strictEqual(JSON.parse(md).bold, 'bolded text', 'markdown.json contains correct translations');
|
|
|
|
done();
|
|
});
|
|
});
|
|
});
|