mirror of
https://github.com/NodeBB/NodeBB.git
synced 2025-10-27 09:06:15 +01:00
* chore: up deps * chore: up composer * fix(deps): bump 2factor to v7 * chore: up harmony * chore: up harmony * fix: missing await * feat: allow middlewares to pass in template values via res.locals * feat: buildAccountData middleware automatically added ot all account routes * fix: properly allow values in res.locals.templateValues to be added to the template data * refactor: user/blocks * refactor(accounts): categories and consent * feat: automatically 404 if exposeUid or exposeGroupName come up empty * refactor: remove calls to getUserDataByUserSlug for most account routes, since it is populated via middleware now * fix: allow exposeUid and exposeGroupName to work with slugs with mixed capitalization * fix: move reputation removal check to accountHelpers method * test: skip i18n tests if ref branch when present is not develop * fix(deps): bump theme versions * fix(deps): bump ntfy and 2factor * chore: up harmony * fix: add missing return * fix: #11191, only focus on search input on md environments and up * feat: allow file uploads on mobile chat closes https://github.com/NodeBB/NodeBB/issues/11217 * chore: up themes * chore: add lang string * fix(deps): bump ntfy to 1.0.15 * refactor: use new if/each syntax * chore: up composer * fix: regression from user helper refactor * chore: up harmony * chore: up composer * chore: up harmony * chore: up harmony * chore: up harmony * chore: fix composer version * feat: add increment helper * chore: up harmony * fix: #11228 no timestamps in future ⌛ * chore: up harmony * check config.theme as well fire action:posts.loaded after processing dom * chore: up harmony * chore: up harmony * chore: up harmony * chore: up themes * chore: up harmony * remove extra class * refactor: move these to core from harmony * chore: up widgets * chore: up widgets * height auto * fix: closes #11238 * dont focus inputs, annoying on mobile * fix: dont focus twice, only focus on chat input on desktop dont wrap widget footer in row * chore: up harmony * chore: up harmony * update chat window * chore: up themes * fix cache buster for skins * chat fixes * chore: up harmony * chore: up composer * refactor: change hook logs to debug * fix: scroll to post right after adding to dom * fix: hash scrolling and highlighting correct post * test: re-enable read API schema tests * fix: add back schema changes for179faa2270andc3920ccb10* fix: schema changes from488f0978a4* fix: schema changes forf4cf482a87* fix: schema update forbe6bbabd0e* fix: schema changes for69c96078ea* fix: schema changes ford1364c3130* fix: schema changes for84ff1152f7* fix: schema changes forb860c2605c* fix: schema changes for23cb67a112* fix: schema changes forb916e42f40* fix: schema change fora9bbb586fc* fix: schema changes for4b738c8cd3* fix: schema changes for58b5781cea* fix: schema changes for794bf01b21* fix: schema changes for80ea12c1c1,e368feef51, and52ead114be* fix: composer-default object in config? * fix: schema changes for9acdc6808cand0930934200* fix: schema changes forc0a52924f1* fix: schema change foraba420a3f3, move loggedInUser to optional props * fix: schema changes for8c67031609* fix: schema changes for27e53b42f3* fix: schema changes for2835966518* fix: breaking test for email confirmation API call * fix: schema changes for refactored search page * fix: schema changes for user object * fix: schema changes for9f531f957e* fix: schema changes forc4042c70deand23175110a2* fix: schema changes for9b3616b103* fix: schema changes for5afd5de07d* fix: schema change for1d7baf1217* fix: schema changes for57bfb37c55andbe6bbabd0e* fix: schema changes for6e86b4afa2and3efad2e13band68f66223e7* fix: allowing optional qs prop in pagination keys (not sure why this didn't break before) * fix: re-login on email change * fix: schema changes forc926358d73* fix: schema changes for388a8270c9* fix: schema change for2658bcc821* fix: no need to call account middlewares for chats routes * fix: schema changes for71743affc3* fix: final schema changes * test: support for anyOf and oneOf * fix: check thumb * dont scroll to top on back press * remove group log * fix: add top margin to merged and deleted alerts * chore: up widgets * fix: improve fix-lists mixin * chore: up harmony/composer * feat: allow hiding quicksearch results during search * dont record searches made by composer * chore: up 54 * chore: up spam be gone * feat: add prev/next page and page count into mobile paginator * chore: up harmony * chore: up harmony * use old style for IS * fix: hide entire toolbar row if no posts or not singlePost * fix: updated messaging for post-queue template, #11206 * fix: btn-sm on post queue back button * fix: bump harmony, closes #11206 * fix: remove unused alert module import * fix: bump harmony * fix: bump harmony * chore: up harmony * refactor: IS scrolltop * fix: update users:search-user-for-chat source string * feat: support for mark-read toggle on chats dropdown and recent chats list * feat: api v3 calls to mark chat read/unread * feat: send event:chats.mark socket event on mark read or unread * refactor: allow frontend to mark chats as unread, use new API v3 routes instead of socket calls, better frontend event handling * docs: openapi schema updates for chat marking * fix: allow unread state toggling in chats dropdown too * fix: issue where repeated openings of the chats dropdown would continually add events for mark-read/unread * fix: debug log * refactor: move userSearch filter to a module * feat(routes): allow remounting /categories (#11230) * feat: send flags count to frontend on flags list page * refactor: filter form client-side js to extract out some logic * fix: applyFilters to not take any arguments, update selectedCids in updateButton instead of onHidden * fix: use userFilter module for assignee, reporterId, targetUid * fix(openapi): schema changes for updated flags page * fix: dont allow adding duplicates to userFilter * use same var * remove log * fix: closes #11282 * feat: lang key for x-topics * chore: up harmony * chore: up emoji * chore: up harmony * fix: update userFilter to allow new option `selectedBlock` * fix: wrong block name passed to userFilter * fix: https://github.com/NodeBB/NodeBB/issues/11283 * fix: chats, allow multiple dropdowns like in harmony * chore: up harmony * refactor: flag note adding/editing, closes #11285 * fix: remove old prepareEdit logic * chore: add caveat about hacky code block in userFilter module * fix: placeholders for userFilter module * refactor: navigator so it works with multiple thumbs/navigators * chore: up harmony * fix: closes #11287, destroy quick reply autocomplete on navigation * fix: filter disabled categories on user categories page count * chore: up harmony * docs: update openapi spec to include info about passing in timestamps for topic creation, removing timestamp as valid request param for topic replying * fix: send back null values on ACP search dashboard for startDate and endDate if not expicitly passed in, fix tests * fix: tweak table order in ACP dash searches * fix: only invoke navigator click drag on left mouse button * feat: add back unread indicator to navigator * clear bookmark on mark unread * fix: navigator crash on ajaxify * better thumb top calculation * fix: reset user bookmark when topic is marked unread * Revert "fix: reset user bookmark when topic is marked unread" This reverts commit9bcd85c2c6. * fix: update unread indicator on scroll, add unread count * chore: bump harmony * fix: crash on navigator unread update when backing out of a topic * fix: closes #11183 * fix: update topics:recent zset when rescheduling a topic * fix: dupe quote button, increase delay, hide immediately on empty selection * fix: navigator not showing up on first load * refactor: remove glance assorted fixes to navigator dont reduce remaning count if user scrolls down and up quickly only call topic.navigatorCallback when index changes * more sanity checks for bookmark dont allow setting bookmark higher than topic postcount * closes #11218, 🚋 * Revert "fix: update topics:recent zset when rescheduling a topic" This reverts commit737973cca9. * fix: #11306, show proper error if queued post doesn't exist was showing no-privileges if someone else accepted the post * https://github.com/NodeBB/NodeBB/issues/11307 dont use li * chore: up harmony * chore: bump version string * fix: copy paste fail * feat: closes #7382, tag filtering add client side support for filtering by tags on /category, /recent and /unread * chore: up harmony * chore: up harmony * Revert "fix: add back req.query fallback for backwards compatibility" [breaking] This reverts commitcf6cc2c454. This commit is no longer required as passing in a CSRF token via query parameter is no longer supported as of NodeBB v3.x This is a breaking change. * fix: pass csrf token in form data, re: NodeBB/NodeBB#11309 * chore: up deps * fix: tests, use x-csrf-token query param removed * test: fix csrf_token * lint: remove unused * feat: add itemprop="image" to avatar helper * fix: get chat upload button in chat modal * breaking: remove deprecated socket.io methods * test: update messaging tests to not use sockets * fix: parent post links * fix: prevent post tooltip if mouse leaves before data/tpl is loaded * chore: up harmony * chore: up harmony * chore: up harmony * chore: up harmony * fix: nested replies indices * fix(deps): bump 2factor * feat: add loggedIn user to all api routes * chore: up themes * refactor: audit admin v3 write api routes as per #11321 * refactor: audit category v3 write api routes as per #11321 [breaking] docs: fix open api spec for #11321 * refactor: audit chat v3 write api routes as per #11321 * refactor: audit files v3 write api routes as per #11321 * refactor: audit flags v3 write api routes as per #11321 * refactor: audit posts v3 write api routes as per #11321 * refactor: audit topics v3 write api routes as per #11321 * refactor: audit users v3 write api routes as per #11321 * fix: lang string * remove min height * fix: empty topic/labels taking up space * fix: tag filtering when changing filter to watched topics or changing popular time limit to month * chore: up harmony * fix: closes #11354, show no post error if queued post already accepted/rejected * test: #11354 * test: #11354 * fix(deps): bump 2factor * fix: #11357 clear cache on thumb remove * fix: thumb remove on windows, closes #11357 * test: openapi for thumbs * test: fix openapi --------- Co-authored-by: Julian Lam <julian@nodebb.org> Co-authored-by: Opliko <opliko.reg@protonmail.com>
370 lines
11 KiB
JavaScript
370 lines
11 KiB
JavaScript
'use strict';
|
|
|
|
const _ = require('lodash');
|
|
const validator = require('validator');
|
|
const nconf = require('nconf');
|
|
|
|
const db = require('../database');
|
|
const user = require('../user');
|
|
const meta = require('../meta');
|
|
const groups = require('../groups');
|
|
const topics = require('../topics');
|
|
const categories = require('../categories');
|
|
const notifications = require('../notifications');
|
|
const privileges = require('../privileges');
|
|
const plugins = require('../plugins');
|
|
const utils = require('../utils');
|
|
const cache = require('../cache');
|
|
const socketHelpers = require('../socket.io/helpers');
|
|
|
|
module.exports = function (Posts) {
|
|
Posts.getQueuedPosts = async (filter = {}, options = {}) => {
|
|
options = { metadata: true, ...options }; // defaults
|
|
let postData = _.cloneDeep(cache.get('post-queue'));
|
|
if (!postData) {
|
|
const ids = await db.getSortedSetRange('post:queue', 0, -1);
|
|
const keys = ids.map(id => `post:queue:${id}`);
|
|
postData = await db.getObjects(keys);
|
|
postData.forEach((data) => {
|
|
if (data) {
|
|
data.data = JSON.parse(data.data);
|
|
data.data.timestampISO = utils.toISOString(data.data.timestamp);
|
|
}
|
|
});
|
|
const uids = postData.map(data => data && data.uid);
|
|
const userData = await user.getUsersFields(uids, ['username', 'userslug', 'picture']);
|
|
postData.forEach((postData, index) => {
|
|
if (postData) {
|
|
postData.user = userData[index];
|
|
postData.data.rawContent = validator.escape(String(postData.data.content));
|
|
postData.data.title = validator.escape(String(postData.data.title || ''));
|
|
}
|
|
});
|
|
cache.set('post-queue', _.cloneDeep(postData));
|
|
}
|
|
if (filter.id) {
|
|
postData = postData.filter(p => p.id === filter.id);
|
|
}
|
|
if (options.metadata) {
|
|
await Promise.all(postData.map(p => addMetaData(p)));
|
|
}
|
|
|
|
// Filter by tid if present
|
|
if (utils.isNumber(filter.tid)) {
|
|
const tid = parseInt(filter.tid, 10);
|
|
postData = postData.filter(item => item.data.tid && parseInt(item.data.tid, 10) === tid);
|
|
} else if (Array.isArray(filter.tid)) {
|
|
const tids = filter.tid.map(tid => parseInt(tid, 10));
|
|
postData = postData.filter(
|
|
item => item.data.tid && tids.includes(parseInt(item.data.tid, 10))
|
|
);
|
|
}
|
|
|
|
return postData;
|
|
};
|
|
|
|
async function addMetaData(postData) {
|
|
if (!postData) {
|
|
return;
|
|
}
|
|
postData.topic = { cid: 0 };
|
|
if (postData.data.cid) {
|
|
postData.topic = { cid: parseInt(postData.data.cid, 10) };
|
|
} else if (postData.data.tid) {
|
|
postData.topic = await topics.getTopicFields(postData.data.tid, ['title', 'cid']);
|
|
}
|
|
postData.category = await categories.getCategoryData(postData.topic.cid);
|
|
const result = await plugins.hooks.fire('filter:parse.post', { postData: postData.data });
|
|
postData.data.content = result.postData.content;
|
|
}
|
|
|
|
Posts.shouldQueue = async function (uid, data) {
|
|
const [userData, isMemberOfExempt, categoryQueueEnabled] = await Promise.all([
|
|
user.getUserFields(uid, ['uid', 'reputation', 'postcount']),
|
|
groups.isMemberOfAny(uid, meta.config.groupsExemptFromPostQueue),
|
|
isCategoryQueueEnabled(data),
|
|
]);
|
|
|
|
const shouldQueue = meta.config.postQueue && categoryQueueEnabled &&
|
|
!isMemberOfExempt &&
|
|
(!userData.uid || userData.reputation < meta.config.postQueueReputationThreshold || userData.postcount <= 0);
|
|
const result = await plugins.hooks.fire('filter:post.shouldQueue', {
|
|
shouldQueue: !!shouldQueue,
|
|
uid: uid,
|
|
data: data,
|
|
});
|
|
return result.shouldQueue;
|
|
};
|
|
|
|
async function isCategoryQueueEnabled(data) {
|
|
const type = getType(data);
|
|
const cid = await getCid(type, data);
|
|
if (!cid) {
|
|
throw new Error('[[error:invalid-cid]]');
|
|
}
|
|
return await categories.getCategoryField(cid, 'postQueue');
|
|
}
|
|
|
|
function getType(data) {
|
|
if (data.hasOwnProperty('tid')) {
|
|
return 'reply';
|
|
} else if (data.hasOwnProperty('cid')) {
|
|
return 'topic';
|
|
}
|
|
throw new Error('[[error:invalid-type]]');
|
|
}
|
|
|
|
async function removeQueueNotification(id) {
|
|
await notifications.rescind(`post-queue-${id}`);
|
|
const data = await getParsedObject(id);
|
|
if (!data) {
|
|
return;
|
|
}
|
|
const cid = await getCid(data.type, data);
|
|
const uids = await getNotificationUids(cid);
|
|
uids.forEach(uid => user.notifications.pushCount(uid));
|
|
}
|
|
|
|
async function getNotificationUids(cid) {
|
|
const results = await Promise.all([
|
|
groups.getMembersOfGroups(['administrators', 'Global Moderators']),
|
|
categories.getModeratorUids([cid]),
|
|
]);
|
|
return _.uniq(_.flattenDeep(results));
|
|
}
|
|
|
|
Posts.addToQueue = async function (data) {
|
|
const type = getType(data);
|
|
const now = Date.now();
|
|
const id = `${type}-${now}`;
|
|
await canPost(type, data);
|
|
|
|
let payload = {
|
|
id: id,
|
|
uid: data.uid,
|
|
type: type,
|
|
data: data,
|
|
};
|
|
payload = await plugins.hooks.fire('filter:post-queue.save', payload);
|
|
payload.data = JSON.stringify(data);
|
|
|
|
await db.sortedSetAdd('post:queue', now, id);
|
|
await db.setObject(`post:queue:${id}`, payload);
|
|
await user.setUserField(data.uid, 'lastqueuetime', now);
|
|
cache.del('post-queue');
|
|
|
|
const cid = await getCid(type, data);
|
|
const uids = await getNotificationUids(cid);
|
|
const bodyLong = await parseBodyLong(cid, type, data);
|
|
|
|
const notifObj = await notifications.create({
|
|
type: 'post-queue',
|
|
nid: `post-queue-${id}`,
|
|
mergeId: 'post-queue',
|
|
bodyShort: '[[notifications:post_awaiting_review]]',
|
|
bodyLong: bodyLong,
|
|
path: `/post-queue/${id}`,
|
|
});
|
|
await notifications.push(notifObj, uids);
|
|
return {
|
|
id: id,
|
|
type: type,
|
|
queued: true,
|
|
message: '[[success:post-queued]]',
|
|
};
|
|
};
|
|
|
|
async function parseBodyLong(cid, type, data) {
|
|
const url = nconf.get('url');
|
|
const [content, category, userData] = await Promise.all([
|
|
plugins.hooks.fire('filter:parse.raw', data.content),
|
|
categories.getCategoryFields(cid, ['name', 'slug']),
|
|
user.getUserFields(data.uid, ['uid', 'username']),
|
|
]);
|
|
|
|
category.url = `${url}/category/${category.slug}`;
|
|
if (userData.uid > 0) {
|
|
userData.url = `${url}/uid/${userData.uid}`;
|
|
}
|
|
|
|
const topic = { cid: cid, title: data.title, tid: data.tid };
|
|
if (type === 'reply') {
|
|
topic.title = await topics.getTopicField(data.tid, 'title');
|
|
topic.url = `${url}/topic/${data.tid}`;
|
|
}
|
|
const { app } = require('../webserver');
|
|
return await app.renderAsync('emails/partials/post-queue-body', {
|
|
content: content,
|
|
category: category,
|
|
user: userData,
|
|
topic: topic,
|
|
});
|
|
}
|
|
|
|
async function getCid(type, data) {
|
|
if (type === 'topic') {
|
|
return data.cid;
|
|
} else if (type === 'reply') {
|
|
return await topics.getTopicField(data.tid, 'cid');
|
|
}
|
|
return null;
|
|
}
|
|
|
|
async function canPost(type, data) {
|
|
const cid = await getCid(type, data);
|
|
const typeToPrivilege = {
|
|
topic: 'topics:create',
|
|
reply: 'topics:reply',
|
|
};
|
|
|
|
topics.checkContent(data.content);
|
|
if (type === 'topic') {
|
|
topics.checkTitle(data.title);
|
|
if (data.tags) {
|
|
await topics.validateTags(data.tags, cid, data.uid);
|
|
}
|
|
}
|
|
|
|
const [canPost] = await Promise.all([
|
|
privileges.categories.can(typeToPrivilege[type], cid, data.uid),
|
|
user.isReadyToQueue(data.uid, cid),
|
|
]);
|
|
if (!canPost) {
|
|
throw new Error('[[error:no-privileges]]');
|
|
}
|
|
}
|
|
|
|
Posts.removeFromQueue = async function (id) {
|
|
const data = await getParsedObject(id);
|
|
if (!data) {
|
|
return null;
|
|
}
|
|
const result = await plugins.hooks.fire('filter:post-queue:removeFromQueue', { data: data });
|
|
await removeFromQueue(id);
|
|
plugins.hooks.fire('action:post-queue:removeFromQueue', { data: result.data });
|
|
return result.data;
|
|
};
|
|
|
|
async function removeFromQueue(id) {
|
|
await removeQueueNotification(id);
|
|
await db.sortedSetRemove('post:queue', id);
|
|
await db.delete(`post:queue:${id}`);
|
|
cache.del('post-queue');
|
|
}
|
|
|
|
Posts.submitFromQueue = async function (id) {
|
|
let data = await getParsedObject(id);
|
|
if (!data) {
|
|
return null;
|
|
}
|
|
const result = await plugins.hooks.fire('filter:post-queue:submitFromQueue', { data: data });
|
|
data = result.data;
|
|
if (data.type === 'topic') {
|
|
const result = await createTopic(data.data);
|
|
data.pid = result.postData.pid;
|
|
} else if (data.type === 'reply') {
|
|
const result = await createReply(data.data);
|
|
data.pid = result.pid;
|
|
}
|
|
await removeFromQueue(id);
|
|
plugins.hooks.fire('action:post-queue:submitFromQueue', { data: data });
|
|
return data;
|
|
};
|
|
|
|
Posts.getFromQueue = async function (id) {
|
|
return await getParsedObject(id);
|
|
};
|
|
|
|
async function getParsedObject(id) {
|
|
const data = await db.getObject(`post:queue:${id}`);
|
|
if (!data) {
|
|
return null;
|
|
}
|
|
data.data = JSON.parse(data.data);
|
|
data.data.fromQueue = true;
|
|
return data;
|
|
}
|
|
|
|
async function createTopic(data) {
|
|
const result = await topics.post(data);
|
|
socketHelpers.notifyNew(data.uid, 'newTopic', { posts: [result.postData], topic: result.topicData });
|
|
return result;
|
|
}
|
|
|
|
async function createReply(data) {
|
|
const postData = await topics.reply(data);
|
|
const result = {
|
|
posts: [postData],
|
|
'reputation:disabled': !!meta.config['reputation:disabled'],
|
|
'downvote:disabled': !!meta.config['downvote:disabled'],
|
|
};
|
|
socketHelpers.notifyNew(data.uid, 'newPost', result);
|
|
return postData;
|
|
}
|
|
|
|
Posts.editQueuedContent = async function (uid, editData) {
|
|
const [canEditQueue, data] = await Promise.all([
|
|
Posts.canEditQueue(uid, editData, 'edit'),
|
|
getParsedObject(editData.id),
|
|
]);
|
|
if (!data) {
|
|
throw new Error('[[error:no-post]]');
|
|
}
|
|
if (!canEditQueue) {
|
|
throw new Error('[[error:no-privileges]]');
|
|
}
|
|
|
|
if (editData.content !== undefined) {
|
|
data.data.content = editData.content;
|
|
}
|
|
if (editData.title !== undefined) {
|
|
data.data.title = editData.title;
|
|
}
|
|
if (editData.cid !== undefined) {
|
|
data.data.cid = editData.cid;
|
|
}
|
|
await db.setObjectField(`post:queue:${editData.id}`, 'data', JSON.stringify(data.data));
|
|
cache.del('post-queue');
|
|
};
|
|
|
|
Posts.canEditQueue = async function (uid, editData, action) {
|
|
const [isAdminOrGlobalMod, data] = await Promise.all([
|
|
user.isAdminOrGlobalMod(uid),
|
|
getParsedObject(editData.id),
|
|
]);
|
|
if (!data) {
|
|
return false;
|
|
}
|
|
const selfPost = parseInt(uid, 10) === parseInt(data.uid, 10);
|
|
if (isAdminOrGlobalMod || ((action === 'reject' || action === 'edit') && selfPost)) {
|
|
return true;
|
|
}
|
|
|
|
let cid;
|
|
if (data.type === 'topic') {
|
|
cid = data.data.cid;
|
|
} else if (data.type === 'reply') {
|
|
cid = await topics.getTopicField(data.data.tid, 'cid');
|
|
}
|
|
const isModerator = await user.isModerator(uid, cid);
|
|
let isModeratorOfTargetCid = true;
|
|
if (editData.cid) {
|
|
isModeratorOfTargetCid = await user.isModerator(uid, editData.cid);
|
|
}
|
|
return isModerator && isModeratorOfTargetCid;
|
|
};
|
|
|
|
Posts.updateQueuedPostsTopic = async function (newTid, tids) {
|
|
const postData = await Posts.getQueuedPosts({ tid: tids }, { metadata: false });
|
|
if (postData.length) {
|
|
postData.forEach((post) => {
|
|
post.data.tid = newTid;
|
|
});
|
|
await db.setObjectBulk(
|
|
postData.map(p => [`post:queue:${p.id}`, { data: JSON.stringify(p.data) }]),
|
|
);
|
|
cache.del('post-queue');
|
|
}
|
|
};
|
|
};
|