Commit Graph

63 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
d20b07cfea Webpack5 (#10311)
* feat: webpack 5 part 1

* fix: gruntfile fixes

* fix: fix taskbar warning

add app.importScript
copy public/src/modules to build folder

* refactor: remove commented old code

* feat: reenable admin

* fix: acp settings pages, fix sortable on manage categories

embedded require in html not allowed

* fix: bundle serialize/deserizeli so plugins dont break

* test: fixe util tests

* test: fix require path

* test: more test fixes

* test: require correct utils module

* test: require correct utils

* test: log stack

* test: fix db require blowing up tests

* test: move and disable bundle test

* refactor: add aliases

* test: disable testing route

* fix: move webpack modules necessary for build, into `dependencies`

* test: fix one more test

remove 500-embed.tpl

* fix: restore use of assets/nodebb.min.js, at least for now

* fix: remove unnecessary line break

* fix: point to proper ACP bundle

* test: maybe fix build test

* test: composer

* refactor: dont need dist

* refactor: more cleanup

use everything from build/public folder

* get rid of conditional import in app.js

* fix: ace

* refactor: cropper alias

* test: lint and test fixes

* lint: fix

* refactor: rename function to app.require

* refactor: go back to using app.require

* chore: use github branch

* chore: use webpack branch

* feat: webpack webinstaller

* feat: add chunkFile name with contenthash

* refactor: move hooks to top

* refactor: get rid of template500Function

* fix(deps): use webpack5 branch of 2factor plugin

* chore: tagging v2.0.0-beta.0 pre-release version 💥 :shipit: 🎉 🚀

* refactor: disable cache on templates

loadTemplate is called once by benchpress and the result is cache internally

* refactor: add server side helpers.js

* feat: deprecate /plugins shorthand route, closes #10343

* refactor: use build/public for webpack

* test: fix filename

* fix: more specific selector

* lint: ignore

* refactor: fix comments

* test: add debug for random failing test

* refactor: cleanup

remove test page, remove dupe functions in utils.common

* lint: use relative path  for now

* chore: bump prerelease version

* feat: add translateKeys

* fix: optional params

* fix: get rid of extra timeago files

* refactor: cleanup, require timeago locale earlier

remove translator.prepareDOM, it is in header.tpl html tag

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* feat: allow app.require('bootbox'/'benchpressjs')

* refactor: require server side utils

* test: jquery ready

* change istaller to use build/public

* test: use document.addEventListener

* refactor: closes #10301

* refactor: generateTopicClass

* fix: column counts for other privileges

* fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking]

* fix: typo in hook name

* refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags)

* fix: crash if `delay` not passed in (as it cannot be destructured)

* refactor: replace substr

* feat: set --panel-offset style in html element based on stored value in localStorage

* refactor: addDropupHandler() logic to be less naive

- Take into account height of the menu
- Don't apply dropUp logic if there's nothing in the dropdown
- Remove 'hidden' class (added by default in Persona for post tools) when menu items are added

closes #10423

* refactor: simplify utils.params [breaking]

Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do.

* feat: add support for returning full URLSearchParams for utils.params

* fix: utils.params() fallback handling

* fix: default empty obj for params()

* fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end

* fix: utils.params() not allowing relative paths to be passed in

* refactor(DRY): new assertPasswordValidity utils method

* fix: incorrect error message returned on insufficient privilege on flag edit

* fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate

- added failing tests and patched up middleware.assert.flags to fix

* refactor: flag api v3 tests to create new post and flags on every round

* fix: missing error:no-flag language key

* refactor: flags.canView to check flag existence, simplify middleware.assert.flag

* feat: flag deletion API endpoint, #10426

* feat: UI for flag deletion, closes #10426

* chore: update plugin versions

* chore: up emoji

* chore: update markdown

* chore: up emoji-android

* fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check

Co-authored-by: Julian Lam <julian@nodebb.org>
2022-04-29 21:39:33 -04:00
Peter Jaszkowiak
23f212a4c0 chore: eslint prefer-destructuring 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
dab3b23575 chore: eslint no-var, vars-on-top 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
b56d9e12b5 chore: eslint prefer-arrow-callback 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
707b55b6a5 chore: eslint prefer-template 2021-02-08 18:06:44 -05:00
Peter Jaszkowiak
4ee0f1459d chore: eslint import/newline-after-import 2021-02-08 18:06:44 -05:00
Barış Soner Uşaklı
814771bdc7 fix: restart on js changes in vendor 2020-11-19 20:34:12 -05:00
Tudor-Dan Ravoiu
39279a1e54 Run grunt with debugger enabled (#8911)
* Run grunt with debugger enabled

When forking a node.js thread we are also having the possibility to pass some node.js arguments, such as "--inspect=0.0.0.0". By providing this, we are adding the capability of doing live debugging even when the system is started with grunt.

* removed whitespace

* Update Gruntfile.js
2020-11-19 09:48:13 -05:00
Barış Soner Uşaklı
c4bdeae06e feat: merge improvements wip 2020-06-09 15:26:41 -04:00
Barış Soner Uşaklı
d484731d8c fix: derp includes 2020-05-20 12:58:14 -04:00
Barış Soner Uşaklı
6108064ea8 feat: change to contains to match scoped modules
replace recursive function with loop
2020-05-20 12:43:20 -04:00
Barış Soner Uşaklı
cb662e15ce feat: improve grunt restart/rebuild speed 2020-05-19 21:15:51 -04:00
Barış Soner Uşaklı
451c7fd4b6 feat: allow only watching core 2019-09-07 14:10:24 -04:00
Barış Soner Uşaklı
a6b7770342 Grunt active plugins (#7677)
* feat: only watch active plugins/themes

* fix: remove log

* fix: remove left over glob

* fix: remove test glob

* feat: watch baseThemes as well

* feat: dont watch upgrade scripts
2019-06-11 12:50:40 -04:00
Barış Soner Uşaklı
26d4e0852f use includes instead of indexOf
use _.uniq instead of filter&indexOf
2018-10-20 14:40:48 -04:00
Peter Jaszkowiak
abffc29128 Use Benchpress (#5901)
* Use Benchpress

* Use Benchpress.compileParse

* Error for template load failure

* Use benchpressjs package

* Compile templates on demand

* Fix user settings page

* Fix admin search to exclude `.jst` files

* Fix 500-embed

So ajaxify can still show an error if the server goes down
2017-08-24 19:26:50 -04:00
psychobunny
f1f5db4c99 remove redundant lines in watch directories 2017-08-23 20:13:52 -04:00
psychobunny
70887c5f78 fix grunt paths for core less files 2017-08-23 20:11:24 -04:00
psychobunny
0e219a8c58 closes #5891 2017-08-21 17:48:58 -04:00
psychobunny
006584e405 fixes [build] Unknown target: error message 2017-05-31 15:06:10 -04:00
Peter Jaszkowiak
2a9cdb7be2 Add --threads=# option for setting max threads
Make grunt NODE_ENV development by default
2017-05-23 15:49:14 -06:00
Peter Jaszkowiak
dd2b930824 Resolve merge conflicts, minify only .js files 2017-02-23 18:31:49 -07:00
Peter Jaszkowiak
4bb49a7171 ESlint no-unused-vars 2017-02-18 15:05:36 -07:00
Peter Jaszkowiak
feb8405f95 ESlint eol-last 2017-02-18 02:30:48 -07:00
Peter Jaszkowiak
a038c66549 ESlint quotes 2017-02-18 01:56:23 -07:00
Peter Jaszkowiak
277a7fb8b4 ESlint key-spacing, no-trailing-spaces 2017-02-18 01:27:46 -07:00
Peter Jaszkowiak
3361a72725 ESlint no-plusplus
and no-empty, space-unary-ops
2017-02-18 01:12:18 -07:00
Peter Jaszkowiak
2ba46808a1 ESlint one-var, fix comma-dangle 2017-02-17 20:20:42 -07:00
Peter Jaszkowiak
bc1d70c126 ESlint comma-dangle 2017-02-17 19:31:21 -07:00
pichalite
bb3c8b910a Skip option skips build 2017-02-17 23:33:37 +00:00
pichalite
5ca931a52c Update gruntfile to build on initialization 2017-02-17 22:07:50 +00:00
Julian Lam
06bf631445 increased file watch interval to reduce high CPU usage when using grunt 2017-02-03 10:24:55 -05:00
Julian Lam
5de67f9607 excluding tx managed language files from grunt 2017-02-02 10:52:20 -05:00
Peter Jaszkowiak
80b4c6fa68 Exclude config files 2017-01-19 10:53:25 -07:00
Peter Jaszkowiak
e94d47976d Build language files on change 2017-01-17 20:22:38 -07:00
Julian Lam
12f834072a removed comment from Gruntfile 2016-11-29 21:20:14 -05:00
Julian Lam
7a10cffb25 fix Gruntfile.js to work with bew build step 2016-11-17 13:56:47 -05:00
Julian Lam
9bf0f6c5cd prep for @psychobunny, re: #5211 2016-11-16 20:53:20 -05:00
HeeL
4a3c31b2dc Fix space-before-function-paren linter rule 2016-10-13 11:43:39 +02:00
psychobunny
5f5d8e6b56 ah, woops 2016-04-18 11:22:38 -04:00
psychobunny
6e617dd69a closes #4520 2016-04-18 10:59:55 -04:00
Julian Lam
94a505a6bb removed symlink logic and using route bridging instead.
Also allowed plugins to define modules from their plugin.json
2016-04-04 20:43:21 -04:00
Julian Lam
ad16c3db6b updated Gruntfile to ignore js files in public/src/modules 2016-04-04 18:51:10 -04:00
psychobunny
f12903a3fe grunt watch: ignore .git folders 2016-03-29 14:37:40 -04:00
Julian Lam
32c18a1cd8 updated gruntfile to not watch subdependencies 2016-03-29 13:19:01 -04:00
psychobunny
baeed22f20 grunt: only compile ACP less if that was changed, and vice versa with theme/plugin less 2016-03-24 12:37:17 -04:00
psychobunny
efb6a9fe7e added option to skip asset compilation on initial grunt startup with --skip flag 2016-02-23 14:26:16 -05:00
psychobunny
551c81a977 grunt: watch for tjs changes as well 2015-05-11 13:52:52 -04:00
psychobunny
60d655e32b installer - got the basics in 2015-04-21 14:52:57 -04:00
psychobunny
89ecda5163 for plugin admin pages
need to find a better solution tho
2015-03-02 14:09:44 -05:00