Commit Graph

1474 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
32f693019b test: check contents of config.json in tests 2022-02-17 14:47:23 -05:00
Julian Lam
17836f2a3a Re-introduce lodash into src/package-install.js (#10315)
* test: add failing test for if package.json is non-existant, fix tests' beforeEach method

* Revert "fix: #10289, remove lodash dependency in src/cli/package-install.js"

This reverts commit 81fa2e22bc.

* fix: regression caused by 94b79ce402

`./nodebb setup` was no longer able to be called without arguments or env vars

* fix: .updatePackageFile() throwing if no package.json

* fix: removing unneeded code in src/cli/index.js that seemed to be used to handle cases where package.json was missing (initial install)

... However, as .updatePackageFile() now handled cases where there is no package.json, it should be ok to remove this code

* fix: handle missing package.json or node_modules/
2022-02-17 14:10:24 -05:00
Barış Soner Uşaklı
58b5781cea feat: closes #10296
asset_base_url in nconf
keep assetBaseUrl in config for backwards compat
2022-02-15 19:22:34 -05:00
Julian Lam
fb78570c13 test: fix topic thumb tests and topic thumbs to work properly with post upload assoc. 2022-02-14 15:02:07 -05:00
Julian Lam
d5ed8736aa feat: deleting a user upload dissociates from posts, and vice versa 2022-02-14 15:02:07 -05:00
Julian Lam
8c2752bab1 test: user uploads.js tests 2022-02-14 15:02:07 -05:00
Julian Lam
11275d6809 test: testing user upload methods, already fixed one bug 2022-02-14 15:02:07 -05:00
Julian Lam
b9edee143e fix: local deleteUploads() method in src/user/delete.js to call User.deleteUpload() 2022-02-14 15:02:07 -05:00
Julian Lam
6489e9fd9e refactor: change the post uploads' hash seeds to have the files/ prefix 2022-02-14 15:02:07 -05:00
Julian Lam
84dfda59e6 fix: #10144, automatically delete uploads from disk on post purge, ACP option to keep uploads on disk if desired 2022-02-14 15:02:07 -05:00
Julian Lam
d92da828a3 refactor: move post upload tests to its own file 2022-02-14 15:02:07 -05:00
Barış Soner Uşaklı
2dbdd1818f test: fix occasional test failure 2022-02-08 17:36:28 -05:00
Julian Lam
a2c7d69e1b fix: remove extraneous devDependencies on package merge
/cc @pitaj
2022-02-08 11:13:51 -05:00
Julian Lam
9e4147f07c chore: use source and current local vars, + docs 2022-02-08 11:00:35 -05:00
Julian Lam
0f788b8eaa fix: #10257, topic thumbs not deleting on topic deletion 2022-02-07 17:29:34 -05:00
Julian Lam
606808760e test: add test to verify that a sorted set is automatically deleted if its last element is removed (#10261)
* test: add test to verify that a sorted set is automatically deleted if its last element is removed

* fix: remote empty zsets when all elements have been removed #yolo

* Revert "fix: remote empty zsets when all elements have been removed #yolo"

This reverts commit 0ac73244bb.

* fix: altered behaviour in module.exists instead of zrem
2022-02-07 17:16:50 -05:00
Julian Lam
d34471f69f fix: regression in package.json merging logic that caused extraneous packages to not be removed 2022-02-04 16:20:31 -05:00
Julian Lam
689c125cd3 fix: #10229, package merging should deep merge nested objects
+ tests
2022-02-04 16:20:31 -05:00
Julian Lam
a0a3870611 fix: use fs.promises 2022-02-04 16:20:31 -05:00
Julian Lam
1b8eeaf840 feat: more tests for ensuring downvoted posts are added to the :votes zset 2022-02-04 14:33:58 -05:00
Julian Lam
aa8914a153 feat: v3 user email tests 2022-02-04 10:20:46 -05:00
Julian Lam
d1b1f50bb2 test: stricter isValidationPending check 2022-02-04 10:20:46 -05:00
Julian Lam
fc2c755c64 fix: properly unregister hooks in emailer tests 2022-01-28 15:46:28 -05:00
Julian Lam
dee9cca3c8 fix: email ban tests 2022-01-28 15:41:27 -05:00
Julian Lam
e25c0313d1 Revert "refactor: emailer.send and emailer.sendToEmail returns Boolean based on message being successfully sent"
This reverts commit f0e32ff182.
2022-01-28 15:41:27 -05:00
Julian Lam
ea27eaf166 feat: no more sending emails to banned users, + feature flag 2022-01-28 15:16:41 -05:00
Julian Lam
f0e32ff182 refactor: emailer.send and emailer.sendToEmail returns Boolean based on message being successfully sent
Note that of course this doesn't mean the message was _delivered_, just sent off.

This will stop issues where emailer errors crash NodeBB
2022-01-28 15:16:41 -05:00
Barış Soner Uşaklı
680e36da67 test: fix derp 2022-01-28 14:58:32 -05:00
Barış Soner Uşaklı
a214f9a61b test: up acp plugin page timeout 2022-01-28 14:40:57 -05:00
Barış Soner Uşaklı
10949184ca test: add failing guest csrf test (#10169)
* test: add failing guest csrf test

* test: use correct var

* fix: use applyCsrf for guests as well
2022-01-20 18:22:10 -05:00
Barış Soner Uşaklı
6c1e184c74 test: fix util test 2022-01-10 18:54:06 -05:00
Barış Soner Uşaklı
9b75b1ede2 test: update tag tests, fix linux symlink error 2022-01-10 18:41:07 -05:00
Julian Lam
d95b4ee29a fix: assertion check to ensure messages are in the room when editing/deleting, etc 2021-12-22 14:58:42 -05:00
Julian Lam
82768fcf6e chore: remove debug logs in test/api.js 2021-12-22 14:39:31 -05:00
Julian Lam
aaa6f752d0 refactor: put message api calls behind /messages prefix, #10097 2021-12-22 14:39:18 -05:00
Julian Lam
e747998cba test: fix user tests calling deprecated socket methods 2021-12-22 10:59:36 -05:00
Julian Lam
16ba16cdc4 fix: deprecate chats.leave 2021-12-22 10:59:36 -05:00
Julian Lam
fe17c94c35 feat: DELETE /api/v3/chats/:roomId/users and DELETE /api/v3/chats/:roomId/users/:uid 2021-12-22 10:59:36 -05:00
Julian Lam
6294beea0b fix: re-allow kicking of the other party in a 1-to-1 chat 2021-12-22 10:59:36 -05:00
Julian Lam
d62ee84637 feat: POST /chats/:roomId/users 2021-12-22 10:59:36 -05:00
Julian Lam
6eea6451d2 feat: GET /chats/:roomId/users [breaking] 2021-12-22 10:59:36 -05:00
Julian Lam
b292960594 feat: GET /chats/:roomId/:mid 2021-12-22 10:59:36 -05:00
Julian Lam
f48ed3658a feat: PUT /chats/:roomId/:mid 2021-12-22 10:59:36 -05:00
Julian Lam
140f9d2481 fix: isFinite check for room assertion, more test migrating 2021-12-22 10:59:36 -05:00
Julian Lam
e745e21242 chore: use apiv3 for room rename tests 2021-12-22 10:59:36 -05:00
Julian Lam
c990211cf2 refactor: rewrite messaging tests to use API v3 calls when available, rewrote a bunch of tests to async..await 2021-12-22 10:59:36 -05:00
Julian Lam
eeffb9d978 feat: POST /api/v3/chats/:roomId 2021-12-22 10:59:36 -05:00
Barış Soner Uşaklı
1264dcb555 test: add email interstitial tests 2021-12-15 21:28:46 -05:00
Barış Soner Uşaklı
5e08f7e604 test: don't use csrf_token for get,head, options 2021-12-14 14:44:05 -05:00
Barış Soner Uşaklı
0e273ab25a test: fix tests 2021-12-14 12:15:08 -05:00