Commit Graph

12835 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
b73aa84ddc fix: tests 2020-02-10 14:30:40 -05:00
Barış Soner Uşaklı
dd3893b134 fix: move start/stop every iteration 2020-02-10 13:49:04 -05:00
Barış Soner Uşaklı
4abe5eb7ff Revert "fix: #8154, move start/stop every iteration"
This reverts commit 300c04cef9.
2020-02-10 13:47:34 -05:00
Barış Soner Uşaklı
300c04cef9 fix: #8154, move start/stop every iteration 2020-02-10 13:47:15 -05:00
Barış Soner Uşaklı
690bb69d03 fix: #8154, respect stop 2020-02-10 13:21:01 -05:00
Barış Soner Uşaklı
f23bc347b1 fix: #8156 dont allow loading members from hidden groups 2020-02-10 13:20:10 -05:00
Barış Soner Uşaklı
03a02e5d1d fix: #8155, don't validate name on update if groupName didn't change 2020-02-10 13:16:45 -05:00
Baris Usakli
236e1e6859 fix: return correct number of suggested topics 2020-02-07 14:50:18 -05:00
Julian Lam
398f0120b8 fix: logic for determining dailyStats hour vars
Reverts 9ecdb92f7c and fixes it
properly.
2020-02-07 11:35:45 -05:00
Julian Lam
9ecdb92f7c fix: fix daily analytics being one day off 2020-02-07 11:20:59 -05:00
Julian Lam
0b9ad416cb fix: remove debug line 2020-02-07 10:51:24 -05:00
Julian Lam
79737c53fd feat: guard against accidental ommision
...of analytics: prefix in get*StatsForSet methods
2020-02-07 10:28:40 -05:00
Julian Lam
d6e3f3f058 fix: #8142, broken site if no server-side session (#8148)
* fix: #8142, broken site if no server-side session

During the `addHeader` middleware, a check is now done to see if
`req.session.meta` is present. This value is only present if the user
has a valid server-side session.  If it is missing, then it is probably
safe to assume that the server-side session was deleted (either
intentionally or accidentally). In that scenario, the client-side cookie
should be cleared.

Also, there was an issue where the sessionRefresh flag was never cleared
after a successful login, so that was fixed too.

* feat: exported method to get cookie config

* fix: don't clear cookie if cookie is being set

* fix: socket.io tests

Co-authored-by: Barış Soner Uşaklı <barisusakli@gmail.com>
2020-02-06 15:52:37 -05:00
Julian Lam
0885ec6858 fix: #8144 pluginHooks in maintenance mode middleware 2020-02-06 15:43:14 -05:00
Barış Soner Uşaklı
a5ef6b53b8 fix: admin relogin 2020-02-03 11:04:20 -05:00
Barış Soner Uşaklı
c35a21d7f0 fix: #8135 2020-01-31 22:56:55 -05:00
Baris Usakli
1e50616c13 fix: handle mkdirp0.5->1.0x so it doesn't break upgrade 2020-01-31 15:05:50 -05:00
Baris Usakli
87225a90c3 fix: #8134, upgrade mkdirp to 1.0.x 2020-01-31 14:10:00 -05:00
Julian Lam
b959c24a2b Merge branch 'master' of github.com:NodeBB/NodeBB 2020-01-29 12:47:55 -05:00
Julian Lam
111ed802cf fix: onSuccessfulLogin not working
In scenarios where onSuccessfulLogin was not called in the SSO plugin,
core's calling of onSuccessfulLogin was prematurely returning, because
it was checking the wrong value.

This commit fixes the issue by checking a different value.
2020-01-29 12:47:48 -05:00
Barış Soner Uşaklı
8c48f94b96 fix: #8139, dont allow restore if not deleted by self 2020-01-28 13:03:58 -05:00
Barış Soner Uşaklı
9969dd6335 fix: use view_deleted when filtering, closes #8137 2020-01-28 12:42:57 -05:00
Barış Soner Uşaklı
d927b763c1 fix: escape invalid rules 2020-01-26 22:18:07 -05:00
Barış Soner Uşaklı
3cca929a88 fix: add missing await 2020-01-26 21:35:04 -05:00
Barış Soner Uşaklı
0ae1eb4f6e fix: missing await in SocketPosts.changeOwner 2020-01-24 14:28:27 -05:00
Barış Soner Uşaklı
23810cc64b fix: #8133, check if user is in room before removing 2020-01-23 22:40:14 -05:00
Barış Soner Uşaklı
30c503611c refactor: messaging 2020-01-23 22:19:15 -05:00
Barış Soner Uşaklı
cd1fa27a8b fix: add missing await 2020-01-23 22:19:00 -05:00
Barış Soner Uşaklı
ee4304b443 Merge branch 'master' of https://github.com/NodeBB/NodeBB 2020-01-23 22:13:07 -05:00
Barış Soner Uşaklı
f799f017ab fix: missing await 2020-01-23 22:04:49 -05:00
Baris Usakli
418c174d56 fix: dont return flag data to client 2020-01-23 12:48:21 -05:00
Barış Soner Uşaklı
51236df4ed fix: check if user has read priv before flagging 2020-01-22 12:14:50 -05:00
Barış Soner Uşaklı
1f13ab8a19 fix: restrict getUsersInRoom to members 2020-01-22 11:46:26 -05:00
Julian Lam
594cd7e176 fix: #8127 user join system message duplicated
- Now showing user-join message for chat owner in addition to the newly
  added user
- If a modal already exists for a room when createModal is called, don't
  return null, return the modal
2020-01-21 13:57:16 -05:00
Barış Soner Uşaklı
bfaba89557 Merge branch 'master' of https://github.com/NodeBB/NodeBB 2020-01-20 10:59:22 -05:00
Julian Lam
8bb5e71ebe fix: typo in #8116 2020-01-20 10:21:27 -05:00
Julian Lam
3fac09b1ab fix: build step defaults to series instead of parallel
- The logic for the build step now defaults to series instead of
  parallel, unless more than 4 CPU cores are detected by the os
  library.
- The `--series` flag still exists, and will enforce build in
  series, as before.
2020-01-20 10:21:27 -05:00
Julian Lam
8e5a2276af feat: check flag values on save (assignee and state) (#8122)
* feat: add assignee checking when updating flag

Prior to this, it was possible to update the assignee to any value (or
any user. This commit adds checking to allow only admins, global
moderators, or in the case of flagged posts, moderators.

Also some prep work was added for value checking `state`.

* feat: value checking `state` on flag update

The state should be one of the constants defined earlier in the file.
2020-01-20 10:19:23 -05:00
Barış Soner Uşaklı
6a63c1a100 fix: escape system message, don't allow editing system messages 2020-01-19 22:20:43 -05:00
Barış Soner Uşaklı
8c6a7954cf fix: delete upload 2020-01-19 14:57:06 -05:00
Barış Soner Uşaklı
153b1a0eaa fix: check uploadName 2020-01-19 11:56:13 -05:00
Barış Soner Uşaklı
01d1ae78c8 fix: #8120, bubble errors from static hooks 2020-01-17 13:30:57 -05:00
Barış Soner Uşaklı
b0f3e48ac2 fix: escape bootswatchSkin and homepageRoute 2020-01-17 11:48:00 -05:00
Barış Soner Uşaklı
3e52557689 fix: change owner missing await 2020-01-17 11:16:23 -05:00
Barış Soner Uşaklı
e3952674ba fix: hsts always enabled 2020-01-15 19:32:14 -05:00
Barış Soner Uşaklı
b7a57996f7 fix: escape topic.thumb 2020-01-15 18:53:08 -05:00
Baris Usakli
842916ea42 Merge branch 'master' of https://github.com/NodeBB/NodeBB 2020-01-15 11:36:39 -05:00
Baris Usakli
4eb9652a2a fix: #8112, don't crash hook returns no data 2020-01-15 11:36:27 -05:00
Opliko
740de034fa #8115 - log post owner changes (#8117)
* log post owner changes

* log each post separately

* use map instad of a loop
2020-01-15 11:05:57 -05:00
Opliko
879acc85ae Add disable/enable category to category edit page (#8118) 2020-01-14 17:30:56 -05:00