Commit Graph

12347 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
84f2726391 refactor: deprecate middleware param (#10513)
* refactor: deprecate middleware param

make middlewares optional

* chore: add node 18 again
2022-05-04 21:12:37 -04:00
Barış Soner Uşaklı
ea01ba0152 fix: #10569, fix category move event text 2022-05-03 14:19:38 -04:00
Barış Soner Uşaklı
23175110a2 feat: post queue bulk actions closes #10520, fix #10555, 2022-04-30 19:07:49 -04:00
Barış Soner Uşaklı
d20b07cfea Webpack5 (#10311)
* feat: webpack 5 part 1

* fix: gruntfile fixes

* fix: fix taskbar warning

add app.importScript
copy public/src/modules to build folder

* refactor: remove commented old code

* feat: reenable admin

* fix: acp settings pages, fix sortable on manage categories

embedded require in html not allowed

* fix: bundle serialize/deserizeli so plugins dont break

* test: fixe util tests

* test: fix require path

* test: more test fixes

* test: require correct utils module

* test: require correct utils

* test: log stack

* test: fix db require blowing up tests

* test: move and disable bundle test

* refactor: add aliases

* test: disable testing route

* fix: move webpack modules necessary for build, into `dependencies`

* test: fix one more test

remove 500-embed.tpl

* fix: restore use of assets/nodebb.min.js, at least for now

* fix: remove unnecessary line break

* fix: point to proper ACP bundle

* test: maybe fix build test

* test: composer

* refactor: dont need dist

* refactor: more cleanup

use everything from build/public folder

* get rid of conditional import in app.js

* fix: ace

* refactor: cropper alias

* test: lint and test fixes

* lint: fix

* refactor: rename function to app.require

* refactor: go back to using app.require

* chore: use github branch

* chore: use webpack branch

* feat: webpack webinstaller

* feat: add chunkFile name with contenthash

* refactor: move hooks to top

* refactor: get rid of template500Function

* fix(deps): use webpack5 branch of 2factor plugin

* chore: tagging v2.0.0-beta.0 pre-release version 💥 :shipit: 🎉 🚀

* refactor: disable cache on templates

loadTemplate is called once by benchpress and the result is cache internally

* refactor: add server side helpers.js

* feat: deprecate /plugins shorthand route, closes #10343

* refactor: use build/public for webpack

* test: fix filename

* fix: more specific selector

* lint: ignore

* refactor: fix comments

* test: add debug for random failing test

* refactor: cleanup

remove test page, remove dupe functions in utils.common

* lint: use relative path  for now

* chore: bump prerelease version

* feat: add translateKeys

* fix: optional params

* fix: get rid of extra timeago files

* refactor: cleanup, require timeago locale earlier

remove translator.prepareDOM, it is in header.tpl html tag

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* feat: allow app.require('bootbox'/'benchpressjs')

* refactor: require server side utils

* test: jquery ready

* change istaller to use build/public

* test: use document.addEventListener

* refactor: closes #10301

* refactor: generateTopicClass

* fix: column counts for other privileges

* fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking]

* fix: typo in hook name

* refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags)

* fix: crash if `delay` not passed in (as it cannot be destructured)

* refactor: replace substr

* feat: set --panel-offset style in html element based on stored value in localStorage

* refactor: addDropupHandler() logic to be less naive

- Take into account height of the menu
- Don't apply dropUp logic if there's nothing in the dropdown
- Remove 'hidden' class (added by default in Persona for post tools) when menu items are added

closes #10423

* refactor: simplify utils.params [breaking]

Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do.

* feat: add support for returning full URLSearchParams for utils.params

* fix: utils.params() fallback handling

* fix: default empty obj for params()

* fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end

* fix: utils.params() not allowing relative paths to be passed in

* refactor(DRY): new assertPasswordValidity utils method

* fix: incorrect error message returned on insufficient privilege on flag edit

* fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate

- added failing tests and patched up middleware.assert.flags to fix

* refactor: flag api v3 tests to create new post and flags on every round

* fix: missing error:no-flag language key

* refactor: flags.canView to check flag existence, simplify middleware.assert.flag

* feat: flag deletion API endpoint, #10426

* feat: UI for flag deletion, closes #10426

* chore: update plugin versions

* chore: up emoji

* chore: update markdown

* chore: up emoji-android

* fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check

Co-authored-by: Julian Lam <julian@nodebb.org>
2022-04-29 21:39:33 -04:00
Julian Lam
e4a9c07817 feat: output canonical URL as last line on NodeBB boot 2022-04-29 11:29:02 -04:00
Barış Soner Uşaklı
82389469f6 feat: make it simpler to use redis sentinels 2022-04-22 15:39:27 -04:00
Barış Soner Uşaklı
d98ca43799 Revert "refactor: closes #10509"
This reverts commit 7f241dbbe6.
2022-04-22 15:24:02 -04:00
Barış Soner Uşaklı
7f241dbbe6 refactor: closes #10509
deprecate third param(middleware) to setupPageRoute/setupAdminPageRoute
make middlewares optional on all 3 helpers
2022-04-22 15:22:08 -04:00
Barış Soner Uşaklı
ac125538d0 refactor: show invalid uri 2022-04-22 12:13:43 -04:00
Barış Soner Uşaklı
a8e642ade2 refactor: skip content length check if submitting from post-queue 2022-04-21 12:23:37 -04:00
Barış Soner Uşaklı
b9f9164308 fix: #10502, allow unblocking admin/mod
if they were blocked before becoming admin/mod it wasn't possible to unblock them
2022-04-17 18:15:49 -04:00
Barış Soner Uşaklı
b28f9f776a feat: closes #10501, minimum reputation to chat 2022-04-16 21:37:54 -04:00
Barış Soner Uşaklı
5316029f91 fix: dont add caller to arrays 2022-04-13 15:09:58 -04:00
Barış Soner Uşaklı
c52401da02 fix: #10491, don't leak deleted message in cleanedContent 2022-04-12 15:36:06 -04:00
Julian Lam
9f91db16cb fix: #10473, trim trailing slashes on config url 2022-04-08 10:28:15 -04:00
Barış Soner Uşaklı
398777633f fix: closes #10436, fix DST issue on acp dashboard 2022-04-07 14:14:28 -04:00
Barış Soner Uşaklı
767973717b perf: WIP #10449, allow array of pids for posts.purge (#10465)
* perf: WIP #10449, allow array of pids for posts.purge

* refactor: deletePostDiffs

* perf: deletePostFromReplies/deletePostFromGroups

* refactor: upload

* refactor: deleteFromCategoryRecentPosts

deleteFromUsersBookmarks
deleteFromUsersVotes

* feat: closes #10468, add incrObjectFieldByBulk

* refactor: allow nids for notifications.rescind

* refactor: allow uids array for user.updatePostCount

* refactor: rewrite deleteFromTopicUserNotification to work with an array

* feat: deprecate action:post.purge as well

* lint: add missing comma
2022-04-07 14:06:25 -04:00
Barış Soner Uşaklı
799e94e02e feat: #10460, add cutoff to suggested topics 2022-04-05 15:37:31 -04:00
Barış Soner Uşaklı
e8058ca35c feat: add response:helpers.notAllowed 2022-04-04 17:34:52 -04:00
Barış Soner Uşaklı
b8765df5f4 feat: add filter:image.stripEXIF 2022-03-31 14:58:43 -04:00
CommanderRoot
200f0b2e4f refactor: replace deprecated String.prototype.substr() (#10432)
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-03-31 13:49:56 -04:00
chadjw
fe072d6091 Allows socket authentication to be handled within plugins (#10428) 2022-03-30 14:58:08 -04:00
Barış Soner Uşaklı
002a241cc5 fix: delete history as well 2022-03-23 19:07:18 -04:00
Barış Soner Uşaklı
93b6053284 fix: handle purge posts as well 2022-03-23 18:38:36 -04:00
Barış Soner Uşaklı
31251282ad feat: delete flagId field from post/user on flag purge 2022-03-23 15:38:21 -04:00
Barış Soner Uşaklı
03fdb5bede fix: byCid removal, targetCid not stored in flagObj 2022-03-23 15:27:45 -04:00
Barış Soner Uşaklı
3b529b84b5 feat: add flags.purge 2022-03-23 15:10:10 -04:00
Barış Soner Uşaklı
9abe22a04b refactor: remove some verbose logging 2022-03-22 18:29:37 -04:00
Barış Soner Uşaklı
29b86b3276 refactor: :trollface: 2022-03-18 15:58:29 -04:00
Barış Soner Uşaklı
421ba6e1a2 feat: new admin events, closes #10405 2022-03-18 15:54:40 -04:00
Barış Soner Uşaklı
55be42026c fix: upgrade script 2022-03-18 12:50:49 -04:00
Barış Soner Uşaklı
dab22d5fd0 perf: #10410, faster upgrade script 2022-03-18 12:40:13 -04:00
Julian Lam
38ca73c493 fix(security): explicitly declare cache-control header instead of using middleware
This commit reverts 1f6f389ff2
2022-03-18 11:56:16 -04:00
Julian Lam
1f6f389ff2 fix(security): cache-control on all pages using setupPageRoute or setupApiRoute, and 404 controllers.
This commit also reverts e39cdd490b
2022-03-17 21:42:26 -04:00
Julian Lam
e39cdd490b fix(security): explicitly set cache-control 'private' on any page where a header is built 2022-03-17 16:24:03 -04:00
Julian Lam
2b9b2b4a25 fix: column counts for other privileges 2022-03-17 13:38:40 -04:00
Barış Soner Uşaklı
3935a86b83 fix: topic events if there is a blocked user in topic 2022-03-16 16:56:07 -04:00
Barış Soner Uşaklı
2808c952c5 fix: topic events disappearing if there are queued posts 2022-03-16 15:52:59 -04:00
Julian Lam
cd687cff06 fix: #10393, move 'Create User' control to overflow menu 2022-03-15 13:57:09 -04:00
Barış Soner Uşaklı
7c946570d5 feat: on online users page override timeago cutoff to 24 hours 2022-03-11 23:42:46 -05:00
Barış Soner Uşaklı
7d063d731e fix: global privs 2022-03-11 23:42:06 -05:00
Barış Soner Uşaklı
be6bbabd0e feat: ability to mute users
new mute privilege
2022-03-11 23:07:20 -05:00
Julian Lam
cb113208bb fix: #10384 -- mixed up sizes for fallback touch icons 2022-03-11 16:24:19 -05:00
Barış Soner Uşaklı
c8e986d61c refactor: closes #10301 2022-03-11 15:33:28 -05:00
Barış Soner Uşaklı
3414a23bce feat: min:rep:upvote, and other limits similar to downvotes
closes #10380
2022-03-11 13:34:36 -05:00
Barış Soner Uşaklı
2056ac04e0 feat: post-queue hooks, closes #10381 2022-03-11 12:27:07 -05:00
Barış Soner Uşaklı
df46ab4874 feat: add hook filter:posts.getUserInfoForPosts 2022-03-09 15:05:11 -05:00
Julian Lam
83fd4311b2 chore: delay filter:email.send removal to v2.0.0 2022-03-08 22:35:00 -05:00
Julian Lam
93b80f170b refactor: show a louder deprecation notice, alert once for each hook, not per plugin per hook 2022-03-08 22:33:02 -05:00
Julian Lam
a3b4c668d5 fix: apply some DRY 2022-03-08 15:14:57 -05:00