Commit Graph

234 Commits

Author SHA1 Message Date
Peter Jaszkowiak
89c025d102 feat: close #7002, console message if mismatched origins 2018-11-30 13:38:59 -05:00
renovate[bot]
64b9dabff8 chore(deps): update dependency eslint-config-airbnb-base to v13 (#6599)
* chore(deps): update dependency eslint-config-airbnb-base to v13

* chore: #6599, linting 😬
2018-11-07 15:53:14 -05:00
Barış Soner Uşaklı
9c022afae1 Parse int (#6853)
* Store config fields as JSON in the db

Fewer parseInts

* Remove unnecessary parseInts

* remove some dupe code add tests

* remove console.log

* remove more parseInts

* WIP: read meta.configs defaults from defaults.json

remove more parseInts

* more work

* add log for failing test

* update admin pwd

* fix tests, dont require posts/cache before configs are initialized

* handle saves

* Test boolean conditions

* remove more parseInts

* Fix boolean values

* remove lots more parseInts

* removed json parsing

* renamed var to number

* categories dont have timestamp
2018-10-21 16:47:51 -04:00
Ben Lubar
cf4ea94e6d Fix single-host-cluster socket.io (#6802)
It was silently dropping every message because every node thought it was the master node.
2018-09-28 17:02:03 -04:00
Ben Lubar
44373afc52 Fix socket.io not working properly in single-host clusters. (#6669)
This is because we don't use the cluster module, so the master nodejs process doesn't know about any of the clients through the socket API.
2018-07-25 11:04:18 -04:00
Ben Lubar
c1e98eefa7 Allow single-host clusters to not send pubsub and socket.io messages through the database. (#6659)
* Allow single-host clusters to not send pubsub and socket.io messages through the database.

* Fix lint errors.
2018-07-23 12:21:36 -04:00
Barış Soner Uşaklı
a37dc1856f #6561 2018-06-08 13:53:55 -04:00
Julian Lam
c25d752573 Merge remote-tracking branch 'origin/master' into develop 2018-02-23 14:48:38 -05:00
Julian Lam
a4a961639d only triggering forum updated messaging if hostname matches, fixes #6333 2018-02-20 15:32:44 -05:00
Ben Lubar
e85aabbe74 Allow running as a cluster without Redis (#6233)
* [database/*] Allow databases other than Redis to provide pubsub for clustering if Redis is not present

* [pubsub] Delay messages sent before the database is ready until the database is ready.

* [pubsub] Restore old behavior of not using the database in non-clustered NodeBB instances.

See comment: https://github.com/NodeBB/NodeBB/pull/6233#issuecomment-357814968
2018-01-18 13:02:56 -05:00
Julian Lam
73d4517d27 Revert "fixes #5894"
This reverts commit e2b40ddf34.
2017-08-23 21:38:58 -04:00
Baris Usakli
19ae2b3eb4 dont join online_users and uid_ if user does not exist 2017-08-23 15:30:13 -04:00
Baris Usakli
0d0ea0977f check error 2017-08-23 15:29:27 -04:00
Julian Lam
e2b40ddf34 fixes #5894 2017-08-23 15:11:15 -04:00
Barış Soner Uşaklı
e56178f72e remove init socket.io 2017-06-02 17:18:58 -04:00
Barış Soner Uşaklı
c0807ab327 closes #5639 2017-05-01 15:37:58 -04:00
Julian Lam
69dd1e3aca Merge branch 'master' into develop 2017-03-15 14:39:18 -04:00
Julian Lam
33bf930bb9 fixes #5528 2017-03-15 13:49:35 -04:00
Julian Lam
72e77772db Merge branch 'master' into develop 2017-02-24 12:46:40 -05:00
Peter Jaszkowiak
dd2b930824 Resolve merge conflicts, minify only .js files 2017-02-23 18:31:49 -07:00
Julian Lam
a9f144230e Merge branch 'master' into develop 2017-02-23 13:57:46 -05:00
Julian Lam
25f6293821 using io.origins instead 2017-02-23 13:26:52 -05:00
Julian Lam
91d3ce1abc Revert "adding origin to new local ioConfig var, as per @barisusakli, re: #5472"
This reverts commit c1b1ff5c6e.
2017-02-23 13:26:52 -05:00
Julian Lam
a4c00663ff Revert "adding origin to new local ioConfig var, as per @barisusakli, re: #5472"
This reverts commit c1b1ff5c6e.
2017-02-23 13:13:59 -05:00
Julian Lam
8154e29ad5 Merge branch 'master' into develop 2017-02-23 13:08:20 -05:00
Julian Lam
c1b1ff5c6e adding origin to new local ioConfig var, as per @barisusakli, re: #5472 2017-02-23 12:47:06 -05:00
Julian Lam
672d7352bb Merge branch 'master' into develop 2017-02-23 12:32:03 -05:00
Julian Lam
d4c2fc3bc8 closes #5472 2017-02-23 11:54:51 -05:00
Peter Jaszkowiak
09e868ce5f ESlint no-useless-escape, no-else-return 2017-02-18 14:27:26 -07:00
Peter Jaszkowiak
896c8c7343 ESlint object-curly-spacing 2017-02-18 12:30:49 -07:00
Peter Jaszkowiak
a038c66549 ESlint quotes 2017-02-18 01:56:23 -07:00
Peter Jaszkowiak
52f2028206 ESlint no-multiple-empty-lines 2017-02-17 22:08:23 -07:00
Peter Jaszkowiak
bc1d70c126 ESlint comma-dangle 2017-02-17 19:31:21 -07:00
Julian Lam
eae541d040 Merge branch 'master' into develop 2017-02-10 16:22:12 -05:00
Ben Lubar
9fb16e3520 Fix forum instances using Redis dropping socket.io messages.
Bug introduced in b08acd197c.

https://github.com/socketio/socket.io-redis/releases/tag/3.0.0
https://github.com/socketio/socket.io-redis/issues/185
2017-02-10 14:28:53 -06:00
Julian Lam
b5daedb7a3 Merge remote-tracking branch 'origin/master' into develop 2017-02-07 15:45:21 -05:00
barisusakli
a15aaaf389 closes #5394
dont allow socket.emits during maintenance mode
2017-02-03 19:02:43 +03:00
Julian Lam
d9d60c20bd flag updating and note appending, #5232 2016-12-01 11:42:06 -05:00
Julian Lam
ede7a71db7 Fixes #5186
On socket.io connection, all clients join a room pertaining to
their express session id. We use this room to keep track of any
sessions in different browser windows (but the same cookie jar),
so if a login/logout occurs, we can throw a session mismatch
modal.

This room can also be used to emit messages across windows/tabs...
2016-11-11 16:47:59 -05:00
barisusakli
ee75c69817 post edit tests 2016-11-11 17:28:36 +03:00
barisusakli
1a63672e66 more test fixes 2016-10-16 21:51:42 +03:00
barisusakli
12f366f4b4 more tests
register/login/logout tests
ability to test socket.io emits for logged in users
2016-10-16 16:43:42 +03:00
HeeL
4a3c31b2dc Fix space-before-function-paren linter rule 2016-10-13 11:43:39 +02:00
HeeL
9a0d764bbd Fix wrap-iife linter rule 2016-10-13 11:40:10 +02:00
barisusakli
4eb8015017 closes #5069 2016-09-29 14:31:32 +03:00
barisusakli
80c98e5ecf closes #4989 2016-08-30 13:25:20 +03:00
Julian Lam
e26166a45b closes #4950 2016-08-16 13:48:56 -04:00
barisusakli
98d17a0589 fix tab 2016-07-26 16:40:45 +03:00
akhoury
46a57f5d5c rm cls because it's not ready yet 2016-06-24 16:57:58 -04:00
Julian Lam
0a1dea09a0 added missing dependency lib 2016-06-08 17:45:48 -04:00