Barış Soner Uşaklı
bc880ee0ca
refactor: remove sockets.reqFromSocket
2020-10-16 21:05:00 -04:00
Julian Lam
40598b368e
refactor: topic creation to use api lib
2020-10-16 11:01:18 -04:00
Barış Soner Uşaklı
5e2caf19f5
refactor: use single function for api code
2020-10-15 12:12:01 -04:00
Julian Lam
b8703ba9f6
fix(writeapi): tests
2020-10-08 15:33:10 -04:00
Julian Lam
58043e07ba
fix: use POST call for user creation in ACP
...
- Not entirely sure about error handling yet, more research needed
- Also added socket method deprecation utility method
2020-10-08 15:33:10 -04:00
Barış Soner Uşaklı
d6baf5c278
feat: show event/params on error
2020-08-06 11:25:13 -04:00
Barış Soner Uşaklı
4658121a7d
fix: don't crash if content is undefined
2020-07-22 17:03:29 -04:00
Barış Soner Uşaklı
c2ca02dfc7
fix : #8474
...
make isPrimary and isCluster always booleans
they were strings when using ./nodebb start and boolean if they were in config.json and started with node app.js
2020-07-07 20:13:14 -04:00
Baris Usakli
91e8e3905c
fix : #7947 , disable unused cookie
2019-10-05 10:12:19 -04:00
Barış Soner Uşaklı
603908c10a
refactor: async/await socket.io/index
2019-10-02 22:51:02 -04:00
Barış Soner Uşaklı
88dfbf213f
refactor: async/await socket.io/admin
2019-09-07 18:22:03 -04:00
Barış Soner Uşaklı
b734defbfa
feat: rewrite getRawPost to async/await
...
promisify SocketPosts
2019-08-07 17:38:23 -04:00
Barış Soner Uşaklı
44a3352003
fix: socket.io methods calling callbacks twice if method returns promise
2019-07-19 16:46:40 -04:00
Julian Lam
aee47b299a
feat: awaitable websockets ( #7645 )
...
* feat: awaitable websockets
Adding in conditionals to check the method to call, and handling
it as a promise vs. a regular function depending on whether the
method itself is an asynchronous function.
* fix: switch to .then-checking for awaitable check
* fix: proper use of .then check
2019-06-10 12:06:26 -04:00
Julian Lam
0263b4daec
feat: added new hook static:sockets.validateSession ( #7189 )
...
* feat: added new hook
* fix: improper .bind() call, +req in static:sockets.validateSession
* fix: restored original sessionStore logic, +hook
original logic to retrieve the sessionStore was not faulty, but
was changed for the sake of changing things, which ultimately
led to issues with tests, etc.
2019-01-03 21:14:30 -05:00
Peter Jaszkowiak
89c025d102
feat: close #7002 , console message if mismatched origins
2018-11-30 13:38:59 -05:00
renovate[bot]
64b9dabff8
chore(deps): update dependency eslint-config-airbnb-base to v13 ( #6599 )
...
* chore(deps): update dependency eslint-config-airbnb-base to v13
* chore: #6599 , linting 😬
2018-11-07 15:53:14 -05:00
Barış Soner Uşaklı
9c022afae1
Parse int ( #6853 )
...
* Store config fields as JSON in the db
Fewer parseInts
* Remove unnecessary parseInts
* remove some dupe code add tests
* remove console.log
* remove more parseInts
* WIP: read meta.configs defaults from defaults.json
remove more parseInts
* more work
* add log for failing test
* update admin pwd
* fix tests, dont require posts/cache before configs are initialized
* handle saves
* Test boolean conditions
* remove more parseInts
* Fix boolean values
* remove lots more parseInts
* removed json parsing
* renamed var to number
* categories dont have timestamp
2018-10-21 16:47:51 -04:00
Ben Lubar
cf4ea94e6d
Fix single-host-cluster socket.io ( #6802 )
...
It was silently dropping every message because every node thought it was the master node.
2018-09-28 17:02:03 -04:00
Ben Lubar
44373afc52
Fix socket.io not working properly in single-host clusters. ( #6669 )
...
This is because we don't use the cluster module, so the master nodejs process doesn't know about any of the clients through the socket API.
2018-07-25 11:04:18 -04:00
Ben Lubar
c1e98eefa7
Allow single-host clusters to not send pubsub and socket.io messages through the database. ( #6659 )
...
* Allow single-host clusters to not send pubsub and socket.io messages through the database.
* Fix lint errors.
2018-07-23 12:21:36 -04:00
Barış Soner Uşaklı
a37dc1856f
#6561
2018-06-08 13:53:55 -04:00
Julian Lam
c25d752573
Merge remote-tracking branch 'origin/master' into develop
2018-02-23 14:48:38 -05:00
Julian Lam
a4a961639d
only triggering forum updated messaging if hostname matches, fixes #6333
2018-02-20 15:32:44 -05:00
Ben Lubar
e85aabbe74
Allow running as a cluster without Redis ( #6233 )
...
* [database/*] Allow databases other than Redis to provide pubsub for clustering if Redis is not present
* [pubsub] Delay messages sent before the database is ready until the database is ready.
* [pubsub] Restore old behavior of not using the database in non-clustered NodeBB instances.
See comment: https://github.com/NodeBB/NodeBB/pull/6233#issuecomment-357814968
2018-01-18 13:02:56 -05:00
Julian Lam
73d4517d27
Revert "fixes #5894 "
...
This reverts commit e2b40ddf34 .
2017-08-23 21:38:58 -04:00
Baris Usakli
19ae2b3eb4
dont join online_users and uid_ if user does not exist
2017-08-23 15:30:13 -04:00
Baris Usakli
0d0ea0977f
check error
2017-08-23 15:29:27 -04:00
Julian Lam
e2b40ddf34
fixes #5894
2017-08-23 15:11:15 -04:00
Barış Soner Uşaklı
e56178f72e
remove init socket.io
2017-06-02 17:18:58 -04:00
Barış Soner Uşaklı
c0807ab327
closes #5639
2017-05-01 15:37:58 -04:00
Julian Lam
69dd1e3aca
Merge branch 'master' into develop
2017-03-15 14:39:18 -04:00
Julian Lam
33bf930bb9
fixes #5528
2017-03-15 13:49:35 -04:00
Julian Lam
72e77772db
Merge branch 'master' into develop
2017-02-24 12:46:40 -05:00
Peter Jaszkowiak
dd2b930824
Resolve merge conflicts, minify only .js files
2017-02-23 18:31:49 -07:00
Julian Lam
a9f144230e
Merge branch 'master' into develop
2017-02-23 13:57:46 -05:00
Julian Lam
25f6293821
using io.origins instead
2017-02-23 13:26:52 -05:00
Julian Lam
91d3ce1abc
Revert "adding origin to new local ioConfig var, as per @barisusakli, re: #5472 "
...
This reverts commit c1b1ff5c6e .
2017-02-23 13:26:52 -05:00
Julian Lam
a4c00663ff
Revert "adding origin to new local ioConfig var, as per @barisusakli, re: #5472 "
...
This reverts commit c1b1ff5c6e .
2017-02-23 13:13:59 -05:00
Julian Lam
8154e29ad5
Merge branch 'master' into develop
2017-02-23 13:08:20 -05:00
Julian Lam
c1b1ff5c6e
adding origin to new local ioConfig var, as per @barisusakli, re: #5472
2017-02-23 12:47:06 -05:00
Julian Lam
672d7352bb
Merge branch 'master' into develop
2017-02-23 12:32:03 -05:00
Julian Lam
d4c2fc3bc8
closes #5472
2017-02-23 11:54:51 -05:00
Peter Jaszkowiak
09e868ce5f
ESlint no-useless-escape, no-else-return
2017-02-18 14:27:26 -07:00
Peter Jaszkowiak
896c8c7343
ESlint object-curly-spacing
2017-02-18 12:30:49 -07:00
Peter Jaszkowiak
a038c66549
ESlint quotes
2017-02-18 01:56:23 -07:00
Peter Jaszkowiak
52f2028206
ESlint no-multiple-empty-lines
2017-02-17 22:08:23 -07:00
Peter Jaszkowiak
bc1d70c126
ESlint comma-dangle
2017-02-17 19:31:21 -07:00
Julian Lam
eae541d040
Merge branch 'master' into develop
2017-02-10 16:22:12 -05:00
Ben Lubar
9fb16e3520
Fix forum instances using Redis dropping socket.io messages.
...
Bug introduced in b08acd197c .
https://github.com/socketio/socket.io-redis/releases/tag/3.0.0
https://github.com/socketio/socket.io-redis/issues/185
2017-02-10 14:28:53 -06:00