Commit Graph

871 Commits

Author SHA1 Message Date
Barış Soner Uşaklı
5e7d366f55 fix: #10584, dont show backlinks if you dont have read privilege 2022-05-06 14:01:08 -04:00
Barış Soner Uşaklı
ea01ba0152 fix: #10569, fix category move event text 2022-05-03 14:19:38 -04:00
Barış Soner Uşaklı
d20b07cfea Webpack5 (#10311)
* feat: webpack 5 part 1

* fix: gruntfile fixes

* fix: fix taskbar warning

add app.importScript
copy public/src/modules to build folder

* refactor: remove commented old code

* feat: reenable admin

* fix: acp settings pages, fix sortable on manage categories

embedded require in html not allowed

* fix: bundle serialize/deserizeli so plugins dont break

* test: fixe util tests

* test: fix require path

* test: more test fixes

* test: require correct utils module

* test: require correct utils

* test: log stack

* test: fix db require blowing up tests

* test: move and disable bundle test

* refactor: add aliases

* test: disable testing route

* fix: move webpack modules necessary for build, into `dependencies`

* test: fix one more test

remove 500-embed.tpl

* fix: restore use of assets/nodebb.min.js, at least for now

* fix: remove unnecessary line break

* fix: point to proper ACP bundle

* test: maybe fix build test

* test: composer

* refactor: dont need dist

* refactor: more cleanup

use everything from build/public folder

* get rid of conditional import in app.js

* fix: ace

* refactor: cropper alias

* test: lint and test fixes

* lint: fix

* refactor: rename function to app.require

* refactor: go back to using app.require

* chore: use github branch

* chore: use webpack branch

* feat: webpack webinstaller

* feat: add chunkFile name with contenthash

* refactor: move hooks to top

* refactor: get rid of template500Function

* fix(deps): use webpack5 branch of 2factor plugin

* chore: tagging v2.0.0-beta.0 pre-release version 💥 :shipit: 🎉 🚀

* refactor: disable cache on templates

loadTemplate is called once by benchpress and the result is cache internally

* refactor: add server side helpers.js

* feat: deprecate /plugins shorthand route, closes #10343

* refactor: use build/public for webpack

* test: fix filename

* fix: more specific selector

* lint: ignore

* refactor: fix comments

* test: add debug for random failing test

* refactor: cleanup

remove test page, remove dupe functions in utils.common

* lint: use relative path  for now

* chore: bump prerelease version

* feat: add translateKeys

* fix: optional params

* fix: get rid of extra timeago files

* refactor: cleanup, require timeago locale earlier

remove translator.prepareDOM, it is in header.tpl html tag

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels (#10378)

* refactor: privileges system to use a Map in the backend instead of separate objects for keys and labels

- Existing hooks are preserved (to be deprecated at a later date, possibly)
- New init hooks are called on NodeBB start, and provide a one-stop shop to add new privileges, instead of having to add to four different hooks

* docs: fix typo in comment

* test: spec changes

* feat: allow app.require('bootbox'/'benchpressjs')

* refactor: require server side utils

* test: jquery ready

* change istaller to use build/public

* test: use document.addEventListener

* refactor: closes #10301

* refactor: generateTopicClass

* fix: column counts for other privileges

* fix: #10443, regression where sorted-list items did not render into the DOM in the predicted order [breaking]

* fix: typo in hook name

* refactor: introduce a generic autocomplete.init() method that can be called to add nodebb-style autocompletion but using different data sources (e.g. not user/groups/tags)

* fix: crash if `delay` not passed in (as it cannot be destructured)

* refactor: replace substr

* feat: set --panel-offset style in html element based on stored value in localStorage

* refactor: addDropupHandler() logic to be less naive

- Take into account height of the menu
- Don't apply dropUp logic if there's nothing in the dropdown
- Remove 'hidden' class (added by default in Persona for post tools) when menu items are added

closes #10423

* refactor: simplify utils.params [breaking]

Retrospective analysis of the usage of this method suggests that the options passed in are superfluous, and that only `url` is required. Using a browser built-in makes more sense to accomplish what this method sets out to do.

* feat: add support for returning full URLSearchParams for utils.params

* fix: utils.params() fallback handling

* fix: default empty obj for params()

* fix: remove \'loggedin\' and \'register\' qs parameters once they have been used, delay invocation of messages until ajaxify.end

* fix: utils.params() not allowing relative paths to be passed in

* refactor(DRY): new assertPasswordValidity utils method

* fix: incorrect error message returned on insufficient privilege on flag edit

* fix: read/update/delete access to flags API should be limited for moderators to only post flags in categories they moderate

- added failing tests and patched up middleware.assert.flags to fix

* refactor: flag api v3 tests to create new post and flags on every round

* fix: missing error:no-flag language key

* refactor: flags.canView to check flag existence, simplify middleware.assert.flag

* feat: flag deletion API endpoint, #10426

* feat: UI for flag deletion, closes #10426

* chore: update plugin versions

* chore: up emoji

* chore: update markdown

* chore: up emoji-android

* fix: regression caused by utils.params() refactor, supports arrays and pipes all values through utils.toType, adjusts tests to type check

Co-authored-by: Julian Lam <julian@nodebb.org>
2022-04-29 21:39:33 -04:00
Barış Soner Uşaklı
a8e642ade2 refactor: skip content length check if submitting from post-queue 2022-04-21 12:23:37 -04:00
Barış Soner Uşaklı
767973717b perf: WIP #10449, allow array of pids for posts.purge (#10465)
* perf: WIP #10449, allow array of pids for posts.purge

* refactor: deletePostDiffs

* perf: deletePostFromReplies/deletePostFromGroups

* refactor: upload

* refactor: deleteFromCategoryRecentPosts

deleteFromUsersBookmarks
deleteFromUsersVotes

* feat: closes #10468, add incrObjectFieldByBulk

* refactor: allow nids for notifications.rescind

* refactor: allow uids array for user.updatePostCount

* refactor: rewrite deleteFromTopicUserNotification to work with an array

* feat: deprecate action:post.purge as well

* lint: add missing comma
2022-04-07 14:06:25 -04:00
Barış Soner Uşaklı
799e94e02e feat: #10460, add cutoff to suggested topics 2022-04-05 15:37:31 -04:00
Barış Soner Uşaklı
3935a86b83 fix: topic events if there is a blocked user in topic 2022-03-16 16:56:07 -04:00
Barış Soner Uşaklı
2808c952c5 fix: topic events disappearing if there are queued posts 2022-03-16 15:52:59 -04:00
Julian Lam
fb78570c13 test: fix topic thumb tests and topic thumbs to work properly with post upload assoc. 2022-02-14 15:02:07 -05:00
Julian Lam
6489e9fd9e refactor: change the post uploads' hash seeds to have the files/ prefix 2022-02-14 15:02:07 -05:00
Julian Lam
0f788b8eaa fix: #10257, topic thumbs not deleting on topic deletion 2022-02-07 17:29:34 -05:00
Barış Soner Uşaklı
079c487dcb fix: controversial posts/bests posts not showing anything
fix upgrade script so posts with negative votes are stored, a post can have 10 upvotes and 2 downvotes
fix missing negative votes checks
remove unnecessary pids flters since the cids are only already filtered by topics:read
2022-02-04 21:52:44 -05:00
Magnus
7bd3e31dec Fullname in notifications (#10157)
* init - fullname notifications setting

* fullname in topic reply

* fullname for group-request-membership

* fullname for group-leave notification

* fullname for new-post-flag & new-user-flag

* removed log

* fullname for user follow

* fullname in message notification

* fullname in follow

* fullname for sendNotificationToPostOwner

* fullname in sendNotificationToTopicOwner

* fullname in doExport

* shorthand name set

* shorter name set

* fullname in notifications

* displayname for notifications

* removed unused require
2022-01-19 10:19:11 -05:00
Barış Soner Uşaklı
f9279b636b fix: post indices if there is a blocked user in topic 2022-01-18 20:31:06 -05:00
Barış Soner Uşaklı
3b72ff8742 fix: dont add duplicate link backs 2022-01-18 20:12:50 -05:00
Barış Soner Uşaklı
b06c6329e4 fix: #10175, fix topic linkbacks duplicating on post edit 2022-01-17 19:05:07 -05:00
Barış Soner Uşaklı
4799efc790 fix: #10167, fix regression prevent guest post 2022-01-15 10:29:52 -05:00
Barış Soner Uşaklı
a75a043b61 feat: allow % in tags, #10135 2022-01-10 16:44:16 -05:00
Barış Soner Uşaklı
0d9ec9d30e test: fix restore test 2021-12-28 21:36:37 -05:00
Barış Soner Uşaklı
f918a38164 breaking: remove socket.emit('topics.follow')
remove socket.emit('topics.changeWatching')
2021-12-13 12:55:54 -05:00
Barış Soner Uşaklı
6ad0472106 breaking: remove socket.emit('topics.post')
remove socket.emit('topics.search')
remove socket.emit('topics.getTopic')
2021-12-12 13:14:08 -05:00
Julian Lam
45c9dde319 fix: no need to pass 'img' to teaser tags stripping as images are already converted to alt text 2021-12-10 10:18:16 -05:00
Barış Soner Uşaklı
a20abdce02 lint: remove unused 2021-12-06 17:07:32 -05:00
Barış Soner Uşaklı
36eb47d9a0 refactor: change var name 2021-12-06 17:00:50 -05:00
Barış Soner Uşaklı
170e5dd941 breaking: remove getTopicPosts(tid, ...) usage 2021-12-06 17:00:25 -05:00
Barış Soner Uşaklı
906dc5675e fix: handle start=0 stop=0 for topics.getTopicPosts
add more tests
2021-12-06 16:36:30 -05:00
Barış Soner Uşaklı
a29535833f fix: #10052, dont use spaces in tag class name 2021-12-02 10:58:23 -05:00
Barış Soner Uşaklı
1cdb0b1e19 fix: don't crash if tid is falsy 2021-11-30 15:47:19 -05:00
Barış Soner Uşaklı
1e53552874 feat: closes #10018 2021-11-26 17:08:47 -05:00
Baris Usakli
06bfec8840 feat: #10018 add href 2021-11-26 14:42:57 -05:00
Baris Usakli
0f14f23b2a feat: #10018 , wip 2021-11-26 14:41:46 -05:00
Barış Soner Uşaklı
fb363957d1 refactor: tab rules 2021-11-18 16:42:18 -05:00
Barış Soner Uşaklı
d5bfd51267 fix: #10010, handle reverse sorting for topic events
dont add events to dom if sort is most votes
if sorting is reverse add new events after the main post or at the top instead of bottom
2021-11-17 23:34:01 -05:00
Barış Soner Uşaklı
258f368e32 refactor: add filter:topic.getPosts
this hook only fires when loading the posts of a topic cold load + infinite scroll
do not remove posts if they have index =-1
use topics.getTopicPosts instead of getMainPostAndReplies
2021-11-15 18:08:09 -05:00
Barış Soner Uşaklı
8379c11b22 refactor: setObjectBulk to match sortedSetAddBulk 2021-11-12 19:51:59 -05:00
Barış Soner Uşaklı
d196409580 refactor: remove more async.eachSeries/mapSeries 2021-11-10 20:55:06 -05:00
Barış Soner Uşaklı
28dd31a8e7 fix: #9976 2021-11-05 14:12:45 -04:00
Barış Soner Uşaklı
3d611ab70e fix: events for just topic with main post 2021-10-31 16:13:16 -04:00
Barış Soner Uşaklı
89399c0ed5 fix: #9954, get next post timestamp
fixes topic events being inserted in after first page but at the wrong spot
2021-10-31 15:09:33 -04:00
Barış Soner Uşaklı
4333d217a1 fix: #9917, show topics as unread for guests 2021-10-18 14:17:42 -04:00
Barış Soner Uşaklı
6c25b9dbaa test: remove escape 2021-10-07 16:24:53 -04:00
Barış Soner Uşaklı
4f9717fb08 fix: escape thumbs, allow robots meta tag 2021-10-07 15:20:41 -04:00
Julian Lam
be43cd2597 Topic Linkbacks (#9825)
* feat: WIP topic linkbacks, + failing tests

* test: don't accidentally comment out all of the post tests

* fix: rename to "backlinks"

* feat: more stub code, more failing tests

* feat: backend methods and passing tests for topic backlinks

* test: uncomment test/posts.js again

* fix: missing quotation mark in topic event helper

* fix: superfluous usage of Promise.all

* test: fix broken test -- used hardcoded (and incorrect) url

* test: parseInt shenanigans
2021-09-29 12:26:15 -04:00
Barış Soner Uşaklı
6399b42826 feat: closes #9845, sort by views 2021-09-28 11:13:56 -04:00
Julian Lam
ce8ea6ea42 fix: bad uid reference 2021-09-21 13:03:59 -04:00
Julian Lam
f194809f06 feat: move filter:topic.post hook to top of method 2021-09-21 13:00:45 -04:00
Julian Lam
7777812e62 fix: update Topics.post and Topics.reply so that plugins can modify uid (or redirect a reply to a different topic)
/cc @antosik
2021-09-21 11:26:17 -04:00
Barış Soner Uşaklı
2657804c1f fix: #9790, fix sorting of more than one page of pinned topics 2021-09-11 17:57:42 -04:00
psychobunny
ae793b4a44 chore: found some hooks that don't play well docgen 2021-08-31 10:45:08 -04:00
Barış Soner Uşaklı
358ad74054 feat: closes #9684, allow event deletion
fix: topic events appearing before necro messages
feat: add move topic event
feat: add ability to delete specific topic events via events.purge
2021-08-10 19:39:51 -04:00