From ff1b7a0faae9c8d05f38ac476c6eb3226d14281c Mon Sep 17 00:00:00 2001
From: Julian Lam <julian@nodebb.org>
Date: Thu, 13 Mar 2025 16:06:06 -0400
Subject: [PATCH] feat: also include category in `to` field when mocking post
 for federation

---
 src/activitypub/mocks.js | 2 +-
 src/activitypub/notes.js | 1 +
 src/categories/topics.js | 1 -
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/activitypub/mocks.js b/src/activitypub/mocks.js
index 1108937eee..c9bcaedd9a 100644
--- a/src/activitypub/mocks.js
+++ b/src/activitypub/mocks.js
@@ -557,7 +557,6 @@ Mocks.notes.public = async (post) => {
 	const published = post.timestampISO;
 	const updated = post.edited ? post.editedISO : null;
 
-	// todo: post visibility
 	const to = new Set([activitypub._constants.publicAddress]);
 	const cc = new Set([`${nconf.get('url')}/uid/${post.user.uid}/followers`]);
 
@@ -728,6 +727,7 @@ Mocks.notes.public = async (post) => {
 			audience = post.audience || audience;
 		});
 	}
+	to.add(audience);
 
 	let object = {
 		'@context': 'https://www.w3.org/ns/activitystreams',
diff --git a/src/activitypub/notes.js b/src/activitypub/notes.js
index b47730ffc7..51d8a1a03f 100644
--- a/src/activitypub/notes.js
+++ b/src/activitypub/notes.js
@@ -79,6 +79,7 @@ Notes.assert = async (uid, input, options = { skipChecks: false }) => {
 	const hasTid = !!tid;
 
 	const cid = hasTid ? await topics.getTopicField(tid, 'cid') : options.cid || -1;
+
 	if (options.cid && cid === -1) {
 		// Move topic if currently uncategorized
 		await topics.tools.move(tid, { cid: options.cid, uid: 'system' });
diff --git a/src/categories/topics.js b/src/categories/topics.js
index cd13deaf4b..64e9046614 100644
--- a/src/categories/topics.js
+++ b/src/categories/topics.js
@@ -31,7 +31,6 @@ module.exports = function (Categories) {
 			Categories.getPinnedTids({ ...data, start: 0, stop: -1 }),
 			Categories.buildTopicsSortedSet(data),
 		]);
-		console.log(set);
 
 		const totalPinnedCount = pinnedTids.length;
 		const pinnedTidsOnPage = pinnedTids.slice(data.start, data.stop !== -1 ? data.stop + 1 : undefined);