Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 08:36:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: inability for plugins to actually alter parser sanitization config

Browse Source 
/cc @pitaj
This commit is contained in:
Julian Lam
2019-09-04 11:42:49 -04:00
parent ad96b0e0db
commit fe452762b7
2 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/index.js
View File

@@ -155,6 +155,9 @@ Plugins.reload = async function () {
Object.keys(Plugins.loadedHooks).forEach(function (hook) { Object.keys(Plugins.loadedHooks).forEach(function (hook) {
Plugins.loadedHooks[hook].sort((a, b) => a.priority - b.priority); Plugins.loadedHooks[hook].sort((a, b) => a.priority - b.priority);
}); });
// Post-reload actions
await posts.configureSanitize();
}; };
Plugins.reloadRoutes = async function (params) { Plugins.reloadRoutes = async function (params) {

19
src/posts/parse.js
View File

@@ -35,16 +35,6 @@ let sanitizeConfig = {
], ],
}; };
process.nextTick(async () => {
// Each allowed tags should have some common global attributes...
sanitizeConfig.allowedTags.forEach((tag) => {
sanitizeConfig.allowedAttributes[tag] = _.union(sanitizeConfig.allowedAttributes[tag], sanitizeConfig.globalAttributes);
});
// Some plugins might need to adjust or whitelist their own tags...
sanitizeConfig = await plugins.fireHook('filter:sanitize.config', sanitizeConfig);
});
module.exports = function (Posts) { module.exports = function (Posts) {
Posts.urlRegex = { Posts.urlRegex = {
regex: /href="([^"]+)"/g, regex: /href="([^"]+)"/g,
@@ -119,6 +109,15 @@ module.exports = function (Posts) {
}); });
}; };
Posts.configureSanitize = async () => {
// Each allowed tags should have some common global attributes...
sanitizeConfig.allowedTags.forEach((tag) => {
sanitizeConfig.allowedAttributes[tag] = _.union(sanitizeConfig.allowedAttributes[tag], sanitizeConfig.globalAttributes);
});
sanitizeConfig = await plugins.fireHook('filter:sanitize.config', sanitizeConfig);
};
function sanitizeSignature(signature) { function sanitizeSignature(signature) {
signature = translator.escape(signature); signature = translator.escape(signature);
var tagsToStrip = []; var tagsToStrip = [];