make /top faster too

This commit is contained in:
Barış Soner Uşaklı
2024-04-26 12:12:48 -04:00
parent 94eafe1df3
commit fd35dd17b1

View File

@@ -47,7 +47,10 @@ module.exports = function (Topics) {
if (params.sort === 'posts') { if (params.sort === 'posts') {
tids = await getTidsWithMostPostsInTerm(params.cids, params.uid, params.term); tids = await getTidsWithMostPostsInTerm(params.cids, params.uid, params.term);
} else { } else {
tids = await Topics.getLatestTidsFromSet('topics:tid', 0, -1, params.term); const cids = await getCids(params.cids, params.uid);
tids = await Topics.getLatestTidsFromSet(
cids.map(cid => `cid:${cid}:tids:create`), 0, -1, params.term
);
} }
if (params.filter === 'watched') { if (params.filter === 'watched') {
@@ -84,14 +87,18 @@ module.exports = function (Topics) {
return 'topics:recent'; return 'topics:recent';
} }
async function getTidsWithMostPostsInTerm(cids, uid, term) { async function getCids(cids, uid) {
if (Array.isArray(cids)) { if (Array.isArray(cids)) {
cids = await privileges.categories.filterCids('topics:read', cids, uid); cids = await privileges.categories.filterCids('topics:read', cids, uid);
} else { } else {
cids = await categories.getCidsByPrivilege('categories:cid', uid, 'topics:read'); cids = await categories.getCidsByPrivilege('categories:cid', uid, 'topics:read');
cids = cids.filter(cid => cid !== -1); cids = cids.filter(cid => cid !== -1);
} }
return cids;
}
async function getTidsWithMostPostsInTerm(cids, uid, term) {
cids = await getCids(cids, uid);
const pids = await db.getSortedSetRevRangeByScore( const pids = await db.getSortedSetRevRangeByScore(
cids.map(cid => `cid:${cid}:pids`), cids.map(cid => `cid:${cid}:pids`),
0, 0,