Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat: rename admin middleware header hook

Browse Source
This commit is contained in:
Barış Soner Uşaklı
2020-12-23 10:47:51 -05:00
parent 6d980d26d7
commit fcc1e24ad0
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/middleware/admin.js
View File

@@ -78,9 +78,14 @@ middleware.renderHeader = async (req, res, data) => {
templateValues.template = { name: res.locals.template };
templateValues.template[res.locals.template] = true;
// Normally this should hook be automatically added by middleware.processRender(), but it seems to only be fired for page hooks, and not when called internally.
// remove @1.17.0
({ templateData: templateValues } = await plugins.hooks.fire('filter:admin/header.build', { req, res, templateData: templateValues }));
({ templateData: templateValues } = await plugins.hooks.fire('filter:middleware.renderAdminHeader', {
req,
res,
templateData: templateValues,
data,
}));
return await req.app.renderAsync('admin/header', templateValues);
};

3
src/plugins/hooks.js
View File

@@ -9,7 +9,8 @@ const Hooks = {};
module.exports = Hooks;
Hooks.deprecatedHooks = {
'filter:privileges:isUserAllowedTo': 'filter:privileges:isAllowedTo', // 👋 @ 1.16.0
'filter:privileges:isUserAllowedTo': 'filter:privileges:isAllowedTo', // 👋 @ 1.17.0
'filter:admin/header.build': 'filter:middleware.renderAdminHeader', // 👋 @ 1.17.0
'filter:router.page': 'response:router.page', // 👋 @ 2.0.0
};