Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-12-20 23:40:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

onDisconnect fix

Browse Source
This commit is contained in:
barisusakli
2014-11-28 21:04:12 -05:00
parent 4913866785
commit fa92eb4d5c
1 changed files with 9 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/socket.io/index.js
View File

@@ -96,19 +96,16 @@ function onConnect(socket) {
} }
function onDisconnect(socket) { function onDisconnect(socket) {
var socketCount = Sockets.getUserSocketCount(socket.uid); if (socket.uid) {
var socketCount = Sockets.getUserSocketCount(socket.uid);
if (socketCount <= 0) {
socket.broadcast.emit('event:user_status_change', {uid: socket.uid, status: 'offline'});
}
if (socket.uid && socketCount <= 0) { // TODO: if we can get socket.rooms here this can be made more efficient,
socket.broadcast.emit('event:user_status_change', {uid: socket.uid, status: 'offline'}); // see https://github.com/Automattic/socket.io/issues/1897
io.sockets.in('online_users').emit('event:user_leave', socket.uid);
} }
// TODO : needs fixing for cluster
// for(var roomName in io.sockets.manager.roomClients[socket.id]) {
// if (roomName.indexOf('topic') !== -1) {
// io.sockets.in(roomName.slice(1)).emit('event:user_leave', socket.uid);
// }
// }
} }
function onMessage(socket, payload) { function onMessage(socket, payload) {
@@ -242,7 +239,7 @@ Sockets.getSocketCount = function() {
}; };
Sockets.getUserSocketCount = function(uid) { Sockets.getUserSocketCount = function(uid) {
// TODO: io.sockets.adapter.sids is local to this worker // TODO: io.sockets.adapter.rooms is local to this worker
// use .clients('uid_' + uid, fn) // use .clients('uid_' + uid, fn)
var roomClients = Object.keys(io.sockets.adapter.rooms['uid_' + uid] || {}); var roomClients = Object.keys(io.sockets.adapter.rooms['uid_' + uid] || {});