Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: race condition where navigator.update was called when it should not be

Browse Source
This commit is contained in:
Julian Lam
2022-09-19 11:09:22 -04:00
parent 9f9a835fcb
commit fa643eb808
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
public/src/modules/navigator.js
View File

@@ -581,9 +581,9 @@ define('navigator', ['forum/pagination', 'components', 'hooks', 'alerts'], funct
function animateScroll() { function animateScroll() {
function reenableScroll() { function reenableScroll() {
// Re-enable onScroll behaviour // Re-enable onScroll behaviour
$(window).on('scroll', navigator.delayedUpdate); setTimeout(() => { // fixes race condition from jQuery — onAnimateComplete called too quickly
const scrollToRect = scrollTo.get(0).getBoundingClientRect(); $(window).on('scroll', navigator.delayedUpdate);
navigator.update(scrollToRect.top); }, 50);
} }
function onAnimateComplete() { function onAnimateComplete() {
if (done) { if (done) {