Nemcio/NodeBB
1
0
Fork 0
mirror of https://github.com/NodeBB/NodeBB.git synced 2025-10-26 16:46:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't throw on invalid session, just return early so socket is not opened.

Browse Source 
Also updated the plugin hook call to `static:sockets.validateSession` to not return a result, because in static calls that result is always null anyway
This commit is contained in:
Julian Lam
2021-12-02 14:13:16 -05:00
parent b342338935
commit fa01801f64
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/socket.io/index.js
View File

@@ -89,9 +89,9 @@ async function onConnect(socket) {
} catch (e) { } catch (e) {
if (e.message === '[[error:invalid-session]]') { if (e.message === '[[error:invalid-session]]') {
socket.emit('event:invalid_session'); socket.emit('event:invalid_session');
return;
} }
throw e;
return;
} }
if (socket.uid) { if (socket.uid) {
@@ -208,12 +208,12 @@ async function validateSession(socket, errorMsg) {
if (!sessionData) { if (!sessionData) {
throw new Error(errorMsg); throw new Error(errorMsg);
} }
const result = await plugins.hooks.fire('static:sockets.validateSession', {
await plugins.hooks.fire('static:sockets.validateSession', {
req: req, req: req,
socket: socket, socket: socket,
session: sessionData, session: sessionData,
}); });
return result;
} }
const cookieParserAsync = util.promisify((req, callback) => cookieParser(req, {}, err => callback(err))); const cookieParserAsync = util.promisify((req, callback) => cookieParser(req, {}, err => callback(err)));